diff options
author | Adrian Bunk <bunk@kernel.org> | 2008-03-17 16:29:32 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-04-17 11:41:13 -0400 |
commit | ede1389f8ab4f3a1343e567133fa9720a054a3aa (patch) | |
tree | af3dd4019c786ecadce2f7f3e70eb6446a0a4d31 | |
parent | 6542fe80e6296cde50c1c3b8a9eede701ee51907 (diff) |
x86: remove the write-only timer_uses_ioapic_pin_0
This patch removes the write-only timer_uses_ioapic_pin_0
(gsi can't be <= 15 in the line of it's fake usage in mpparse_32.c).
Spotted by the GNU C compiler.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r-- | arch/x86/kernel/io_apic_32.c | 5 | ||||
-rw-r--r-- | arch/x86/kernel/mpparse_32.c | 3 | ||||
-rw-r--r-- | include/asm-x86/io_apic.h | 1 |
3 files changed, 1 insertions, 8 deletions
diff --git a/arch/x86/kernel/io_apic_32.c b/arch/x86/kernel/io_apic_32.c index 0d70acd3b134..742fab45e1c6 100644 --- a/arch/x86/kernel/io_apic_32.c +++ b/arch/x86/kernel/io_apic_32.c | |||
@@ -2114,8 +2114,6 @@ static inline void unlock_ExtINT_logic(void) | |||
2114 | ioapic_write_entry(apic, pin, entry0); | 2114 | ioapic_write_entry(apic, pin, entry0); |
2115 | } | 2115 | } |
2116 | 2116 | ||
2117 | int timer_uses_ioapic_pin_0; | ||
2118 | |||
2119 | /* | 2117 | /* |
2120 | * This code may look a bit paranoid, but it's supposed to cooperate with | 2118 | * This code may look a bit paranoid, but it's supposed to cooperate with |
2121 | * a wide range of boards and BIOS bugs. Fortunately only the timer IRQ | 2119 | * a wide range of boards and BIOS bugs. Fortunately only the timer IRQ |
@@ -2155,9 +2153,6 @@ static inline void __init check_timer(void) | |||
2155 | pin2 = ioapic_i8259.pin; | 2153 | pin2 = ioapic_i8259.pin; |
2156 | apic2 = ioapic_i8259.apic; | 2154 | apic2 = ioapic_i8259.apic; |
2157 | 2155 | ||
2158 | if (pin1 == 0) | ||
2159 | timer_uses_ioapic_pin_0 = 1; | ||
2160 | |||
2161 | printk(KERN_INFO "..TIMER: vector=0x%02X apic1=%d pin1=%d apic2=%d pin2=%d\n", | 2156 | printk(KERN_INFO "..TIMER: vector=0x%02X apic1=%d pin1=%d apic2=%d pin2=%d\n", |
2162 | vector, apic1, pin1, apic2, pin2); | 2157 | vector, apic1, pin1, apic2, pin2); |
2163 | 2158 | ||
diff --git a/arch/x86/kernel/mpparse_32.c b/arch/x86/kernel/mpparse_32.c index 15dd87110298..15265ee11f89 100644 --- a/arch/x86/kernel/mpparse_32.c +++ b/arch/x86/kernel/mpparse_32.c | |||
@@ -1176,8 +1176,7 @@ int mp_register_gsi(u32 gsi, int triggering, int polarity) | |||
1176 | * So test for this condition, and if necessary, avoid | 1176 | * So test for this condition, and if necessary, avoid |
1177 | * the pin collision. | 1177 | * the pin collision. |
1178 | */ | 1178 | */ |
1179 | if (gsi > 15 || (gsi == 0 && !timer_uses_ioapic_pin_0)) | 1179 | gsi = pci_irq++; |
1180 | gsi = pci_irq++; | ||
1181 | /* | 1180 | /* |
1182 | * Don't assign IRQ used by ACPI SCI | 1181 | * Don't assign IRQ used by ACPI SCI |
1183 | */ | 1182 | */ |
diff --git a/include/asm-x86/io_apic.h b/include/asm-x86/io_apic.h index 0f5b3fef0b08..095e8e30a345 100644 --- a/include/asm-x86/io_apic.h +++ b/include/asm-x86/io_apic.h | |||
@@ -146,7 +146,6 @@ extern int io_apic_get_version(int ioapic); | |||
146 | extern int io_apic_get_redir_entries(int ioapic); | 146 | extern int io_apic_get_redir_entries(int ioapic); |
147 | extern int io_apic_set_pci_routing(int ioapic, int pin, int irq, | 147 | extern int io_apic_set_pci_routing(int ioapic, int pin, int irq, |
148 | int edge_level, int active_high_low); | 148 | int edge_level, int active_high_low); |
149 | extern int timer_uses_ioapic_pin_0; | ||
150 | #endif /* CONFIG_ACPI */ | 149 | #endif /* CONFIG_ACPI */ |
151 | 150 | ||
152 | extern int (*ioapic_renumber_irq)(int ioapic, int irq); | 151 | extern int (*ioapic_renumber_irq)(int ioapic, int irq); |