diff options
author | Jayachandran C <c.jayachandran@gmail.com> | 2006-04-11 02:18:28 -0400 |
---|---|---|
committer | Dave Airlie <airlied@linux.ie> | 2006-04-18 07:04:48 -0400 |
commit | d253258c80117c2afaa644554e613201992e4ee9 (patch) | |
tree | f06a92ad4e76332e9a29bbfc2984392f6ce330e2 | |
parent | 031de96af0e7ed6ad4a7ec2b74a77bf9782f966e (diff) |
drm: Fix further issues in drivers/char/drm/via_irq.c
Fix de-reference of 'dev_priv' before NULL check.
Signed-off-by: Jayachandran C. <c.jayachandran@gmail.com>
Cc: Dave Airlie <airlied@linux.ie>
Signed-off-by: Andrew Morton <akpm@osdl.org>
-rw-r--r-- | drivers/char/drm/via_irq.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/char/drm/via_irq.c b/drivers/char/drm/via_irq.c index 1228fa55355b..c33d068cde19 100644 --- a/drivers/char/drm/via_irq.c +++ b/drivers/char/drm/via_irq.c | |||
@@ -196,7 +196,7 @@ via_driver_irq_wait(drm_device_t * dev, unsigned int irq, int force_sequence, | |||
196 | { | 196 | { |
197 | drm_via_private_t *dev_priv = (drm_via_private_t *) dev->dev_private; | 197 | drm_via_private_t *dev_priv = (drm_via_private_t *) dev->dev_private; |
198 | unsigned int cur_irq_sequence; | 198 | unsigned int cur_irq_sequence; |
199 | drm_via_irq_t *cur_irq = dev_priv->via_irqs; | 199 | drm_via_irq_t *cur_irq; |
200 | int ret = 0; | 200 | int ret = 0; |
201 | maskarray_t *masks; | 201 | maskarray_t *masks; |
202 | int real_irq; | 202 | int real_irq; |
@@ -223,7 +223,7 @@ via_driver_irq_wait(drm_device_t * dev, unsigned int irq, int force_sequence, | |||
223 | } | 223 | } |
224 | 224 | ||
225 | masks = dev_priv->irq_masks; | 225 | masks = dev_priv->irq_masks; |
226 | cur_irq += real_irq; | 226 | cur_irq = dev_priv->via_irqs + real_irq; |
227 | 227 | ||
228 | if (masks[real_irq][2] && !force_sequence) { | 228 | if (masks[real_irq][2] && !force_sequence) { |
229 | DRM_WAIT_ON(ret, cur_irq->irq_queue, 3 * DRM_HZ, | 229 | DRM_WAIT_ON(ret, cur_irq->irq_queue, 3 * DRM_HZ, |
@@ -248,11 +248,12 @@ void via_driver_irq_preinstall(drm_device_t * dev) | |||
248 | { | 248 | { |
249 | drm_via_private_t *dev_priv = (drm_via_private_t *) dev->dev_private; | 249 | drm_via_private_t *dev_priv = (drm_via_private_t *) dev->dev_private; |
250 | u32 status; | 250 | u32 status; |
251 | drm_via_irq_t *cur_irq = dev_priv->via_irqs; | 251 | drm_via_irq_t *cur_irq; |
252 | int i; | 252 | int i; |
253 | 253 | ||
254 | DRM_DEBUG("driver_irq_preinstall: dev_priv: %p\n", dev_priv); | 254 | DRM_DEBUG("driver_irq_preinstall: dev_priv: %p\n", dev_priv); |
255 | if (dev_priv) { | 255 | if (dev_priv) { |
256 | cur_irq = dev_priv->via_irqs; | ||
256 | 257 | ||
257 | dev_priv->irq_enable_mask = VIA_IRQ_VBLANK_ENABLE; | 258 | dev_priv->irq_enable_mask = VIA_IRQ_VBLANK_ENABLE; |
258 | dev_priv->irq_pending_mask = VIA_IRQ_VBLANK_PENDING; | 259 | dev_priv->irq_pending_mask = VIA_IRQ_VBLANK_PENDING; |