aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew Morton <akpm@osdl.org>2005-06-07 02:07:46 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2005-06-28 00:52:46 -0400
commitbb4a61b6eaee01707f24deeefc5d7136f25f75c5 (patch)
tree8d353d7b04addad950de8ae24eda7cdfe6fbea85
parente24c2d963a604d9eaa560c90371fa387d3eec8f1 (diff)
[PATCH] PCI: fix up errors after dma bursting patch and CONFIG_PCI=n
With CONFIG_PCI=n: In file included from include/linux/pci.h:917, from lib/iomap.c:6: include/asm/pci.h:104: warning: `enum pci_dma_burst_strategy' declared inside parameter list include/asm/pci.h:104: warning: its scope is only this definition or declaration, which is probably not what you want. include/asm/pci.h: In function `pci_dma_burst_advice': include/asm/pci.h:106: dereferencing pointer to incomplete type include/asm/pci.h:106: `PCI_DMA_BURST_INFINITY' undeclared (first use in this function) include/asm/pci.h:106: (Each undeclared identifier is reported only once include/asm/pci.h:106: for each function it appears in.) make[1]: *** [lib/iomap.o] Error 1 Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--include/asm-alpha/pci.h2
-rw-r--r--include/asm-arm/pci.h2
-rw-r--r--include/asm-frv/pci.h2
-rw-r--r--include/asm-i386/pci.h2
-rw-r--r--include/asm-ia64/pci.h2
-rw-r--r--include/asm-mips/pci.h2
-rw-r--r--include/asm-parisc/pci.h2
-rw-r--r--include/asm-ppc/pci.h2
-rw-r--r--include/asm-ppc64/pci.h2
-rw-r--r--include/asm-sh/pci.h2
-rw-r--r--include/asm-sh64/pci.h2
-rw-r--r--include/asm-sparc/pci.h2
-rw-r--r--include/asm-sparc64/pci.h2
-rw-r--r--include/asm-v850/pci.h2
-rw-r--r--include/asm-x86_64/pci.h2
-rw-r--r--include/linux/pci.h2
16 files changed, 32 insertions, 0 deletions
diff --git a/include/asm-alpha/pci.h b/include/asm-alpha/pci.h
index 6c71dc1ad4ca..b7806aa3785c 100644
--- a/include/asm-alpha/pci.h
+++ b/include/asm-alpha/pci.h
@@ -223,6 +223,7 @@ pci_dac_dma_sync_single_for_device(struct pci_dev *pdev, dma64_addr_t dma_addr,
223 /* Nothing to do. */ 223 /* Nothing to do. */
224} 224}
225 225
226#ifdef CONFIG_PCI
226static inline void pci_dma_burst_advice(struct pci_dev *pdev, 227static inline void pci_dma_burst_advice(struct pci_dev *pdev,
227 enum pci_dma_burst_strategy *strat, 228 enum pci_dma_burst_strategy *strat,
228 unsigned long *strategy_parameter) 229 unsigned long *strategy_parameter)
@@ -239,6 +240,7 @@ static inline void pci_dma_burst_advice(struct pci_dev *pdev,
239 *strat = PCI_DMA_BURST_BOUNDARY; 240 *strat = PCI_DMA_BURST_BOUNDARY;
240 *strategy_parameter = cacheline_size; 241 *strategy_parameter = cacheline_size;
241} 242}
243#endif
242 244
243/* TODO: integrate with include/asm-generic/pci.h ? */ 245/* TODO: integrate with include/asm-generic/pci.h ? */
244static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel) 246static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel)
diff --git a/include/asm-arm/pci.h b/include/asm-arm/pci.h
index bc2ec425aca5..e300646fe650 100644
--- a/include/asm-arm/pci.h
+++ b/include/asm-arm/pci.h
@@ -42,6 +42,7 @@ static inline void pcibios_penalize_isa_irq(int irq)
42#define pci_unmap_len(PTR, LEN_NAME) ((PTR)->LEN_NAME) 42#define pci_unmap_len(PTR, LEN_NAME) ((PTR)->LEN_NAME)
43#define pci_unmap_len_set(PTR, LEN_NAME, VAL) (((PTR)->LEN_NAME) = (VAL)) 43#define pci_unmap_len_set(PTR, LEN_NAME, VAL) (((PTR)->LEN_NAME) = (VAL))
44 44
45#ifdef CONFIG_PCI
45static inline void pci_dma_burst_advice(struct pci_dev *pdev, 46static inline void pci_dma_burst_advice(struct pci_dev *pdev,
46 enum pci_dma_burst_strategy *strat, 47 enum pci_dma_burst_strategy *strat,
47 unsigned long *strategy_parameter) 48 unsigned long *strategy_parameter)
@@ -49,6 +50,7 @@ static inline void pci_dma_burst_advice(struct pci_dev *pdev,
49 *strat = PCI_DMA_BURST_INFINITY; 50 *strat = PCI_DMA_BURST_INFINITY;
50 *strategy_parameter = ~0UL; 51 *strategy_parameter = ~0UL;
51} 52}
53#endif
52 54
53#define HAVE_PCI_MMAP 55#define HAVE_PCI_MMAP
54extern int pci_mmap_page_range(struct pci_dev *dev, struct vm_area_struct *vma, 56extern int pci_mmap_page_range(struct pci_dev *dev, struct vm_area_struct *vma,
diff --git a/include/asm-frv/pci.h b/include/asm-frv/pci.h
index 13427240664f..b4efe5e3591a 100644
--- a/include/asm-frv/pci.h
+++ b/include/asm-frv/pci.h
@@ -57,6 +57,7 @@ extern void pci_free_consistent(struct pci_dev *hwdev, size_t size,
57 */ 57 */
58#define PCI_DMA_BUS_IS_PHYS (1) 58#define PCI_DMA_BUS_IS_PHYS (1)
59 59
60#ifdef CONFIG_PCI
60static inline void pci_dma_burst_advice(struct pci_dev *pdev, 61static inline void pci_dma_burst_advice(struct pci_dev *pdev,
61 enum pci_dma_burst_strategy *strat, 62 enum pci_dma_burst_strategy *strat,
62 unsigned long *strategy_parameter) 63 unsigned long *strategy_parameter)
@@ -64,6 +65,7 @@ static inline void pci_dma_burst_advice(struct pci_dev *pdev,
64 *strat = PCI_DMA_BURST_INFINITY; 65 *strat = PCI_DMA_BURST_INFINITY;
65 *strategy_parameter = ~0UL; 66 *strategy_parameter = ~0UL;
66} 67}
68#endif
67 69
68/* 70/*
69 * These are pretty much arbitary with the CoMEM implementation. 71 * These are pretty much arbitary with the CoMEM implementation.
diff --git a/include/asm-i386/pci.h b/include/asm-i386/pci.h
index bf07b3af85e3..3561899eb826 100644
--- a/include/asm-i386/pci.h
+++ b/include/asm-i386/pci.h
@@ -99,6 +99,7 @@ static inline void pcibios_add_platform_entries(struct pci_dev *dev)
99{ 99{
100} 100}
101 101
102#ifdef CONFIG_PCI
102static inline void pci_dma_burst_advice(struct pci_dev *pdev, 103static inline void pci_dma_burst_advice(struct pci_dev *pdev,
103 enum pci_dma_burst_strategy *strat, 104 enum pci_dma_burst_strategy *strat,
104 unsigned long *strategy_parameter) 105 unsigned long *strategy_parameter)
@@ -106,6 +107,7 @@ static inline void pci_dma_burst_advice(struct pci_dev *pdev,
106 *strat = PCI_DMA_BURST_INFINITY; 107 *strat = PCI_DMA_BURST_INFINITY;
107 *strategy_parameter = ~0UL; 108 *strategy_parameter = ~0UL;
108} 109}
110#endif
109 111
110#endif /* __KERNEL__ */ 112#endif /* __KERNEL__ */
111 113
diff --git a/include/asm-ia64/pci.h b/include/asm-ia64/pci.h
index c9f1ab4e477d..0c4c5d801d3f 100644
--- a/include/asm-ia64/pci.h
+++ b/include/asm-ia64/pci.h
@@ -82,6 +82,7 @@ extern int pcibios_prep_mwi (struct pci_dev *);
82#define sg_dma_len(sg) ((sg)->dma_length) 82#define sg_dma_len(sg) ((sg)->dma_length)
83#define sg_dma_address(sg) ((sg)->dma_address) 83#define sg_dma_address(sg) ((sg)->dma_address)
84 84
85#ifdef CONFIG_PCI
85static inline void pci_dma_burst_advice(struct pci_dev *pdev, 86static inline void pci_dma_burst_advice(struct pci_dev *pdev,
86 enum pci_dma_burst_strategy *strat, 87 enum pci_dma_burst_strategy *strat,
87 unsigned long *strategy_parameter) 88 unsigned long *strategy_parameter)
@@ -98,6 +99,7 @@ static inline void pci_dma_burst_advice(struct pci_dev *pdev,
98 *strat = PCI_DMA_BURST_MULTIPLE; 99 *strat = PCI_DMA_BURST_MULTIPLE;
99 *strategy_parameter = cacheline_size; 100 *strategy_parameter = cacheline_size;
100} 101}
102#endif
101 103
102#define HAVE_PCI_MMAP 104#define HAVE_PCI_MMAP
103extern int pci_mmap_page_range (struct pci_dev *dev, struct vm_area_struct *vma, 105extern int pci_mmap_page_range (struct pci_dev *dev, struct vm_area_struct *vma,
diff --git a/include/asm-mips/pci.h b/include/asm-mips/pci.h
index 20b93bfa4565..2d323b6e147d 100644
--- a/include/asm-mips/pci.h
+++ b/include/asm-mips/pci.h
@@ -130,6 +130,7 @@ extern void pci_dac_dma_sync_single_for_cpu(struct pci_dev *pdev,
130extern void pci_dac_dma_sync_single_for_device(struct pci_dev *pdev, 130extern void pci_dac_dma_sync_single_for_device(struct pci_dev *pdev,
131 dma64_addr_t dma_addr, size_t len, int direction); 131 dma64_addr_t dma_addr, size_t len, int direction);
132 132
133#ifdef CONFIG_PCI
133static inline void pci_dma_burst_advice(struct pci_dev *pdev, 134static inline void pci_dma_burst_advice(struct pci_dev *pdev,
134 enum pci_dma_burst_strategy *strat, 135 enum pci_dma_burst_strategy *strat,
135 unsigned long *strategy_parameter) 136 unsigned long *strategy_parameter)
@@ -137,6 +138,7 @@ static inline void pci_dma_burst_advice(struct pci_dev *pdev,
137 *strat = PCI_DMA_BURST_INFINITY; 138 *strat = PCI_DMA_BURST_INFINITY;
138 *strategy_parameter = ~0UL; 139 *strategy_parameter = ~0UL;
139} 140}
141#endif
140 142
141extern void pcibios_resource_to_bus(struct pci_dev *dev, 143extern void pcibios_resource_to_bus(struct pci_dev *dev,
142 struct pci_bus_region *region, struct resource *res); 144 struct pci_bus_region *region, struct resource *res);
diff --git a/include/asm-parisc/pci.h b/include/asm-parisc/pci.h
index f9f5bf90111d..ee741c150176 100644
--- a/include/asm-parisc/pci.h
+++ b/include/asm-parisc/pci.h
@@ -230,6 +230,7 @@ extern inline void pcibios_register_hba(struct pci_hba_data *x)
230/* export the pci_ DMA API in terms of the dma_ one */ 230/* export the pci_ DMA API in terms of the dma_ one */
231#include <asm-generic/pci-dma-compat.h> 231#include <asm-generic/pci-dma-compat.h>
232 232
233#ifdef CONFIG_PCI
233static inline void pci_dma_burst_advice(struct pci_dev *pdev, 234static inline void pci_dma_burst_advice(struct pci_dev *pdev,
234 enum pci_dma_burst_strategy *strat, 235 enum pci_dma_burst_strategy *strat,
235 unsigned long *strategy_parameter) 236 unsigned long *strategy_parameter)
@@ -246,6 +247,7 @@ static inline void pci_dma_burst_advice(struct pci_dev *pdev,
246 *strat = PCI_DMA_BURST_MULTIPLE; 247 *strat = PCI_DMA_BURST_MULTIPLE;
247 *strategy_parameter = cacheline_size; 248 *strategy_parameter = cacheline_size;
248} 249}
250#endif
249 251
250extern void 252extern void
251pcibios_resource_to_bus(struct pci_dev *dev, struct pci_bus_region *region, 253pcibios_resource_to_bus(struct pci_dev *dev, struct pci_bus_region *region,
diff --git a/include/asm-ppc/pci.h b/include/asm-ppc/pci.h
index 669e9de7a525..db0a2a0ec74d 100644
--- a/include/asm-ppc/pci.h
+++ b/include/asm-ppc/pci.h
@@ -69,6 +69,7 @@ extern unsigned long pci_bus_to_phys(unsigned int ba, int busnr);
69#define pci_unmap_len(PTR, LEN_NAME) (0) 69#define pci_unmap_len(PTR, LEN_NAME) (0)
70#define pci_unmap_len_set(PTR, LEN_NAME, VAL) do { } while (0) 70#define pci_unmap_len_set(PTR, LEN_NAME, VAL) do { } while (0)
71 71
72#ifdef CONFIG_PCI
72static inline void pci_dma_burst_advice(struct pci_dev *pdev, 73static inline void pci_dma_burst_advice(struct pci_dev *pdev,
73 enum pci_dma_burst_strategy *strat, 74 enum pci_dma_burst_strategy *strat,
74 unsigned long *strategy_parameter) 75 unsigned long *strategy_parameter)
@@ -76,6 +77,7 @@ static inline void pci_dma_burst_advice(struct pci_dev *pdev,
76 *strat = PCI_DMA_BURST_INFINITY; 77 *strat = PCI_DMA_BURST_INFINITY;
77 *strategy_parameter = ~0UL; 78 *strategy_parameter = ~0UL;
78} 79}
80#endif
79 81
80/* 82/*
81 * At present there are very few 32-bit PPC machines that can have 83 * At present there are very few 32-bit PPC machines that can have
diff --git a/include/asm-ppc64/pci.h b/include/asm-ppc64/pci.h
index 20beb10c0902..d12dfce21e20 100644
--- a/include/asm-ppc64/pci.h
+++ b/include/asm-ppc64/pci.h
@@ -78,6 +78,7 @@ static inline int pci_dac_dma_supported(struct pci_dev *hwdev,u64 mask)
78 return 0; 78 return 0;
79} 79}
80 80
81#ifdef CONFIG_PCI
81static inline void pci_dma_burst_advice(struct pci_dev *pdev, 82static inline void pci_dma_burst_advice(struct pci_dev *pdev,
82 enum pci_dma_burst_strategy *strat, 83 enum pci_dma_burst_strategy *strat,
83 unsigned long *strategy_parameter) 84 unsigned long *strategy_parameter)
@@ -94,6 +95,7 @@ static inline void pci_dma_burst_advice(struct pci_dev *pdev,
94 *strat = PCI_DMA_BURST_MULTIPLE; 95 *strat = PCI_DMA_BURST_MULTIPLE;
95 *strategy_parameter = cacheline_size; 96 *strategy_parameter = cacheline_size;
96} 97}
98#endif
97 99
98extern int pci_domain_nr(struct pci_bus *bus); 100extern int pci_domain_nr(struct pci_bus *bus);
99 101
diff --git a/include/asm-sh/pci.h b/include/asm-sh/pci.h
index 7237bc6a7280..26044889c770 100644
--- a/include/asm-sh/pci.h
+++ b/include/asm-sh/pci.h
@@ -96,6 +96,7 @@ static inline void pcibios_penalize_isa_irq(int irq)
96#define sg_dma_address(sg) (virt_to_bus((sg)->dma_address)) 96#define sg_dma_address(sg) (virt_to_bus((sg)->dma_address))
97#define sg_dma_len(sg) ((sg)->length) 97#define sg_dma_len(sg) ((sg)->length)
98 98
99#ifdef CONFIG_PCI
99static inline void pci_dma_burst_advice(struct pci_dev *pdev, 100static inline void pci_dma_burst_advice(struct pci_dev *pdev,
100 enum pci_dma_burst_strategy *strat, 101 enum pci_dma_burst_strategy *strat,
101 unsigned long *strategy_parameter) 102 unsigned long *strategy_parameter)
@@ -103,6 +104,7 @@ static inline void pci_dma_burst_advice(struct pci_dev *pdev,
103 *strat = PCI_DMA_BURST_INFINITY; 104 *strat = PCI_DMA_BURST_INFINITY;
104 *strategy_parameter = ~0UL; 105 *strategy_parameter = ~0UL;
105} 106}
107#endif
106 108
107/* Board-specific fixup routines. */ 109/* Board-specific fixup routines. */
108extern void pcibios_fixup(void); 110extern void pcibios_fixup(void);
diff --git a/include/asm-sh64/pci.h b/include/asm-sh64/pci.h
index 0ac15ab01cce..c68870e02d91 100644
--- a/include/asm-sh64/pci.h
+++ b/include/asm-sh64/pci.h
@@ -86,6 +86,7 @@ static inline void pcibios_penalize_isa_irq(int irq)
86#define sg_dma_address(sg) ((sg)->dma_address) 86#define sg_dma_address(sg) ((sg)->dma_address)
87#define sg_dma_len(sg) ((sg)->length) 87#define sg_dma_len(sg) ((sg)->length)
88 88
89#ifdef CONFIG_PCI
89static inline void pci_dma_burst_advice(struct pci_dev *pdev, 90static inline void pci_dma_burst_advice(struct pci_dev *pdev,
90 enum pci_dma_burst_strategy *strat, 91 enum pci_dma_burst_strategy *strat,
91 unsigned long *strategy_parameter) 92 unsigned long *strategy_parameter)
@@ -93,6 +94,7 @@ static inline void pci_dma_burst_advice(struct pci_dev *pdev,
93 *strat = PCI_DMA_BURST_INFINITY; 94 *strat = PCI_DMA_BURST_INFINITY;
94 *strategy_parameter = ~0UL; 95 *strategy_parameter = ~0UL;
95} 96}
97#endif
96 98
97/* Board-specific fixup routines. */ 99/* Board-specific fixup routines. */
98extern void pcibios_fixup(void); 100extern void pcibios_fixup(void);
diff --git a/include/asm-sparc/pci.h b/include/asm-sparc/pci.h
index 2fd65db95e92..44bb38758c96 100644
--- a/include/asm-sparc/pci.h
+++ b/include/asm-sparc/pci.h
@@ -144,6 +144,7 @@ extern inline int pci_dma_supported(struct pci_dev *hwdev, u64 mask)
144 144
145#define pci_dac_dma_supported(dev, mask) (0) 145#define pci_dac_dma_supported(dev, mask) (0)
146 146
147#ifdef CONFIG_PCI
147static inline void pci_dma_burst_advice(struct pci_dev *pdev, 148static inline void pci_dma_burst_advice(struct pci_dev *pdev,
148 enum pci_dma_burst_strategy *strat, 149 enum pci_dma_burst_strategy *strat,
149 unsigned long *strategy_parameter) 150 unsigned long *strategy_parameter)
@@ -151,6 +152,7 @@ static inline void pci_dma_burst_advice(struct pci_dev *pdev,
151 *strat = PCI_DMA_BURST_INFINITY; 152 *strat = PCI_DMA_BURST_INFINITY;
152 *strategy_parameter = ~0UL; 153 *strategy_parameter = ~0UL;
153} 154}
155#endif
154 156
155static inline void pcibios_add_platform_entries(struct pci_dev *dev) 157static inline void pcibios_add_platform_entries(struct pci_dev *dev)
156{ 158{
diff --git a/include/asm-sparc64/pci.h b/include/asm-sparc64/pci.h
index 402667300d01..84e41c1ef3f8 100644
--- a/include/asm-sparc64/pci.h
+++ b/include/asm-sparc64/pci.h
@@ -220,6 +220,7 @@ static inline int pci_dma_mapping_error(dma_addr_t dma_addr)
220 return (dma_addr == PCI_DMA_ERROR_CODE); 220 return (dma_addr == PCI_DMA_ERROR_CODE);
221} 221}
222 222
223#ifdef CONFIG_PCI
223static inline void pci_dma_burst_advice(struct pci_dev *pdev, 224static inline void pci_dma_burst_advice(struct pci_dev *pdev,
224 enum pci_dma_burst_strategy *strat, 225 enum pci_dma_burst_strategy *strat,
225 unsigned long *strategy_parameter) 226 unsigned long *strategy_parameter)
@@ -236,6 +237,7 @@ static inline void pci_dma_burst_advice(struct pci_dev *pdev,
236 *strat = PCI_DMA_BURST_BOUNDARY; 237 *strat = PCI_DMA_BURST_BOUNDARY;
237 *strategy_parameter = cacheline_size; 238 *strategy_parameter = cacheline_size;
238} 239}
240#endif
239 241
240/* Return the index of the PCI controller for device PDEV. */ 242/* Return the index of the PCI controller for device PDEV. */
241 243
diff --git a/include/asm-v850/pci.h b/include/asm-v850/pci.h
index d26eb8d67311..8e79be0fe99d 100644
--- a/include/asm-v850/pci.h
+++ b/include/asm-v850/pci.h
@@ -81,6 +81,7 @@ extern void
81pci_free_consistent (struct pci_dev *pdev, size_t size, void *cpu_addr, 81pci_free_consistent (struct pci_dev *pdev, size_t size, void *cpu_addr,
82 dma_addr_t dma_addr); 82 dma_addr_t dma_addr);
83 83
84#ifdef CONFIG_PCI
84static inline void pci_dma_burst_advice(struct pci_dev *pdev, 85static inline void pci_dma_burst_advice(struct pci_dev *pdev,
85 enum pci_dma_burst_strategy *strat, 86 enum pci_dma_burst_strategy *strat,
86 unsigned long *strategy_parameter) 87 unsigned long *strategy_parameter)
@@ -88,6 +89,7 @@ static inline void pci_dma_burst_advice(struct pci_dev *pdev,
88 *strat = PCI_DMA_BURST_INFINITY; 89 *strat = PCI_DMA_BURST_INFINITY;
89 *strategy_parameter = ~0UL; 90 *strategy_parameter = ~0UL;
90} 91}
92#endif
91 93
92static inline void pcibios_add_platform_entries(struct pci_dev *dev) 94static inline void pcibios_add_platform_entries(struct pci_dev *dev)
93{ 95{
diff --git a/include/asm-x86_64/pci.h b/include/asm-x86_64/pci.h
index 8461d6af102e..c1961db88fac 100644
--- a/include/asm-x86_64/pci.h
+++ b/include/asm-x86_64/pci.h
@@ -123,6 +123,7 @@ pci_dac_dma_sync_single_for_device(struct pci_dev *pdev, dma64_addr_t dma_addr,
123 flush_write_buffers(); 123 flush_write_buffers();
124} 124}
125 125
126#ifdef CONFIG_PCI
126static inline void pci_dma_burst_advice(struct pci_dev *pdev, 127static inline void pci_dma_burst_advice(struct pci_dev *pdev,
127 enum pci_dma_burst_strategy *strat, 128 enum pci_dma_burst_strategy *strat,
128 unsigned long *strategy_parameter) 129 unsigned long *strategy_parameter)
@@ -130,6 +131,7 @@ static inline void pci_dma_burst_advice(struct pci_dev *pdev,
130 *strat = PCI_DMA_BURST_INFINITY; 131 *strat = PCI_DMA_BURST_INFINITY;
131 *strategy_parameter = ~0UL; 132 *strategy_parameter = ~0UL;
132} 133}
134#endif
133 135
134#define HAVE_PCI_MMAP 136#define HAVE_PCI_MMAP
135extern int pci_mmap_page_range(struct pci_dev *dev, struct vm_area_struct *vma, 137extern int pci_mmap_page_range(struct pci_dev *dev, struct vm_area_struct *vma,
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 9ce4f1be093f..66798b46f308 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -985,6 +985,8 @@ static inline int pci_proc_domain(struct pci_bus *bus)
985} 985}
986#endif 986#endif
987 987
988#define pci_dma_burst_advice(pdev, strat, strategy_parameter) do { } while (0)
989
988#endif /* !CONFIG_PCI */ 990#endif /* !CONFIG_PCI */
989 991
990/* these helpers provide future and backwards compatibility 992/* these helpers provide future and backwards compatibility