aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteven Toth <stoth@linuxtv.org>2008-10-16 23:20:19 -0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2008-10-17 16:30:52 -0400
commita1bc84c083af059cb93d57c9caff7b382fe8b574 (patch)
treeb62edb767c1f76132d3cf44b7bf71dfe91d28788
parent11fbedd33287416a5efdc32c38e33f410bb1e942 (diff)
V4L/DVB (9274): Remove spurious messages and turn into debug.
Remove spurious messages and turn into debug. Signed-off-by: Steven Toth <stoth@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r--drivers/media/dvb/dvb-core/dvb_frontend.c59
1 files changed, 22 insertions, 37 deletions
diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c
index 6c9b9be9e286..5689d1f1d444 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -903,30 +903,30 @@ void dtv_property_dump(struct dtv_property *tvp)
903 int i; 903 int i;
904 904
905 if (tvp->cmd <= 0 || tvp->cmd > DTV_MAX_COMMAND) { 905 if (tvp->cmd <= 0 || tvp->cmd > DTV_MAX_COMMAND) {
906 printk("%s: tvp.cmd = 0x%08x (undefined/unknown/invalid)\n", 906 printk(KERN_WARNING "%s: tvp.cmd = 0x%08x undefined\n",
907 __func__, tvp->cmd); 907 __func__, tvp->cmd);
908 return; 908 return;
909 } 909 }
910 910
911 printk("%s() tvp.cmd = 0x%08x (%s)\n" 911 dprintk("%s() tvp.cmd = 0x%08x (%s)\n"
912 ,__FUNCTION__ 912 ,__func__
913 ,tvp->cmd 913 ,tvp->cmd
914 ,dtv_cmds[ tvp->cmd ].name); 914 ,dtv_cmds[ tvp->cmd ].name);
915 915
916 if(dtv_cmds[ tvp->cmd ].buffer) { 916 if(dtv_cmds[ tvp->cmd ].buffer) {
917 917
918 printk("%s() tvp.u.buffer.len = 0x%02x\n" 918 dprintk("%s() tvp.u.buffer.len = 0x%02x\n"
919 ,__FUNCTION__ 919 ,__func__
920 ,tvp->u.buffer.len); 920 ,tvp->u.buffer.len);
921 921
922 for(i = 0; i < tvp->u.buffer.len; i++) 922 for(i = 0; i < tvp->u.buffer.len; i++)
923 printk("%s() tvp.u.buffer.data[0x%02x] = 0x%02x\n" 923 dprintk("%s() tvp.u.buffer.data[0x%02x] = 0x%02x\n"
924 ,__FUNCTION__ 924 ,__func__
925 ,i 925 ,i
926 ,tvp->u.buffer.data[i]); 926 ,tvp->u.buffer.data[i]);
927 927
928 } else 928 } else
929 printk("%s() tvp.u.data = 0x%08x\n", __FUNCTION__, tvp->u.data); 929 dprintk("%s() tvp.u.data = 0x%08x\n", __func__, tvp->u.data);
930} 930}
931 931
932int is_legacy_delivery_system(fe_delivery_system_t s) 932int is_legacy_delivery_system(fe_delivery_system_t s)
@@ -946,8 +946,6 @@ void dtv_property_cache_sync(struct dvb_frontend *fe, struct dvb_frontend_parame
946{ 946{
947 struct dtv_frontend_properties *c = &fe->dtv_property_cache; 947 struct dtv_frontend_properties *c = &fe->dtv_property_cache;
948 948
949 printk("%s()\n", __FUNCTION__);
950
951 c->frequency = p->frequency; 949 c->frequency = p->frequency;
952 c->inversion = p->inversion; 950 c->inversion = p->inversion;
953 951
@@ -1002,27 +1000,25 @@ void dtv_property_legacy_params_sync(struct dvb_frontend *fe)
1002 struct dvb_frontend_private *fepriv = fe->frontend_priv; 1000 struct dvb_frontend_private *fepriv = fe->frontend_priv;
1003 struct dvb_frontend_parameters *p = &fepriv->parameters; 1001 struct dvb_frontend_parameters *p = &fepriv->parameters;
1004 1002
1005 printk("%s()\n", __FUNCTION__);
1006
1007 p->frequency = c->frequency; 1003 p->frequency = c->frequency;
1008 p->inversion = c->inversion; 1004 p->inversion = c->inversion;
1009 1005
1010 switch (fe->ops.info.type) { 1006 switch (fe->ops.info.type) {
1011 case FE_QPSK: 1007 case FE_QPSK:
1012 printk("%s() Preparing QPSK req\n", __FUNCTION__); 1008 dprintk("%s() Preparing QPSK req\n", __func__);
1013 p->u.qpsk.symbol_rate = c->symbol_rate; 1009 p->u.qpsk.symbol_rate = c->symbol_rate;
1014 p->u.qpsk.fec_inner = c->fec_inner; 1010 p->u.qpsk.fec_inner = c->fec_inner;
1015 c->delivery_system = SYS_DVBS; 1011 c->delivery_system = SYS_DVBS;
1016 break; 1012 break;
1017 case FE_QAM: 1013 case FE_QAM:
1018 printk("%s() Preparing QAM req\n", __FUNCTION__); 1014 dprintk("%s() Preparing QAM req\n", __func__);
1019 p->u.qam.symbol_rate = c->symbol_rate; 1015 p->u.qam.symbol_rate = c->symbol_rate;
1020 p->u.qam.fec_inner = c->fec_inner; 1016 p->u.qam.fec_inner = c->fec_inner;
1021 p->u.qam.modulation = c->modulation; 1017 p->u.qam.modulation = c->modulation;
1022 c->delivery_system = SYS_DVBC_ANNEX_AC; 1018 c->delivery_system = SYS_DVBC_ANNEX_AC;
1023 break; 1019 break;
1024 case FE_OFDM: 1020 case FE_OFDM:
1025 printk("%s() Preparing OFDM req\n", __FUNCTION__); 1021 dprintk("%s() Preparing OFDM req\n", __func__);
1026 if (c->bandwidth_hz == 6000000) 1022 if (c->bandwidth_hz == 6000000)
1027 p->u.ofdm.bandwidth = BANDWIDTH_6_MHZ; 1023 p->u.ofdm.bandwidth = BANDWIDTH_6_MHZ;
1028 else if (c->bandwidth_hz == 7000000) 1024 else if (c->bandwidth_hz == 7000000)
@@ -1040,7 +1036,7 @@ void dtv_property_legacy_params_sync(struct dvb_frontend *fe)
1040 c->delivery_system = SYS_DVBT; 1036 c->delivery_system = SYS_DVBT;
1041 break; 1037 break;
1042 case FE_ATSC: 1038 case FE_ATSC:
1043 printk("%s() Preparing VSB req\n", __FUNCTION__); 1039 dprintk("%s() Preparing VSB req\n", __func__);
1044 p->u.vsb.modulation = c->modulation; 1040 p->u.vsb.modulation = c->modulation;
1045 if ((c->modulation == VSB_8) || (c->modulation == VSB_16)) 1041 if ((c->modulation == VSB_8) || (c->modulation == VSB_16))
1046 c->delivery_system = SYS_ATSC; 1042 c->delivery_system = SYS_ATSC;
@@ -1059,8 +1055,6 @@ void dtv_property_adv_params_sync(struct dvb_frontend *fe)
1059 struct dvb_frontend_private *fepriv = fe->frontend_priv; 1055 struct dvb_frontend_private *fepriv = fe->frontend_priv;
1060 struct dvb_frontend_parameters *p = &fepriv->parameters; 1056 struct dvb_frontend_parameters *p = &fepriv->parameters;
1061 1057
1062 printk("%s()\n", __FUNCTION__);
1063
1064 p->frequency = c->frequency; 1058 p->frequency = c->frequency;
1065 p->inversion = c->inversion; 1059 p->inversion = c->inversion;
1066 1060
@@ -1094,19 +1088,17 @@ void dtv_property_cache_submit(struct dvb_frontend *fe)
1094{ 1088{
1095 struct dtv_frontend_properties *c = &fe->dtv_property_cache; 1089 struct dtv_frontend_properties *c = &fe->dtv_property_cache;
1096 1090
1097 printk("%s()\n", __FUNCTION__);
1098
1099 /* For legacy delivery systems we don't need the delivery_system to 1091 /* For legacy delivery systems we don't need the delivery_system to
1100 * be specified, but we populate the older structures from the cache 1092 * be specified, but we populate the older structures from the cache
1101 * so we can call set_frontend on older drivers. 1093 * so we can call set_frontend on older drivers.
1102 */ 1094 */
1103 if(is_legacy_delivery_system(c->delivery_system)) { 1095 if(is_legacy_delivery_system(c->delivery_system)) {
1104 1096
1105 printk("%s() legacy, modulation = %d\n", __FUNCTION__, c->modulation); 1097 dprintk("%s() legacy, modulation = %d\n", __func__, c->modulation);
1106 dtv_property_legacy_params_sync(fe); 1098 dtv_property_legacy_params_sync(fe);
1107 1099
1108 } else { 1100 } else {
1109 printk("%s() adv, modulation = %d\n", __FUNCTION__, c->modulation); 1101 dprintk("%s() adv, modulation = %d\n", __func__, c->modulation);
1110 1102
1111 /* For advanced delivery systems / modulation types ... 1103 /* For advanced delivery systems / modulation types ...
1112 * we seed the lecacy dvb_frontend_parameters structure 1104 * we seed the lecacy dvb_frontend_parameters structure
@@ -1128,8 +1120,6 @@ int dtv_property_process_get(struct dvb_frontend *fe, struct dtv_property *tvp,
1128{ 1120{
1129 int r = 0; 1121 int r = 0;
1130 1122
1131 printk("%s()\n", __FUNCTION__);
1132
1133 dtv_property_dump(tvp); 1123 dtv_property_dump(tvp);
1134 1124
1135 /* Allow the frontend to validate incoming properties */ 1125 /* Allow the frontend to validate incoming properties */
@@ -1203,7 +1193,6 @@ int dtv_property_process_set(struct dvb_frontend *fe, struct dtv_property *tvp,
1203{ 1193{
1204 int r = 0; 1194 int r = 0;
1205 struct dvb_frontend_private *fepriv = fe->frontend_priv; 1195 struct dvb_frontend_private *fepriv = fe->frontend_priv;
1206 printk("%s()\n", __FUNCTION__);
1207 dtv_property_dump(tvp); 1196 dtv_property_dump(tvp);
1208 1197
1209 /* Allow the frontend to validate incoming properties */ 1198 /* Allow the frontend to validate incoming properties */
@@ -1218,7 +1207,7 @@ int dtv_property_process_set(struct dvb_frontend *fe, struct dtv_property *tvp,
1218 /* Reset a cache of data specific to the frontend here. This does 1207 /* Reset a cache of data specific to the frontend here. This does
1219 * not effect hardware. 1208 * not effect hardware.
1220 */ 1209 */
1221 printk("%s() Flushing property cache\n", __FUNCTION__); 1210 dprintk("%s() Flushing property cache\n", __func__);
1222 memset(&fe->dtv_property_cache, 0, sizeof(struct dtv_frontend_properties)); 1211 memset(&fe->dtv_property_cache, 0, sizeof(struct dtv_frontend_properties));
1223 fe->dtv_property_cache.state = tvp->cmd; 1212 fe->dtv_property_cache.state = tvp->cmd;
1224 fe->dtv_property_cache.delivery_system = SYS_UNDEFINED; 1213 fe->dtv_property_cache.delivery_system = SYS_UNDEFINED;
@@ -1229,7 +1218,7 @@ int dtv_property_process_set(struct dvb_frontend *fe, struct dtv_property *tvp,
1229 * ioctl. 1218 * ioctl.
1230 */ 1219 */
1231 fe->dtv_property_cache.state = tvp->cmd; 1220 fe->dtv_property_cache.state = tvp->cmd;
1232 printk("%s() Finalised property cache\n", __FUNCTION__); 1221 dprintk("%s() Finalised property cache\n", __func__);
1233 dtv_property_cache_submit(fe); 1222 dtv_property_cache_submit(fe);
1234 1223
1235 r |= dvb_frontend_ioctl_legacy(inode, file, FE_SET_FRONTEND, 1224 r |= dvb_frontend_ioctl_legacy(inode, file, FE_SET_FRONTEND,
@@ -1340,12 +1329,10 @@ static int dvb_frontend_ioctl_properties(struct inode *inode, struct file *file,
1340 dprintk("%s\n", __func__); 1329 dprintk("%s\n", __func__);
1341 1330
1342 if(cmd == FE_SET_PROPERTY) { 1331 if(cmd == FE_SET_PROPERTY) {
1343 printk("%s() FE_SET_PROPERTY\n", __FUNCTION__);
1344
1345 tvps = (struct dtv_properties __user *)parg; 1332 tvps = (struct dtv_properties __user *)parg;
1346 1333
1347 printk("%s() properties.num = %d\n", __FUNCTION__, tvps->num); 1334 dprintk("%s() properties.num = %d\n", __func__, tvps->num);
1348 printk("%s() properties.props = %p\n", __FUNCTION__, tvps->props); 1335 dprintk("%s() properties.props = %p\n", __func__, tvps->props);
1349 1336
1350 /* Put an arbitrary limit on the number of messages that can 1337 /* Put an arbitrary limit on the number of messages that can
1351 * be sent at once */ 1338 * be sent at once */
@@ -1369,18 +1356,16 @@ static int dvb_frontend_ioctl_properties(struct inode *inode, struct file *file,
1369 err |= (tvp + i)->result; 1356 err |= (tvp + i)->result;
1370 } 1357 }
1371 1358
1372 if(fe->dtv_property_cache.state == DTV_TUNE) { 1359 if(fe->dtv_property_cache.state == DTV_TUNE)
1373 printk("%s() Property cache is full, tuning\n", __FUNCTION__); 1360 dprintk("%s() Property cache is full, tuning\n", __func__);
1374 }
1375 1361
1376 } else 1362 } else
1377 if(cmd == FE_GET_PROPERTY) { 1363 if(cmd == FE_GET_PROPERTY) {
1378 printk("%s() FE_GET_PROPERTY\n", __FUNCTION__);
1379 1364
1380 tvps = (struct dtv_properties __user *)parg; 1365 tvps = (struct dtv_properties __user *)parg;
1381 1366
1382 printk("%s() properties.num = %d\n", __FUNCTION__, tvps->num); 1367 dprintk("%s() properties.num = %d\n", __func__, tvps->num);
1383 printk("%s() properties.props = %p\n", __FUNCTION__, tvps->props); 1368 dprintk("%s() properties.props = %p\n", __func__, tvps->props);
1384 1369
1385 /* Put an arbitrary limit on the number of messages that can 1370 /* Put an arbitrary limit on the number of messages that can
1386 * be sent at once */ 1371 * be sent at once */