diff options
author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2011-11-23 14:53:17 -0500 |
---|---|---|
committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2011-12-14 06:27:23 -0500 |
commit | 90c161b643d9531d271110876a14e68b49172d8a (patch) | |
tree | 2427163f641294c15e1fc881993994f0ebe26d8b | |
parent | 1880807adb21d741f08b747956c90bf4a6f95fbf (diff) |
target: use \n as a separator for configuration
The command
| echo rd_pages=32768 > ramdisk/control
Does not work because it writes "rd_pages=32768\n" and the parser which
matches for "rd_pages=%d" does not recognize it due to the \n. One way
of fixing this would be using "echo -n" instead.
This patch adds \n to the list of separators so we don't have to use the
-n argument which I find is more convinient.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
-rw-r--r-- | drivers/target/target_core_configfs.c | 2 | ||||
-rw-r--r-- | drivers/target/target_core_file.c | 2 | ||||
-rw-r--r-- | drivers/target/target_core_iblock.c | 2 | ||||
-rw-r--r-- | drivers/target/target_core_pscsi.c | 2 | ||||
-rw-r--r-- | drivers/target/target_core_rd.c | 2 |
5 files changed, 5 insertions, 5 deletions
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c index 3c358907a4a6..37b2b3d03c65 100644 --- a/drivers/target/target_core_configfs.c +++ b/drivers/target/target_core_configfs.c | |||
@@ -1450,7 +1450,7 @@ static ssize_t target_core_dev_pr_store_attr_res_aptpl_metadata( | |||
1450 | return -ENOMEM; | 1450 | return -ENOMEM; |
1451 | 1451 | ||
1452 | orig = opts; | 1452 | orig = opts; |
1453 | while ((ptr = strsep(&opts, ",")) != NULL) { | 1453 | while ((ptr = strsep(&opts, ",\n")) != NULL) { |
1454 | if (!*ptr) | 1454 | if (!*ptr) |
1455 | continue; | 1455 | continue; |
1456 | 1456 | ||
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c index ed7e05353d62..91bf11a0ab16 100644 --- a/drivers/target/target_core_file.c +++ b/drivers/target/target_core_file.c | |||
@@ -497,7 +497,7 @@ static ssize_t fd_set_configfs_dev_params( | |||
497 | 497 | ||
498 | orig = opts; | 498 | orig = opts; |
499 | 499 | ||
500 | while ((ptr = strsep(&opts, ",")) != NULL) { | 500 | while ((ptr = strsep(&opts, ",\n")) != NULL) { |
501 | if (!*ptr) | 501 | if (!*ptr) |
502 | continue; | 502 | continue; |
503 | 503 | ||
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c index feebbfe6cbd0..3c1a7aa658a2 100644 --- a/drivers/target/target_core_iblock.c +++ b/drivers/target/target_core_iblock.c | |||
@@ -390,7 +390,7 @@ static ssize_t iblock_set_configfs_dev_params(struct se_hba *hba, | |||
390 | 390 | ||
391 | orig = opts; | 391 | orig = opts; |
392 | 392 | ||
393 | while ((ptr = strsep(&opts, ",")) != NULL) { | 393 | while ((ptr = strsep(&opts, ",\n")) != NULL) { |
394 | if (!*ptr) | 394 | if (!*ptr) |
395 | continue; | 395 | continue; |
396 | 396 | ||
diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c index 5d8851de3aee..bb44ed4d0272 100644 --- a/drivers/target/target_core_pscsi.c +++ b/drivers/target/target_core_pscsi.c | |||
@@ -817,7 +817,7 @@ static ssize_t pscsi_set_configfs_dev_params(struct se_hba *hba, | |||
817 | 817 | ||
818 | orig = opts; | 818 | orig = opts; |
819 | 819 | ||
820 | while ((ptr = strsep(&opts, ",")) != NULL) { | 820 | while ((ptr = strsep(&opts, ",\n")) != NULL) { |
821 | if (!*ptr) | 821 | if (!*ptr) |
822 | continue; | 822 | continue; |
823 | 823 | ||
diff --git a/drivers/target/target_core_rd.c b/drivers/target/target_core_rd.c index 94b4087dadd5..8b68f7b82631 100644 --- a/drivers/target/target_core_rd.c +++ b/drivers/target/target_core_rd.c | |||
@@ -472,7 +472,7 @@ static ssize_t rd_set_configfs_dev_params( | |||
472 | 472 | ||
473 | orig = opts; | 473 | orig = opts; |
474 | 474 | ||
475 | while ((ptr = strsep(&opts, ",")) != NULL) { | 475 | while ((ptr = strsep(&opts, ",\n")) != NULL) { |
476 | if (!*ptr) | 476 | if (!*ptr) |
477 | continue; | 477 | continue; |
478 | 478 | ||