diff options
author | Igor Grinberg <grinberg@compulab.co.il> | 2012-05-09 03:31:35 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-05-09 18:20:12 -0400 |
commit | 7b18389dd4fe0b178117b09d054e214297f7e677 (patch) | |
tree | c5ae1c2e4318049e8ee01a02948e839139381858 | |
parent | 1f339d84407eda744caa5b361d67019c66532d5d (diff) |
ARM: OMAP: USB: fix warning on EHCI PHY reset path
When PHY reset pin is connected to a GPIO on external GPIO chip
(e.g. I2C), we should not call the gpio_set_value() function, but
gpio_set_value_cansleep().
Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
Acked-by: Felipe Balbi <balbi@ti.com>
Tested-by: Govindraj.R <govindraj.raja@ti.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/usb/host/ehci-omap.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c index e669c6a7e91e..a44294d13494 100644 --- a/drivers/usb/host/ehci-omap.c +++ b/drivers/usb/host/ehci-omap.c | |||
@@ -249,10 +249,10 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev) | |||
249 | udelay(10); | 249 | udelay(10); |
250 | 250 | ||
251 | if (gpio_is_valid(pdata->reset_gpio_port[0])) | 251 | if (gpio_is_valid(pdata->reset_gpio_port[0])) |
252 | gpio_set_value(pdata->reset_gpio_port[0], 1); | 252 | gpio_set_value_cansleep(pdata->reset_gpio_port[0], 1); |
253 | 253 | ||
254 | if (gpio_is_valid(pdata->reset_gpio_port[1])) | 254 | if (gpio_is_valid(pdata->reset_gpio_port[1])) |
255 | gpio_set_value(pdata->reset_gpio_port[1], 1); | 255 | gpio_set_value_cansleep(pdata->reset_gpio_port[1], 1); |
256 | } | 256 | } |
257 | 257 | ||
258 | ret = usb_add_hcd(hcd, irq, IRQF_SHARED); | 258 | ret = usb_add_hcd(hcd, irq, IRQF_SHARED); |