diff options
author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2012-09-03 19:58:16 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-09-04 14:16:13 -0400 |
commit | 54a27924237eeb9767135a423dea14a0d1b5954f (patch) | |
tree | bd64976c76b3de2795a1aef1a68dbc5557c952cd | |
parent | 6e129d04de7adbd63e86293533688ce88b9b13d8 (diff) |
sctp: use list_move_tail instead of list_del/list_add_tail
Using list_move_tail() instead of list_del() + list_add_tail().
spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/sctp/outqueue.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c index 072bf6ae3c26..d16632e1503a 100644 --- a/net/sctp/outqueue.c +++ b/net/sctp/outqueue.c | |||
@@ -591,9 +591,8 @@ static int sctp_outq_flush_rtx(struct sctp_outq *q, struct sctp_packet *pkt, | |||
591 | * next chunk. | 591 | * next chunk. |
592 | */ | 592 | */ |
593 | if (chunk->tsn_gap_acked) { | 593 | if (chunk->tsn_gap_acked) { |
594 | list_del(&chunk->transmitted_list); | 594 | list_move_tail(&chunk->transmitted_list, |
595 | list_add_tail(&chunk->transmitted_list, | 595 | &transport->transmitted); |
596 | &transport->transmitted); | ||
597 | continue; | 596 | continue; |
598 | } | 597 | } |
599 | 598 | ||
@@ -657,9 +656,8 @@ redo: | |||
657 | /* The append was successful, so add this chunk to | 656 | /* The append was successful, so add this chunk to |
658 | * the transmitted list. | 657 | * the transmitted list. |
659 | */ | 658 | */ |
660 | list_del(&chunk->transmitted_list); | 659 | list_move_tail(&chunk->transmitted_list, |
661 | list_add_tail(&chunk->transmitted_list, | 660 | &transport->transmitted); |
662 | &transport->transmitted); | ||
663 | 661 | ||
664 | /* Mark the chunk as ineligible for fast retransmit | 662 | /* Mark the chunk as ineligible for fast retransmit |
665 | * after it is retransmitted. | 663 | * after it is retransmitted. |