diff options
author | Julia Lawall <julia@diku.dk> | 2008-11-30 06:17:20 -0500 |
---|---|---|
committer | Marcel Holtmann <marcel@holtmann.org> | 2008-11-30 06:17:20 -0500 |
commit | 51a6fbc855b07a0737558560dd0ab0b5f646025b (patch) | |
tree | 244e0d245de77acee2bd7deacc0ea6f422325848 | |
parent | db7aa1c203d477351ed1b8f394b40d9df06ddfc4 (diff) |
Bluetooth: Change simple_strtol to simple_strtoul
Since size, addr, fcs, and tmp are unsigned, it would seem better to use
simple_strtoul that simple_strtol.
A simplified version of the semantic patch that makes this change is as
follows: (http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r2@
long e;
position p;
@@
e = simple_strtol@p(...)
@@
position p != r2.p;
type T;
T e;
@@
e =
- simple_strtol@p
+ simple_strtoul
(...)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
-rw-r--r-- | drivers/bluetooth/bt3c_cs.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/bluetooth/bt3c_cs.c b/drivers/bluetooth/bt3c_cs.c index b3e4d07a4ac2..ff195c230825 100644 --- a/drivers/bluetooth/bt3c_cs.c +++ b/drivers/bluetooth/bt3c_cs.c | |||
@@ -502,15 +502,15 @@ static int bt3c_load_firmware(bt3c_info_t *info, const unsigned char *firmware, | |||
502 | 502 | ||
503 | memset(b, 0, sizeof(b)); | 503 | memset(b, 0, sizeof(b)); |
504 | memcpy(b, ptr + 2, 2); | 504 | memcpy(b, ptr + 2, 2); |
505 | size = simple_strtol(b, NULL, 16); | 505 | size = simple_strtoul(b, NULL, 16); |
506 | 506 | ||
507 | memset(b, 0, sizeof(b)); | 507 | memset(b, 0, sizeof(b)); |
508 | memcpy(b, ptr + 4, 8); | 508 | memcpy(b, ptr + 4, 8); |
509 | addr = simple_strtol(b, NULL, 16); | 509 | addr = simple_strtoul(b, NULL, 16); |
510 | 510 | ||
511 | memset(b, 0, sizeof(b)); | 511 | memset(b, 0, sizeof(b)); |
512 | memcpy(b, ptr + (size * 2) + 2, 2); | 512 | memcpy(b, ptr + (size * 2) + 2, 2); |
513 | fcs = simple_strtol(b, NULL, 16); | 513 | fcs = simple_strtoul(b, NULL, 16); |
514 | 514 | ||
515 | memset(b, 0, sizeof(b)); | 515 | memset(b, 0, sizeof(b)); |
516 | for (tmp = 0, i = 0; i < size; i++) { | 516 | for (tmp = 0, i = 0; i < size; i++) { |
@@ -530,7 +530,7 @@ static int bt3c_load_firmware(bt3c_info_t *info, const unsigned char *firmware, | |||
530 | memset(b, 0, sizeof(b)); | 530 | memset(b, 0, sizeof(b)); |
531 | for (i = 0; i < (size - 4) / 2; i++) { | 531 | for (i = 0; i < (size - 4) / 2; i++) { |
532 | memcpy(b, ptr + (i * 4) + 12, 4); | 532 | memcpy(b, ptr + (i * 4) + 12, 4); |
533 | tmp = simple_strtol(b, NULL, 16); | 533 | tmp = simple_strtoul(b, NULL, 16); |
534 | bt3c_put(iobase, tmp); | 534 | bt3c_put(iobase, tmp); |
535 | } | 535 | } |
536 | } | 536 | } |