aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2009-12-16 09:27:10 -0500
committerIngo Molnar <mingo@elte.hu>2009-12-16 10:51:50 -0500
commit3e6055ab981dfd379a1b9bd54b556e81ae9c215f (patch)
treee890c792d89b9433d6ee5e91cfc1dd012d9e26dc
parent4ecf84d086fbeca5a622e971fff013b291dbde86 (diff)
perf session: Move perf report specific hits out of perf_session__fprintf_hists
Those don't make sense for tools such as 'perf diff'. Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Frédéric Weisbecker <fweisbec@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> LKML-Reference: <1260973631-28035-2-git-send-email-acme@infradead.org> Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--tools/perf/builtin-report.c5
-rw-r--r--tools/perf/util/hist.c11
2 files changed, 5 insertions, 11 deletions
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 24d20e7d125a..c4f3a08f7c48 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -224,7 +224,12 @@ static int __cmd_report(void)
224 224
225 perf_session__collapse_resort(session); 225 perf_session__collapse_resort(session);
226 perf_session__output_resort(session, session->events_stats.total); 226 perf_session__output_resort(session, session->events_stats.total);
227 fprintf(stdout, "# Samples: %ld\n#\n", session->events_stats.total);
227 perf_session__fprintf_hists(session, stdout); 228 perf_session__fprintf_hists(session, stdout);
229 if (sort_order == default_sort_order &&
230 parent_pattern == default_parent_pattern)
231 fprintf(stdout, "#\n# (For a higher level overview, try: perf report --sort comm,dso)\n#\n");
232
228 if (show_threads) { 233 if (show_threads) {
229 bool raw_printing_style = !strcmp(pretty_printing_style, "raw"); 234 bool raw_printing_style = !strcmp(pretty_printing_style, "raw");
230 perf_read_values_display(stdout, &show_threads_values, 235 perf_read_values_display(stdout, &show_threads_values,
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index 270eb8f3dcee..6e416a62e0d6 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -515,9 +515,6 @@ size_t perf_session__fprintf_hists(struct perf_session *self, FILE *fp)
515 515
516 init_rem_hits(); 516 init_rem_hits();
517 517
518 fprintf(fp, "# Samples: %ld\n", self->events_stats.total);
519 fprintf(fp, "#\n");
520
521 fprintf(fp, "# Overhead"); 518 fprintf(fp, "# Overhead");
522 if (symbol_conf.show_nr_samples) { 519 if (symbol_conf.show_nr_samples) {
523 if (symbol_conf.field_sep) 520 if (symbol_conf.field_sep)
@@ -578,14 +575,6 @@ print_entries:
578 ret += hist_entry__fprintf(fp, pos, self); 575 ret += hist_entry__fprintf(fp, pos, self);
579 } 576 }
580 577
581 if (sort_order == default_sort_order &&
582 parent_pattern == default_parent_pattern) {
583 fprintf(fp, "#\n");
584 fprintf(fp, "# (For a higher level overview, try: perf report --sort comm,dso)\n");
585 fprintf(fp, "#\n");
586 }
587 fprintf(fp, "\n");
588
589 free(rem_sq_bracket); 578 free(rem_sq_bracket);
590 579
591 return ret; 580 return ret;