aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoel Becker <joel.becker@oracle.com>2009-04-21 15:38:29 -0400
committerChris Mason <chris.mason@oracle.com>2009-04-27 08:37:49 -0400
commit21380931eb4da4e29ac663d0221581282cbba208 (patch)
treefa8c2155784ccb0ee996e52e75d1e04b79cf2560
parente63b6a6c0ffa2ebd8617cc1a10969000296831aa (diff)
Btrfs: Fix a bunch of printk() warnings.
Just happened to notice a bunch of %llu vs u64 warnings. Here's a patch to cast them all. Signed-off-by: Joel Becker <joel.becker@oracle.com> Signed-off-by: Chris Mason <chris.mason@oracle.com>
-rw-r--r--fs/btrfs/disk-io.c6
-rw-r--r--fs/btrfs/extent-tree.c21
-rw-r--r--fs/btrfs/free-space-cache.c15
-rw-r--r--fs/btrfs/ioctl.c6
-rw-r--r--fs/btrfs/super.c15
5 files changed, 40 insertions, 23 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index aa0c259b9c28..0ff16d3331da 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -1671,7 +1671,7 @@ struct btrfs_root *open_ctree(struct super_block *sb,
1671 if (features) { 1671 if (features) {
1672 printk(KERN_ERR "BTRFS: couldn't mount because of " 1672 printk(KERN_ERR "BTRFS: couldn't mount because of "
1673 "unsupported optional features (%Lx).\n", 1673 "unsupported optional features (%Lx).\n",
1674 features); 1674 (unsigned long long)features);
1675 err = -EINVAL; 1675 err = -EINVAL;
1676 goto fail_iput; 1676 goto fail_iput;
1677 } 1677 }
@@ -1681,7 +1681,7 @@ struct btrfs_root *open_ctree(struct super_block *sb,
1681 if (!(sb->s_flags & MS_RDONLY) && features) { 1681 if (!(sb->s_flags & MS_RDONLY) && features) {
1682 printk(KERN_ERR "BTRFS: couldn't mount RDWR because of " 1682 printk(KERN_ERR "BTRFS: couldn't mount RDWR because of "
1683 "unsupported option features (%Lx).\n", 1683 "unsupported option features (%Lx).\n",
1684 features); 1684 (unsigned long long)features);
1685 err = -EINVAL; 1685 err = -EINVAL;
1686 goto fail_iput; 1686 goto fail_iput;
1687 } 1687 }
@@ -2273,7 +2273,7 @@ int close_ctree(struct btrfs_root *root)
2273 2273
2274 if (fs_info->delalloc_bytes) { 2274 if (fs_info->delalloc_bytes) {
2275 printk(KERN_INFO "btrfs: at unmount delalloc count %llu\n", 2275 printk(KERN_INFO "btrfs: at unmount delalloc count %llu\n",
2276 fs_info->delalloc_bytes); 2276 (unsigned long long)fs_info->delalloc_bytes);
2277 } 2277 }
2278 if (fs_info->total_ref_cache_size) { 2278 if (fs_info->total_ref_cache_size) {
2279 printk(KERN_INFO "btrfs: at umount reference cache size %llu\n", 2279 printk(KERN_INFO "btrfs: at umount reference cache size %llu\n",
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 2895a8373232..e4966444811b 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -1844,10 +1844,14 @@ again:
1844 printk(KERN_ERR "no space left, need %llu, %llu delalloc bytes" 1844 printk(KERN_ERR "no space left, need %llu, %llu delalloc bytes"
1845 ", %llu bytes_used, %llu bytes_reserved, " 1845 ", %llu bytes_used, %llu bytes_reserved, "
1846 "%llu bytes_pinned, %llu bytes_readonly, %llu may use" 1846 "%llu bytes_pinned, %llu bytes_readonly, %llu may use"
1847 "%llu total\n", bytes, data_sinfo->bytes_delalloc, 1847 "%llu total\n", (unsigned long long)bytes,
1848 data_sinfo->bytes_used, data_sinfo->bytes_reserved, 1848 (unsigned long long)data_sinfo->bytes_delalloc,
1849 data_sinfo->bytes_pinned, data_sinfo->bytes_readonly, 1849 (unsigned long long)data_sinfo->bytes_used,
1850 data_sinfo->bytes_may_use, data_sinfo->total_bytes); 1850 (unsigned long long)data_sinfo->bytes_reserved,
1851 (unsigned long long)data_sinfo->bytes_pinned,
1852 (unsigned long long)data_sinfo->bytes_readonly,
1853 (unsigned long long)data_sinfo->bytes_may_use,
1854 (unsigned long long)data_sinfo->total_bytes);
1851 return -ENOSPC; 1855 return -ENOSPC;
1852 } 1856 }
1853 data_sinfo->bytes_may_use += bytes; 1857 data_sinfo->bytes_may_use += bytes;
@@ -2824,9 +2828,12 @@ static void dump_space_info(struct btrfs_space_info *info, u64 bytes)
2824 info->bytes_pinned - info->bytes_reserved), 2828 info->bytes_pinned - info->bytes_reserved),
2825 (info->full) ? "" : "not "); 2829 (info->full) ? "" : "not ");
2826 printk(KERN_INFO "space_info total=%llu, pinned=%llu, delalloc=%llu," 2830 printk(KERN_INFO "space_info total=%llu, pinned=%llu, delalloc=%llu,"
2827 " may_use=%llu, used=%llu\n", info->total_bytes, 2831 " may_use=%llu, used=%llu\n",
2828 info->bytes_pinned, info->bytes_delalloc, info->bytes_may_use, 2832 (unsigned long long)info->total_bytes,
2829 info->bytes_used); 2833 (unsigned long long)info->bytes_pinned,
2834 (unsigned long long)info->bytes_delalloc,
2835 (unsigned long long)info->bytes_may_use,
2836 (unsigned long long)info->bytes_used);
2830 2837
2831 down_read(&info->groups_sem); 2838 down_read(&info->groups_sem);
2832 list_for_each_entry(cache, &info->block_groups, list) { 2839 list_for_each_entry(cache, &info->block_groups, list) {
diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
index 768b9523662d..0bc93657b460 100644
--- a/fs/btrfs/free-space-cache.c
+++ b/fs/btrfs/free-space-cache.c
@@ -332,13 +332,17 @@ int btrfs_remove_free_space(struct btrfs_block_group_cache *block_group,
332 printk(KERN_ERR "couldn't find space %llu to free\n", 332 printk(KERN_ERR "couldn't find space %llu to free\n",
333 (unsigned long long)offset); 333 (unsigned long long)offset);
334 printk(KERN_ERR "cached is %d, offset %llu bytes %llu\n", 334 printk(KERN_ERR "cached is %d, offset %llu bytes %llu\n",
335 block_group->cached, block_group->key.objectid, 335 block_group->cached,
336 block_group->key.offset); 336 (unsigned long long)block_group->key.objectid,
337 (unsigned long long)block_group->key.offset);
337 btrfs_dump_free_space(block_group, bytes); 338 btrfs_dump_free_space(block_group, bytes);
338 } else if (info) { 339 } else if (info) {
339 printk(KERN_ERR "hmm, found offset=%llu bytes=%llu, " 340 printk(KERN_ERR "hmm, found offset=%llu bytes=%llu, "
340 "but wanted offset=%llu bytes=%llu\n", 341 "but wanted offset=%llu bytes=%llu\n",
341 info->offset, info->bytes, offset, bytes); 342 (unsigned long long)info->offset,
343 (unsigned long long)info->bytes,
344 (unsigned long long)offset,
345 (unsigned long long)bytes);
342 } 346 }
343 WARN_ON(1); 347 WARN_ON(1);
344 } 348 }
@@ -357,8 +361,9 @@ void btrfs_dump_free_space(struct btrfs_block_group_cache *block_group,
357 info = rb_entry(n, struct btrfs_free_space, offset_index); 361 info = rb_entry(n, struct btrfs_free_space, offset_index);
358 if (info->bytes >= bytes) 362 if (info->bytes >= bytes)
359 count++; 363 count++;
360 printk(KERN_ERR "entry offset %llu, bytes %llu\n", info->offset, 364 printk(KERN_ERR "entry offset %llu, bytes %llu\n",
361 info->bytes); 365 (unsigned long long)info->offset,
366 (unsigned long long)info->bytes);
362 } 367 }
363 printk(KERN_INFO "%d blocks of free space at or bigger than bytes is" 368 printk(KERN_INFO "%d blocks of free space at or bigger than bytes is"
364 "\n", count); 369 "\n", count);
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index f4e5d2e5ece6..48762aa1e945 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -483,11 +483,13 @@ static int btrfs_ioctl_resize(struct btrfs_root *root, void __user *arg)
483 *devstr = '\0'; 483 *devstr = '\0';
484 devstr = vol_args->name; 484 devstr = vol_args->name;
485 devid = simple_strtoull(devstr, &end, 10); 485 devid = simple_strtoull(devstr, &end, 10);
486 printk(KERN_INFO "resizing devid %llu\n", devid); 486 printk(KERN_INFO "resizing devid %llu\n",
487 (unsigned long long)devid);
487 } 488 }
488 device = btrfs_find_device(root, devid, NULL, NULL); 489 device = btrfs_find_device(root, devid, NULL, NULL);
489 if (!device) { 490 if (!device) {
490 printk(KERN_INFO "resizer unable to find device %llu\n", devid); 491 printk(KERN_INFO "resizer unable to find device %llu\n",
492 (unsigned long long)devid);
491 ret = -EINVAL; 493 ret = -EINVAL;
492 goto out_unlock; 494 goto out_unlock;
493 } 495 }
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 30c9a8ca2a54..bf0e84c75607 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -196,7 +196,7 @@ int btrfs_parse_options(struct btrfs_root *root, char *options)
196 info->max_extent = max_t(u64, 196 info->max_extent = max_t(u64,
197 info->max_extent, root->sectorsize); 197 info->max_extent, root->sectorsize);
198 printk(KERN_INFO "btrfs: max_extent at %llu\n", 198 printk(KERN_INFO "btrfs: max_extent at %llu\n",
199 info->max_extent); 199 (unsigned long long)info->max_extent);
200 } 200 }
201 break; 201 break;
202 case Opt_max_inline: 202 case Opt_max_inline:
@@ -211,7 +211,7 @@ int btrfs_parse_options(struct btrfs_root *root, char *options)
211 root->sectorsize); 211 root->sectorsize);
212 } 212 }
213 printk(KERN_INFO "btrfs: max_inline at %llu\n", 213 printk(KERN_INFO "btrfs: max_inline at %llu\n",
214 info->max_inline); 214 (unsigned long long)info->max_inline);
215 } 215 }
216 break; 216 break;
217 case Opt_alloc_start: 217 case Opt_alloc_start:
@@ -221,7 +221,7 @@ int btrfs_parse_options(struct btrfs_root *root, char *options)
221 kfree(num); 221 kfree(num);
222 printk(KERN_INFO 222 printk(KERN_INFO
223 "btrfs: allocations start at %llu\n", 223 "btrfs: allocations start at %llu\n",
224 info->alloc_start); 224 (unsigned long long)info->alloc_start);
225 } 225 }
226 break; 226 break;
227 case Opt_noacl: 227 case Opt_noacl:
@@ -420,11 +420,14 @@ static int btrfs_show_options(struct seq_file *seq, struct vfsmount *vfs)
420 if (btrfs_test_opt(root, NOBARRIER)) 420 if (btrfs_test_opt(root, NOBARRIER))
421 seq_puts(seq, ",nobarrier"); 421 seq_puts(seq, ",nobarrier");
422 if (info->max_extent != (u64)-1) 422 if (info->max_extent != (u64)-1)
423 seq_printf(seq, ",max_extent=%llu", info->max_extent); 423 seq_printf(seq, ",max_extent=%llu",
424 (unsigned long long)info->max_extent);
424 if (info->max_inline != 8192 * 1024) 425 if (info->max_inline != 8192 * 1024)
425 seq_printf(seq, ",max_inline=%llu", info->max_inline); 426 seq_printf(seq, ",max_inline=%llu",
427 (unsigned long long)info->max_inline);
426 if (info->alloc_start != 0) 428 if (info->alloc_start != 0)
427 seq_printf(seq, ",alloc_start=%llu", info->alloc_start); 429 seq_printf(seq, ",alloc_start=%llu",
430 (unsigned long long)info->alloc_start);
428 if (info->thread_pool_size != min_t(unsigned long, 431 if (info->thread_pool_size != min_t(unsigned long,
429 num_online_cpus() + 2, 8)) 432 num_online_cpus() + 2, 8))
430 seq_printf(seq, ",thread_pool=%d", info->thread_pool_size); 433 seq_printf(seq, ",thread_pool=%d", info->thread_pool_size);