diff options
author | Ondrej Zajicek <santiago@crfreenet.org> | 2008-04-28 05:15:18 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-28 11:58:38 -0400 |
commit | 20e061fb750d36ec0ffcb2e44ed7dafa9018223b (patch) | |
tree | 2b3a55f91500ae0a1826a5ee9ac10f58e50b4049 | |
parent | 8f5af9de9cf3cbf51c5758a1d5ea266aea6fe175 (diff) |
fbdev: framebuffer_alloc() fixes
Correct the dev arg of framebuffer_alloc() in arkfb, s3fb and vt8623fb.
Signed-off-by: Ondrej Zajicek <santiago@crfreenet.org>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | drivers/video/arkfb.c | 20 | ||||
-rw-r--r-- | drivers/video/s3fb.c | 20 | ||||
-rw-r--r-- | drivers/video/vt8623fb.c | 22 |
3 files changed, 31 insertions, 31 deletions
diff --git a/drivers/video/arkfb.c b/drivers/video/arkfb.c index 0f6e0043069d..5001bd4ef466 100644 --- a/drivers/video/arkfb.c +++ b/drivers/video/arkfb.c | |||
@@ -943,7 +943,7 @@ static int __devinit ark_pci_probe(struct pci_dev *dev, const struct pci_device_ | |||
943 | } | 943 | } |
944 | 944 | ||
945 | /* Allocate and fill driver data structure */ | 945 | /* Allocate and fill driver data structure */ |
946 | info = framebuffer_alloc(sizeof(struct arkfb_info), NULL); | 946 | info = framebuffer_alloc(sizeof(struct arkfb_info), &(dev->dev)); |
947 | if (! info) { | 947 | if (! info) { |
948 | dev_err(&(dev->dev), "cannot allocate memory\n"); | 948 | dev_err(&(dev->dev), "cannot allocate memory\n"); |
949 | return -ENOMEM; | 949 | return -ENOMEM; |
@@ -958,20 +958,20 @@ static int __devinit ark_pci_probe(struct pci_dev *dev, const struct pci_device_ | |||
958 | /* Prepare PCI device */ | 958 | /* Prepare PCI device */ |
959 | rc = pci_enable_device(dev); | 959 | rc = pci_enable_device(dev); |
960 | if (rc < 0) { | 960 | if (rc < 0) { |
961 | dev_err(&(dev->dev), "cannot enable PCI device\n"); | 961 | dev_err(info->dev, "cannot enable PCI device\n"); |
962 | goto err_enable_device; | 962 | goto err_enable_device; |
963 | } | 963 | } |
964 | 964 | ||
965 | rc = pci_request_regions(dev, "arkfb"); | 965 | rc = pci_request_regions(dev, "arkfb"); |
966 | if (rc < 0) { | 966 | if (rc < 0) { |
967 | dev_err(&(dev->dev), "cannot reserve framebuffer region\n"); | 967 | dev_err(info->dev, "cannot reserve framebuffer region\n"); |
968 | goto err_request_regions; | 968 | goto err_request_regions; |
969 | } | 969 | } |
970 | 970 | ||
971 | par->dac = ics5342_init(ark_dac_read_regs, ark_dac_write_regs, info); | 971 | par->dac = ics5342_init(ark_dac_read_regs, ark_dac_write_regs, info); |
972 | if (! par->dac) { | 972 | if (! par->dac) { |
973 | rc = -ENOMEM; | 973 | rc = -ENOMEM; |
974 | dev_err(&(dev->dev), "RAMDAC initialization failed\n"); | 974 | dev_err(info->dev, "RAMDAC initialization failed\n"); |
975 | goto err_dac; | 975 | goto err_dac; |
976 | } | 976 | } |
977 | 977 | ||
@@ -982,7 +982,7 @@ static int __devinit ark_pci_probe(struct pci_dev *dev, const struct pci_device_ | |||
982 | info->screen_base = pci_iomap(dev, 0, 0); | 982 | info->screen_base = pci_iomap(dev, 0, 0); |
983 | if (! info->screen_base) { | 983 | if (! info->screen_base) { |
984 | rc = -ENOMEM; | 984 | rc = -ENOMEM; |
985 | dev_err(&(dev->dev), "iomap for framebuffer failed\n"); | 985 | dev_err(info->dev, "iomap for framebuffer failed\n"); |
986 | goto err_iomap; | 986 | goto err_iomap; |
987 | } | 987 | } |
988 | 988 | ||
@@ -1004,19 +1004,19 @@ static int __devinit ark_pci_probe(struct pci_dev *dev, const struct pci_device_ | |||
1004 | rc = fb_find_mode(&(info->var), info, mode_option, NULL, 0, NULL, 8); | 1004 | rc = fb_find_mode(&(info->var), info, mode_option, NULL, 0, NULL, 8); |
1005 | if (! ((rc == 1) || (rc == 2))) { | 1005 | if (! ((rc == 1) || (rc == 2))) { |
1006 | rc = -EINVAL; | 1006 | rc = -EINVAL; |
1007 | dev_err(&(dev->dev), "mode %s not found\n", mode_option); | 1007 | dev_err(info->dev, "mode %s not found\n", mode_option); |
1008 | goto err_find_mode; | 1008 | goto err_find_mode; |
1009 | } | 1009 | } |
1010 | 1010 | ||
1011 | rc = fb_alloc_cmap(&info->cmap, 256, 0); | 1011 | rc = fb_alloc_cmap(&info->cmap, 256, 0); |
1012 | if (rc < 0) { | 1012 | if (rc < 0) { |
1013 | dev_err(&(dev->dev), "cannot allocate colormap\n"); | 1013 | dev_err(info->dev, "cannot allocate colormap\n"); |
1014 | goto err_alloc_cmap; | 1014 | goto err_alloc_cmap; |
1015 | } | 1015 | } |
1016 | 1016 | ||
1017 | rc = register_framebuffer(info); | 1017 | rc = register_framebuffer(info); |
1018 | if (rc < 0) { | 1018 | if (rc < 0) { |
1019 | dev_err(&(dev->dev), "cannot register framebugger\n"); | 1019 | dev_err(info->dev, "cannot register framebugger\n"); |
1020 | goto err_reg_fb; | 1020 | goto err_reg_fb; |
1021 | } | 1021 | } |
1022 | 1022 | ||
@@ -1090,7 +1090,7 @@ static int ark_pci_suspend (struct pci_dev* dev, pm_message_t state) | |||
1090 | struct fb_info *info = pci_get_drvdata(dev); | 1090 | struct fb_info *info = pci_get_drvdata(dev); |
1091 | struct arkfb_info *par = info->par; | 1091 | struct arkfb_info *par = info->par; |
1092 | 1092 | ||
1093 | dev_info(&(dev->dev), "suspend\n"); | 1093 | dev_info(info->dev, "suspend\n"); |
1094 | 1094 | ||
1095 | acquire_console_sem(); | 1095 | acquire_console_sem(); |
1096 | mutex_lock(&(par->open_lock)); | 1096 | mutex_lock(&(par->open_lock)); |
@@ -1121,7 +1121,7 @@ static int ark_pci_resume (struct pci_dev* dev) | |||
1121 | struct fb_info *info = pci_get_drvdata(dev); | 1121 | struct fb_info *info = pci_get_drvdata(dev); |
1122 | struct arkfb_info *par = info->par; | 1122 | struct arkfb_info *par = info->par; |
1123 | 1123 | ||
1124 | dev_info(&(dev->dev), "resume\n"); | 1124 | dev_info(info->dev, "resume\n"); |
1125 | 1125 | ||
1126 | acquire_console_sem(); | 1126 | acquire_console_sem(); |
1127 | mutex_lock(&(par->open_lock)); | 1127 | mutex_lock(&(par->open_lock)); |
diff --git a/drivers/video/s3fb.c b/drivers/video/s3fb.c index 649cdd213d0f..2972f112dbed 100644 --- a/drivers/video/s3fb.c +++ b/drivers/video/s3fb.c | |||
@@ -888,7 +888,7 @@ static int __devinit s3_pci_probe(struct pci_dev *dev, const struct pci_device_i | |||
888 | } | 888 | } |
889 | 889 | ||
890 | /* Allocate and fill driver data structure */ | 890 | /* Allocate and fill driver data structure */ |
891 | info = framebuffer_alloc(sizeof(struct s3fb_info), NULL); | 891 | info = framebuffer_alloc(sizeof(struct s3fb_info), &(dev->dev)); |
892 | if (!info) { | 892 | if (!info) { |
893 | dev_err(&(dev->dev), "cannot allocate memory\n"); | 893 | dev_err(&(dev->dev), "cannot allocate memory\n"); |
894 | return -ENOMEM; | 894 | return -ENOMEM; |
@@ -903,13 +903,13 @@ static int __devinit s3_pci_probe(struct pci_dev *dev, const struct pci_device_i | |||
903 | /* Prepare PCI device */ | 903 | /* Prepare PCI device */ |
904 | rc = pci_enable_device(dev); | 904 | rc = pci_enable_device(dev); |
905 | if (rc < 0) { | 905 | if (rc < 0) { |
906 | dev_err(&(dev->dev), "cannot enable PCI device\n"); | 906 | dev_err(info->dev, "cannot enable PCI device\n"); |
907 | goto err_enable_device; | 907 | goto err_enable_device; |
908 | } | 908 | } |
909 | 909 | ||
910 | rc = pci_request_regions(dev, "s3fb"); | 910 | rc = pci_request_regions(dev, "s3fb"); |
911 | if (rc < 0) { | 911 | if (rc < 0) { |
912 | dev_err(&(dev->dev), "cannot reserve framebuffer region\n"); | 912 | dev_err(info->dev, "cannot reserve framebuffer region\n"); |
913 | goto err_request_regions; | 913 | goto err_request_regions; |
914 | } | 914 | } |
915 | 915 | ||
@@ -921,7 +921,7 @@ static int __devinit s3_pci_probe(struct pci_dev *dev, const struct pci_device_i | |||
921 | info->screen_base = pci_iomap(dev, 0, 0); | 921 | info->screen_base = pci_iomap(dev, 0, 0); |
922 | if (! info->screen_base) { | 922 | if (! info->screen_base) { |
923 | rc = -ENOMEM; | 923 | rc = -ENOMEM; |
924 | dev_err(&(dev->dev), "iomap for framebuffer failed\n"); | 924 | dev_err(info->dev, "iomap for framebuffer failed\n"); |
925 | goto err_iomap; | 925 | goto err_iomap; |
926 | } | 926 | } |
927 | 927 | ||
@@ -965,19 +965,19 @@ static int __devinit s3_pci_probe(struct pci_dev *dev, const struct pci_device_i | |||
965 | rc = fb_find_mode(&(info->var), info, mode_option, NULL, 0, NULL, 8); | 965 | rc = fb_find_mode(&(info->var), info, mode_option, NULL, 0, NULL, 8); |
966 | if (! ((rc == 1) || (rc == 2))) { | 966 | if (! ((rc == 1) || (rc == 2))) { |
967 | rc = -EINVAL; | 967 | rc = -EINVAL; |
968 | dev_err(&(dev->dev), "mode %s not found\n", mode_option); | 968 | dev_err(info->dev, "mode %s not found\n", mode_option); |
969 | goto err_find_mode; | 969 | goto err_find_mode; |
970 | } | 970 | } |
971 | 971 | ||
972 | rc = fb_alloc_cmap(&info->cmap, 256, 0); | 972 | rc = fb_alloc_cmap(&info->cmap, 256, 0); |
973 | if (rc < 0) { | 973 | if (rc < 0) { |
974 | dev_err(&(dev->dev), "cannot allocate colormap\n"); | 974 | dev_err(info->dev, "cannot allocate colormap\n"); |
975 | goto err_alloc_cmap; | 975 | goto err_alloc_cmap; |
976 | } | 976 | } |
977 | 977 | ||
978 | rc = register_framebuffer(info); | 978 | rc = register_framebuffer(info); |
979 | if (rc < 0) { | 979 | if (rc < 0) { |
980 | dev_err(&(dev->dev), "cannot register framebuffer\n"); | 980 | dev_err(info->dev, "cannot register framebuffer\n"); |
981 | goto err_reg_fb; | 981 | goto err_reg_fb; |
982 | } | 982 | } |
983 | 983 | ||
@@ -1053,7 +1053,7 @@ static int s3_pci_suspend(struct pci_dev* dev, pm_message_t state) | |||
1053 | struct fb_info *info = pci_get_drvdata(dev); | 1053 | struct fb_info *info = pci_get_drvdata(dev); |
1054 | struct s3fb_info *par = info->par; | 1054 | struct s3fb_info *par = info->par; |
1055 | 1055 | ||
1056 | dev_info(&(dev->dev), "suspend\n"); | 1056 | dev_info(info->dev, "suspend\n"); |
1057 | 1057 | ||
1058 | acquire_console_sem(); | 1058 | acquire_console_sem(); |
1059 | mutex_lock(&(par->open_lock)); | 1059 | mutex_lock(&(par->open_lock)); |
@@ -1085,7 +1085,7 @@ static int s3_pci_resume(struct pci_dev* dev) | |||
1085 | struct s3fb_info *par = info->par; | 1085 | struct s3fb_info *par = info->par; |
1086 | int err; | 1086 | int err; |
1087 | 1087 | ||
1088 | dev_info(&(dev->dev), "resume\n"); | 1088 | dev_info(info->dev, "resume\n"); |
1089 | 1089 | ||
1090 | acquire_console_sem(); | 1090 | acquire_console_sem(); |
1091 | mutex_lock(&(par->open_lock)); | 1091 | mutex_lock(&(par->open_lock)); |
@@ -1102,7 +1102,7 @@ static int s3_pci_resume(struct pci_dev* dev) | |||
1102 | if (err) { | 1102 | if (err) { |
1103 | mutex_unlock(&(par->open_lock)); | 1103 | mutex_unlock(&(par->open_lock)); |
1104 | release_console_sem(); | 1104 | release_console_sem(); |
1105 | dev_err(&(dev->dev), "error %d enabling device for resume\n", err); | 1105 | dev_err(info->dev, "error %d enabling device for resume\n", err); |
1106 | return err; | 1106 | return err; |
1107 | } | 1107 | } |
1108 | pci_set_master(dev); | 1108 | pci_set_master(dev); |
diff --git a/drivers/video/vt8623fb.c b/drivers/video/vt8623fb.c index 0b9dd22f3ee6..536ab11623f0 100644 --- a/drivers/video/vt8623fb.c +++ b/drivers/video/vt8623fb.c | |||
@@ -661,7 +661,7 @@ static int __devinit vt8623_pci_probe(struct pci_dev *dev, const struct pci_devi | |||
661 | } | 661 | } |
662 | 662 | ||
663 | /* Allocate and fill driver data structure */ | 663 | /* Allocate and fill driver data structure */ |
664 | info = framebuffer_alloc(sizeof(struct vt8623fb_info), NULL); | 664 | info = framebuffer_alloc(sizeof(struct vt8623fb_info), &(dev->dev)); |
665 | if (! info) { | 665 | if (! info) { |
666 | dev_err(&(dev->dev), "cannot allocate memory\n"); | 666 | dev_err(&(dev->dev), "cannot allocate memory\n"); |
667 | return -ENOMEM; | 667 | return -ENOMEM; |
@@ -677,13 +677,13 @@ static int __devinit vt8623_pci_probe(struct pci_dev *dev, const struct pci_devi | |||
677 | 677 | ||
678 | rc = pci_enable_device(dev); | 678 | rc = pci_enable_device(dev); |
679 | if (rc < 0) { | 679 | if (rc < 0) { |
680 | dev_err(&(dev->dev), "cannot enable PCI device\n"); | 680 | dev_err(info->dev, "cannot enable PCI device\n"); |
681 | goto err_enable_device; | 681 | goto err_enable_device; |
682 | } | 682 | } |
683 | 683 | ||
684 | rc = pci_request_regions(dev, "vt8623fb"); | 684 | rc = pci_request_regions(dev, "vt8623fb"); |
685 | if (rc < 0) { | 685 | if (rc < 0) { |
686 | dev_err(&(dev->dev), "cannot reserve framebuffer region\n"); | 686 | dev_err(info->dev, "cannot reserve framebuffer region\n"); |
687 | goto err_request_regions; | 687 | goto err_request_regions; |
688 | } | 688 | } |
689 | 689 | ||
@@ -696,14 +696,14 @@ static int __devinit vt8623_pci_probe(struct pci_dev *dev, const struct pci_devi | |||
696 | info->screen_base = pci_iomap(dev, 0, 0); | 696 | info->screen_base = pci_iomap(dev, 0, 0); |
697 | if (! info->screen_base) { | 697 | if (! info->screen_base) { |
698 | rc = -ENOMEM; | 698 | rc = -ENOMEM; |
699 | dev_err(&(dev->dev), "iomap for framebuffer failed\n"); | 699 | dev_err(info->dev, "iomap for framebuffer failed\n"); |
700 | goto err_iomap_1; | 700 | goto err_iomap_1; |
701 | } | 701 | } |
702 | 702 | ||
703 | par->mmio_base = pci_iomap(dev, 1, 0); | 703 | par->mmio_base = pci_iomap(dev, 1, 0); |
704 | if (! par->mmio_base) { | 704 | if (! par->mmio_base) { |
705 | rc = -ENOMEM; | 705 | rc = -ENOMEM; |
706 | dev_err(&(dev->dev), "iomap for MMIO failed\n"); | 706 | dev_err(info->dev, "iomap for MMIO failed\n"); |
707 | goto err_iomap_2; | 707 | goto err_iomap_2; |
708 | } | 708 | } |
709 | 709 | ||
@@ -714,7 +714,7 @@ static int __devinit vt8623_pci_probe(struct pci_dev *dev, const struct pci_devi | |||
714 | if ((16 <= memsize1) && (memsize1 <= 64) && (memsize1 == memsize2)) | 714 | if ((16 <= memsize1) && (memsize1 <= 64) && (memsize1 == memsize2)) |
715 | info->screen_size = memsize1 << 20; | 715 | info->screen_size = memsize1 << 20; |
716 | else { | 716 | else { |
717 | dev_err(&(dev->dev), "memory size detection failed (%x %x), suppose 16 MB\n", memsize1, memsize2); | 717 | dev_err(info->dev, "memory size detection failed (%x %x), suppose 16 MB\n", memsize1, memsize2); |
718 | info->screen_size = 16 << 20; | 718 | info->screen_size = 16 << 20; |
719 | } | 719 | } |
720 | 720 | ||
@@ -731,19 +731,19 @@ static int __devinit vt8623_pci_probe(struct pci_dev *dev, const struct pci_devi | |||
731 | rc = fb_find_mode(&(info->var), info, mode_option, NULL, 0, NULL, 8); | 731 | rc = fb_find_mode(&(info->var), info, mode_option, NULL, 0, NULL, 8); |
732 | if (! ((rc == 1) || (rc == 2))) { | 732 | if (! ((rc == 1) || (rc == 2))) { |
733 | rc = -EINVAL; | 733 | rc = -EINVAL; |
734 | dev_err(&(dev->dev), "mode %s not found\n", mode_option); | 734 | dev_err(info->dev, "mode %s not found\n", mode_option); |
735 | goto err_find_mode; | 735 | goto err_find_mode; |
736 | } | 736 | } |
737 | 737 | ||
738 | rc = fb_alloc_cmap(&info->cmap, 256, 0); | 738 | rc = fb_alloc_cmap(&info->cmap, 256, 0); |
739 | if (rc < 0) { | 739 | if (rc < 0) { |
740 | dev_err(&(dev->dev), "cannot allocate colormap\n"); | 740 | dev_err(info->dev, "cannot allocate colormap\n"); |
741 | goto err_alloc_cmap; | 741 | goto err_alloc_cmap; |
742 | } | 742 | } |
743 | 743 | ||
744 | rc = register_framebuffer(info); | 744 | rc = register_framebuffer(info); |
745 | if (rc < 0) { | 745 | if (rc < 0) { |
746 | dev_err(&(dev->dev), "cannot register framebugger\n"); | 746 | dev_err(info->dev, "cannot register framebugger\n"); |
747 | goto err_reg_fb; | 747 | goto err_reg_fb; |
748 | } | 748 | } |
749 | 749 | ||
@@ -817,7 +817,7 @@ static int vt8623_pci_suspend(struct pci_dev* dev, pm_message_t state) | |||
817 | struct fb_info *info = pci_get_drvdata(dev); | 817 | struct fb_info *info = pci_get_drvdata(dev); |
818 | struct vt8623fb_info *par = info->par; | 818 | struct vt8623fb_info *par = info->par; |
819 | 819 | ||
820 | dev_info(&(dev->dev), "suspend\n"); | 820 | dev_info(info->dev, "suspend\n"); |
821 | 821 | ||
822 | acquire_console_sem(); | 822 | acquire_console_sem(); |
823 | mutex_lock(&(par->open_lock)); | 823 | mutex_lock(&(par->open_lock)); |
@@ -848,7 +848,7 @@ static int vt8623_pci_resume(struct pci_dev* dev) | |||
848 | struct fb_info *info = pci_get_drvdata(dev); | 848 | struct fb_info *info = pci_get_drvdata(dev); |
849 | struct vt8623fb_info *par = info->par; | 849 | struct vt8623fb_info *par = info->par; |
850 | 850 | ||
851 | dev_info(&(dev->dev), "resume\n"); | 851 | dev_info(info->dev, "resume\n"); |
852 | 852 | ||
853 | acquire_console_sem(); | 853 | acquire_console_sem(); |
854 | mutex_lock(&(par->open_lock)); | 854 | mutex_lock(&(par->open_lock)); |