diff options
author | Al Viro <viro@ftp.linux.org.uk> | 2010-09-20 10:13:25 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-09-20 13:44:38 -0400 |
commit | ed1cde68365c1251b920900c51e73675ff38dc66 (patch) | |
tree | 7f43fcfef76bc3d715db22ab575efadeefaf8739 | |
parent | 44c7afffa429a7cdcd1755019ab76566ff41e66d (diff) |
frv: double syscall restarts, syscall restart in sigreturn()
We need to make sure that only the first do_signal() to be handled on
the way out syscall will bother with syscall restarts; additionally, the
check on the "signal has user handler" path had been wrong - compare
with restart prevention in sigreturn()...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | arch/frv/kernel/signal.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/arch/frv/kernel/signal.c b/arch/frv/kernel/signal.c index bd13b57a5c9b..bab01298b58e 100644 --- a/arch/frv/kernel/signal.c +++ b/arch/frv/kernel/signal.c | |||
@@ -446,7 +446,7 @@ static int handle_signal(unsigned long sig, siginfo_t *info, | |||
446 | int ret; | 446 | int ret; |
447 | 447 | ||
448 | /* Are we from a system call? */ | 448 | /* Are we from a system call? */ |
449 | if (in_syscall(__frame)) { | 449 | if (__frame->syscallno != -1) { |
450 | /* If so, check system call restarting.. */ | 450 | /* If so, check system call restarting.. */ |
451 | switch (__frame->gr8) { | 451 | switch (__frame->gr8) { |
452 | case -ERESTART_RESTARTBLOCK: | 452 | case -ERESTART_RESTARTBLOCK: |
@@ -465,6 +465,7 @@ static int handle_signal(unsigned long sig, siginfo_t *info, | |||
465 | __frame->gr8 = __frame->orig_gr8; | 465 | __frame->gr8 = __frame->orig_gr8; |
466 | __frame->pc -= 4; | 466 | __frame->pc -= 4; |
467 | } | 467 | } |
468 | __frame->syscallno = -1; | ||
468 | } | 469 | } |
469 | 470 | ||
470 | /* Set up the stack frame */ | 471 | /* Set up the stack frame */ |
@@ -551,6 +552,7 @@ no_signal: | |||
551 | __frame->pc -= 4; | 552 | __frame->pc -= 4; |
552 | break; | 553 | break; |
553 | } | 554 | } |
555 | __frame->syscallno = -1; | ||
554 | } | 556 | } |
555 | 557 | ||
556 | /* if there's no signal to deliver, we just put the saved sigmask | 558 | /* if there's no signal to deliver, we just put the saved sigmask |