aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@woody.linux-foundation.org>2007-06-04 20:54:09 -0400
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-06-04 20:54:09 -0400
commitec4883b015c3212f6f6d04fb2ff45f528492f598 (patch)
tree0e393eb198a35a90adafcd8129564d0173aafad4
parent464cf177df7727efcc5506322fc5d0c8b896f545 (diff)
parent0477d24e2a87a9077b62298b01b031929f5cf2a2 (diff)
Merge git://git.infradead.org/mtd-2.6
* git://git.infradead.org/mtd-2.6: [JFFS2] Fix obsoletion of metadata nodes in jffs2_add_tn_to_tree() [MTD] Fix error checking after get_mtd_device() in get_sb_mtd functions [JFFS2] Fix buffer length calculations in jffs2_get_inode_nodes() [JFFS2] Fix potential memory leak of dead xattrs on unmount. [JFFS2] Fix BUG() caused by failing to discard xattrs on deleted files. [MTD] generalise the handling of MTD-specific superblocks [MTD] [MAPS] don't force uclinux mtd map to be root dev
-rw-r--r--drivers/mtd/Makefile3
-rw-r--r--drivers/mtd/maps/uclinux.c5
-rw-r--r--drivers/mtd/mtdsuper.c232
-rw-r--r--fs/jffs2/readinode.c22
-rw-r--r--fs/jffs2/super.c194
-rw-r--r--fs/jffs2/xattr.c6
-rw-r--r--include/linux/fs.h1
-rw-r--r--include/linux/mtd/super.h30
8 files changed, 304 insertions, 189 deletions
diff --git a/drivers/mtd/Makefile b/drivers/mtd/Makefile
index 92055405cb30..451adcc52b3c 100644
--- a/drivers/mtd/Makefile
+++ b/drivers/mtd/Makefile
@@ -1,10 +1,9 @@
1# 1#
2# Makefile for the memory technology device drivers. 2# Makefile for the memory technology device drivers.
3# 3#
4# $Id: Makefile.common,v 1.7 2005/07/11 10:39:27 gleixner Exp $
5 4
6# Core functionality. 5# Core functionality.
7mtd-y := mtdcore.o 6mtd-y := mtdcore.o mtdsuper.o
8mtd-$(CONFIG_MTD_PARTITIONS) += mtdpart.o 7mtd-$(CONFIG_MTD_PARTITIONS) += mtdpart.o
9obj-$(CONFIG_MTD) += $(mtd-y) 8obj-$(CONFIG_MTD) += $(mtd-y)
10 9
diff --git a/drivers/mtd/maps/uclinux.c b/drivers/mtd/maps/uclinux.c
index 389fea28b9a6..14ffb1a9302a 100644
--- a/drivers/mtd/maps/uclinux.c
+++ b/drivers/mtd/maps/uclinux.c
@@ -16,7 +16,6 @@
16#include <linux/kernel.h> 16#include <linux/kernel.h>
17#include <linux/fs.h> 17#include <linux/fs.h>
18#include <linux/major.h> 18#include <linux/major.h>
19#include <linux/root_dev.h>
20#include <linux/mtd/mtd.h> 19#include <linux/mtd/mtd.h>
21#include <linux/mtd/map.h> 20#include <linux/mtd/map.h>
22#include <linux/mtd/partitions.h> 21#include <linux/mtd/partitions.h>
@@ -89,10 +88,6 @@ int __init uclinux_mtd_init(void)
89 uclinux_ram_mtdinfo = mtd; 88 uclinux_ram_mtdinfo = mtd;
90 add_mtd_partitions(mtd, uclinux_romfs, NUM_PARTITIONS); 89 add_mtd_partitions(mtd, uclinux_romfs, NUM_PARTITIONS);
91 90
92 printk("uclinux[mtd]: set %s to be root filesystem\n",
93 uclinux_romfs[0].name);
94 ROOT_DEV = MKDEV(MTD_BLOCK_MAJOR, 0);
95
96 return(0); 91 return(0);
97} 92}
98 93
diff --git a/drivers/mtd/mtdsuper.c b/drivers/mtd/mtdsuper.c
new file mode 100644
index 000000000000..aca331971201
--- /dev/null
+++ b/drivers/mtd/mtdsuper.c
@@ -0,0 +1,232 @@
1/* MTD-based superblock management
2 *
3 * Copyright © 2001-2007 Red Hat, Inc. All Rights Reserved.
4 * Written by: David Howells <dhowells@redhat.com>
5 * David Woodhouse <dwmw2@infradead.org>
6 *
7 * This program is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU General Public License
9 * as published by the Free Software Foundation; either version
10 * 2 of the License, or (at your option) any later version.
11 */
12
13#include <linux/mtd/super.h>
14#include <linux/namei.h>
15#include <linux/ctype.h>
16
17/*
18 * compare superblocks to see if they're equivalent
19 * - they are if the underlying MTD device is the same
20 */
21static int get_sb_mtd_compare(struct super_block *sb, void *_mtd)
22{
23 struct mtd_info *mtd = _mtd;
24
25 if (sb->s_mtd == mtd) {
26 DEBUG(2, "MTDSB: Match on device %d (\"%s\")\n",
27 mtd->index, mtd->name);
28 return 1;
29 }
30
31 DEBUG(2, "MTDSB: No match, device %d (\"%s\"), device %d (\"%s\")\n",
32 sb->s_mtd->index, sb->s_mtd->name, mtd->index, mtd->name);
33 return 0;
34}
35
36/*
37 * mark the superblock by the MTD device it is using
38 * - set the device number to be the correct MTD block device for pesuperstence
39 * of NFS exports
40 */
41static int get_sb_mtd_set(struct super_block *sb, void *_mtd)
42{
43 struct mtd_info *mtd = _mtd;
44
45 sb->s_mtd = mtd;
46 sb->s_dev = MKDEV(MTD_BLOCK_MAJOR, mtd->index);
47 return 0;
48}
49
50/*
51 * get a superblock on an MTD-backed filesystem
52 */
53static int get_sb_mtd_aux(struct file_system_type *fs_type, int flags,
54 const char *dev_name, void *data,
55 struct mtd_info *mtd,
56 int (*fill_super)(struct super_block *, void *, int),
57 struct vfsmount *mnt)
58{
59 struct super_block *sb;
60 int ret;
61
62 sb = sget(fs_type, get_sb_mtd_compare, get_sb_mtd_set, mtd);
63 if (IS_ERR(sb))
64 goto out_error;
65
66 if (sb->s_root)
67 goto already_mounted;
68
69 /* fresh new superblock */
70 DEBUG(1, "MTDSB: New superblock for device %d (\"%s\")\n",
71 mtd->index, mtd->name);
72
73 ret = fill_super(sb, data, flags & MS_SILENT ? 1 : 0);
74 if (ret < 0) {
75 up_write(&sb->s_umount);
76 deactivate_super(sb);
77 return ret;
78 }
79
80 /* go */
81 sb->s_flags |= MS_ACTIVE;
82 return simple_set_mnt(mnt, sb);
83
84 /* new mountpoint for an already mounted superblock */
85already_mounted:
86 DEBUG(1, "MTDSB: Device %d (\"%s\") is already mounted\n",
87 mtd->index, mtd->name);
88 ret = simple_set_mnt(mnt, sb);
89 goto out_put;
90
91out_error:
92 ret = PTR_ERR(sb);
93out_put:
94 put_mtd_device(mtd);
95 return ret;
96}
97
98/*
99 * get a superblock on an MTD-backed filesystem by MTD device number
100 */
101static int get_sb_mtd_nr(struct file_system_type *fs_type, int flags,
102 const char *dev_name, void *data, int mtdnr,
103 int (*fill_super)(struct super_block *, void *, int),
104 struct vfsmount *mnt)
105{
106 struct mtd_info *mtd;
107
108 mtd = get_mtd_device(NULL, mtdnr);
109 if (IS_ERR(mtd)) {
110 DEBUG(0, "MTDSB: Device #%u doesn't appear to exist\n", mtdnr);
111 return PTR_ERR(mtd);
112 }
113
114 return get_sb_mtd_aux(fs_type, flags, dev_name, data, mtd, fill_super,
115 mnt);
116}
117
118/*
119 * set up an MTD-based superblock
120 */
121int get_sb_mtd(struct file_system_type *fs_type, int flags,
122 const char *dev_name, void *data,
123 int (*fill_super)(struct super_block *, void *, int),
124 struct vfsmount *mnt)
125{
126 struct nameidata nd;
127 int mtdnr, ret;
128
129 if (!dev_name)
130 return -EINVAL;
131
132 DEBUG(2, "MTDSB: dev_name \"%s\"\n", dev_name);
133
134 /* the preferred way of mounting in future; especially when
135 * CONFIG_BLOCK=n - we specify the underlying MTD device by number or
136 * by name, so that we don't require block device support to be present
137 * in the kernel. */
138 if (dev_name[0] == 'm' && dev_name[1] == 't' && dev_name[2] == 'd') {
139 if (dev_name[3] == ':') {
140 struct mtd_info *mtd;
141
142 /* mount by MTD device name */
143 DEBUG(1, "MTDSB: mtd:%%s, name \"%s\"\n",
144 dev_name + 4);
145
146 for (mtdnr = 0; mtdnr < MAX_MTD_DEVICES; mtdnr++) {
147 mtd = get_mtd_device(NULL, mtdnr);
148 if (!IS_ERR(mtd)) {
149 if (!strcmp(mtd->name, dev_name + 4))
150 return get_sb_mtd_aux(
151 fs_type, flags,
152 dev_name, data, mtd,
153 fill_super, mnt);
154
155 put_mtd_device(mtd);
156 }
157 }
158
159 printk(KERN_NOTICE "MTD:"
160 " MTD device with name \"%s\" not found.\n",
161 dev_name + 4);
162
163 } else if (isdigit(dev_name[3])) {
164 /* mount by MTD device number name */
165 char *endptr;
166
167 mtdnr = simple_strtoul(dev_name + 3, &endptr, 0);
168 if (!*endptr) {
169 /* It was a valid number */
170 DEBUG(1, "MTDSB: mtd%%d, mtdnr %d\n",
171 mtdnr);
172 return get_sb_mtd_nr(fs_type, flags,
173 dev_name, data,
174 mtdnr, fill_super, mnt);
175 }
176 }
177 }
178
179 /* try the old way - the hack where we allowed users to mount
180 * /dev/mtdblock$(n) but didn't actually _use_ the blockdev
181 */
182 ret = path_lookup(dev_name, LOOKUP_FOLLOW, &nd);
183
184 DEBUG(1, "MTDSB: path_lookup() returned %d, inode %p\n",
185 ret, nd.dentry ? nd.dentry->d_inode : NULL);
186
187 if (ret)
188 return ret;
189
190 ret = -EINVAL;
191
192 if (!S_ISBLK(nd.dentry->d_inode->i_mode))
193 goto out;
194
195 if (nd.mnt->mnt_flags & MNT_NODEV) {
196 ret = -EACCES;
197 goto out;
198 }
199
200 if (imajor(nd.dentry->d_inode) != MTD_BLOCK_MAJOR)
201 goto not_an_MTD_device;
202
203 mtdnr = iminor(nd.dentry->d_inode);
204 path_release(&nd);
205
206 return get_sb_mtd_nr(fs_type, flags, dev_name, data, mtdnr, fill_super,
207 mnt);
208
209not_an_MTD_device:
210 if (!(flags & MS_SILENT))
211 printk(KERN_NOTICE
212 "MTD: Attempt to mount non-MTD device \"%s\"\n",
213 dev_name);
214out:
215 path_release(&nd);
216 return ret;
217
218}
219
220EXPORT_SYMBOL_GPL(get_sb_mtd);
221
222/*
223 * destroy an MTD-based superblock
224 */
225void kill_mtd_super(struct super_block *sb)
226{
227 generic_shutdown_super(sb);
228 put_mtd_device(sb->s_mtd);
229 sb->s_mtd = NULL;
230}
231
232EXPORT_SYMBOL_GPL(kill_mtd_super);
diff --git a/fs/jffs2/readinode.c b/fs/jffs2/readinode.c
index 4884d5edfe65..12e83f67eee4 100644
--- a/fs/jffs2/readinode.c
+++ b/fs/jffs2/readinode.c
@@ -229,9 +229,16 @@ static int jffs2_add_tn_to_tree(struct jffs2_sb_info *c,
229 check anyway. */ 229 check anyway. */
230 if (!tn->fn->size) { 230 if (!tn->fn->size) {
231 if (rii->mdata_tn) { 231 if (rii->mdata_tn) {
232 /* We had a candidate mdata node already */ 232 if (rii->mdata_tn->version < tn->version) {
233 dbg_readinode("kill old mdata with ver %d\n", rii->mdata_tn->version); 233 /* We had a candidate mdata node already */
234 jffs2_kill_tn(c, rii->mdata_tn); 234 dbg_readinode("kill old mdata with ver %d\n", rii->mdata_tn->version);
235 jffs2_kill_tn(c, rii->mdata_tn);
236 } else {
237 dbg_readinode("kill new mdata with ver %d (older than existing %d\n",
238 tn->version, rii->mdata_tn->version);
239 jffs2_kill_tn(c, tn);
240 return 0;
241 }
235 } 242 }
236 rii->mdata_tn = tn; 243 rii->mdata_tn = tn;
237 dbg_readinode("keep new mdata with ver %d\n", tn->version); 244 dbg_readinode("keep new mdata with ver %d\n", tn->version);
@@ -1044,7 +1051,8 @@ static int jffs2_get_inode_nodes(struct jffs2_sb_info *c, struct jffs2_inode_inf
1044 1051
1045 case JFFS2_NODETYPE_DIRENT: 1052 case JFFS2_NODETYPE_DIRENT:
1046 1053
1047 if (JFFS2_MIN_NODE_HEADER < sizeof(struct jffs2_raw_dirent)) { 1054 if (JFFS2_MIN_NODE_HEADER < sizeof(struct jffs2_raw_dirent) &&
1055 len < sizeof(struct jffs2_raw_dirent)) {
1048 err = read_more(c, ref, sizeof(struct jffs2_raw_dirent), &len, buf); 1056 err = read_more(c, ref, sizeof(struct jffs2_raw_dirent), &len, buf);
1049 if (unlikely(err)) 1057 if (unlikely(err))
1050 goto free_out; 1058 goto free_out;
@@ -1058,7 +1066,8 @@ static int jffs2_get_inode_nodes(struct jffs2_sb_info *c, struct jffs2_inode_inf
1058 1066
1059 case JFFS2_NODETYPE_INODE: 1067 case JFFS2_NODETYPE_INODE:
1060 1068
1061 if (JFFS2_MIN_NODE_HEADER < sizeof(struct jffs2_raw_inode)) { 1069 if (JFFS2_MIN_NODE_HEADER < sizeof(struct jffs2_raw_inode) &&
1070 len < sizeof(struct jffs2_raw_inode)) {
1062 err = read_more(c, ref, sizeof(struct jffs2_raw_inode), &len, buf); 1071 err = read_more(c, ref, sizeof(struct jffs2_raw_inode), &len, buf);
1063 if (unlikely(err)) 1072 if (unlikely(err))
1064 goto free_out; 1073 goto free_out;
@@ -1071,7 +1080,8 @@ static int jffs2_get_inode_nodes(struct jffs2_sb_info *c, struct jffs2_inode_inf
1071 break; 1080 break;
1072 1081
1073 default: 1082 default:
1074 if (JFFS2_MIN_NODE_HEADER < sizeof(struct jffs2_unknown_node)) { 1083 if (JFFS2_MIN_NODE_HEADER < sizeof(struct jffs2_unknown_node) &&
1084 len < sizeof(struct jffs2_unknown_node)) {
1075 err = read_more(c, ref, sizeof(struct jffs2_unknown_node), &len, buf); 1085 err = read_more(c, ref, sizeof(struct jffs2_unknown_node), &len, buf);
1076 if (unlikely(err)) 1086 if (unlikely(err))
1077 goto free_out; 1087 goto free_out;
diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
index 6488af43bc9b..e220d3bd610d 100644
--- a/fs/jffs2/super.c
+++ b/fs/jffs2/super.c
@@ -19,7 +19,7 @@
19#include <linux/mount.h> 19#include <linux/mount.h>
20#include <linux/jffs2.h> 20#include <linux/jffs2.h>
21#include <linux/pagemap.h> 21#include <linux/pagemap.h>
22#include <linux/mtd/mtd.h> 22#include <linux/mtd/super.h>
23#include <linux/ctype.h> 23#include <linux/ctype.h>
24#include <linux/namei.h> 24#include <linux/namei.h>
25#include "compr.h" 25#include "compr.h"
@@ -75,69 +75,27 @@ static const struct super_operations jffs2_super_operations =
75 .sync_fs = jffs2_sync_fs, 75 .sync_fs = jffs2_sync_fs,
76}; 76};
77 77
78static int jffs2_sb_compare(struct super_block *sb, void *data) 78/*
79{ 79 * fill in the superblock
80 struct jffs2_sb_info *p = data; 80 */
81 struct jffs2_sb_info *c = JFFS2_SB_INFO(sb); 81static int jffs2_fill_super(struct super_block *sb, void *data, int silent)
82
83 /* The superblocks are considered to be equivalent if the underlying MTD
84 device is the same one */
85 if (c->mtd == p->mtd) {
86 D1(printk(KERN_DEBUG "jffs2_sb_compare: match on device %d (\"%s\")\n", p->mtd->index, p->mtd->name));
87 return 1;
88 } else {
89 D1(printk(KERN_DEBUG "jffs2_sb_compare: No match, device %d (\"%s\"), device %d (\"%s\")\n",
90 c->mtd->index, c->mtd->name, p->mtd->index, p->mtd->name));
91 return 0;
92 }
93}
94
95static int jffs2_sb_set(struct super_block *sb, void *data)
96{
97 struct jffs2_sb_info *p = data;
98
99 /* For persistence of NFS exports etc. we use the same s_dev
100 each time we mount the device, don't just use an anonymous
101 device */
102 sb->s_fs_info = p;
103 p->os_priv = sb;
104 sb->s_dev = MKDEV(MTD_BLOCK_MAJOR, p->mtd->index);
105
106 return 0;
107}
108
109static int jffs2_get_sb_mtd(struct file_system_type *fs_type,
110 int flags, const char *dev_name,
111 void *data, struct mtd_info *mtd,
112 struct vfsmount *mnt)
113{ 82{
114 struct super_block *sb;
115 struct jffs2_sb_info *c; 83 struct jffs2_sb_info *c;
116 int ret; 84
85 D1(printk(KERN_DEBUG "jffs2_get_sb_mtd():"
86 " New superblock for device %d (\"%s\")\n",
87 sb->s_mtd->index, sb->s_mtd->name));
117 88
118 c = kzalloc(sizeof(*c), GFP_KERNEL); 89 c = kzalloc(sizeof(*c), GFP_KERNEL);
119 if (!c) 90 if (!c)
120 return -ENOMEM; 91 return -ENOMEM;
121 c->mtd = mtd;
122
123 sb = sget(fs_type, jffs2_sb_compare, jffs2_sb_set, c);
124
125 if (IS_ERR(sb))
126 goto out_error;
127
128 if (sb->s_root) {
129 /* New mountpoint for JFFS2 which is already mounted */
130 D1(printk(KERN_DEBUG "jffs2_get_sb_mtd(): Device %d (\"%s\") is already mounted\n",
131 mtd->index, mtd->name));
132 ret = simple_set_mnt(mnt, sb);
133 goto out_put;
134 }
135 92
136 D1(printk(KERN_DEBUG "jffs2_get_sb_mtd(): New superblock for device %d (\"%s\")\n", 93 c->mtd = sb->s_mtd;
137 mtd->index, mtd->name)); 94 c->os_priv = sb;
95 sb->s_fs_info = c;
138 96
139 /* Initialize JFFS2 superblock locks, the further initialization will be 97 /* Initialize JFFS2 superblock locks, the further initialization will
140 * done later */ 98 * be done later */
141 init_MUTEX(&c->alloc_sem); 99 init_MUTEX(&c->alloc_sem);
142 init_MUTEX(&c->erase_free_sem); 100 init_MUTEX(&c->erase_free_sem);
143 init_waitqueue_head(&c->erase_wait); 101 init_waitqueue_head(&c->erase_wait);
@@ -146,133 +104,20 @@ static int jffs2_get_sb_mtd(struct file_system_type *fs_type,
146 spin_lock_init(&c->inocache_lock); 104 spin_lock_init(&c->inocache_lock);
147 105
148 sb->s_op = &jffs2_super_operations; 106 sb->s_op = &jffs2_super_operations;
149 sb->s_flags = flags | MS_NOATIME; 107 sb->s_flags = sb->s_flags | MS_NOATIME;
150 sb->s_xattr = jffs2_xattr_handlers; 108 sb->s_xattr = jffs2_xattr_handlers;
151#ifdef CONFIG_JFFS2_FS_POSIX_ACL 109#ifdef CONFIG_JFFS2_FS_POSIX_ACL
152 sb->s_flags |= MS_POSIXACL; 110 sb->s_flags |= MS_POSIXACL;
153#endif 111#endif
154 ret = jffs2_do_fill_super(sb, data, flags & MS_SILENT ? 1 : 0); 112 return jffs2_do_fill_super(sb, data, silent);
155
156 if (ret) {
157 /* Failure case... */
158 up_write(&sb->s_umount);
159 deactivate_super(sb);
160 return ret;
161 }
162
163 sb->s_flags |= MS_ACTIVE;
164 return simple_set_mnt(mnt, sb);
165
166out_error:
167 ret = PTR_ERR(sb);
168 out_put:
169 kfree(c);
170 put_mtd_device(mtd);
171
172 return ret;
173}
174
175static int jffs2_get_sb_mtdnr(struct file_system_type *fs_type,
176 int flags, const char *dev_name,
177 void *data, int mtdnr,
178 struct vfsmount *mnt)
179{
180 struct mtd_info *mtd;
181
182 mtd = get_mtd_device(NULL, mtdnr);
183 if (IS_ERR(mtd)) {
184 D1(printk(KERN_DEBUG "jffs2: MTD device #%u doesn't appear to exist\n", mtdnr));
185 return PTR_ERR(mtd);
186 }
187
188 return jffs2_get_sb_mtd(fs_type, flags, dev_name, data, mtd, mnt);
189} 113}
190 114
191static int jffs2_get_sb(struct file_system_type *fs_type, 115static int jffs2_get_sb(struct file_system_type *fs_type,
192 int flags, const char *dev_name, 116 int flags, const char *dev_name,
193 void *data, struct vfsmount *mnt) 117 void *data, struct vfsmount *mnt)
194{ 118{
195 int err; 119 return get_sb_mtd(fs_type, flags, dev_name, data, jffs2_fill_super,
196 struct nameidata nd; 120 mnt);
197 int mtdnr;
198
199 if (!dev_name)
200 return -EINVAL;
201
202 D1(printk(KERN_DEBUG "jffs2_get_sb(): dev_name \"%s\"\n", dev_name));
203
204 /* The preferred way of mounting in future; especially when
205 CONFIG_BLK_DEV is implemented - we specify the underlying
206 MTD device by number or by name, so that we don't require
207 block device support to be present in the kernel. */
208
209 /* FIXME: How to do the root fs this way? */
210
211 if (dev_name[0] == 'm' && dev_name[1] == 't' && dev_name[2] == 'd') {
212 /* Probably mounting without the blkdev crap */
213 if (dev_name[3] == ':') {
214 struct mtd_info *mtd;
215
216 /* Mount by MTD device name */
217 D1(printk(KERN_DEBUG "jffs2_get_sb(): mtd:%%s, name \"%s\"\n", dev_name+4));
218 for (mtdnr = 0; mtdnr < MAX_MTD_DEVICES; mtdnr++) {
219 mtd = get_mtd_device(NULL, mtdnr);
220 if (!IS_ERR(mtd)) {
221 if (!strcmp(mtd->name, dev_name+4))
222 return jffs2_get_sb_mtd(fs_type, flags, dev_name, data, mtd, mnt);
223 put_mtd_device(mtd);
224 }
225 }
226 printk(KERN_NOTICE "jffs2_get_sb(): MTD device with name \"%s\" not found.\n", dev_name+4);
227 } else if (isdigit(dev_name[3])) {
228 /* Mount by MTD device number name */
229 char *endptr;
230
231 mtdnr = simple_strtoul(dev_name+3, &endptr, 0);
232 if (!*endptr) {
233 /* It was a valid number */
234 D1(printk(KERN_DEBUG "jffs2_get_sb(): mtd%%d, mtdnr %d\n", mtdnr));
235 return jffs2_get_sb_mtdnr(fs_type, flags, dev_name, data, mtdnr, mnt);
236 }
237 }
238 }
239
240 /* Try the old way - the hack where we allowed users to mount
241 /dev/mtdblock$(n) but didn't actually _use_ the blkdev */
242
243 err = path_lookup(dev_name, LOOKUP_FOLLOW, &nd);
244
245 D1(printk(KERN_DEBUG "jffs2_get_sb(): path_lookup() returned %d, inode %p\n",
246 err, nd.dentry->d_inode));
247
248 if (err)
249 return err;
250
251 err = -EINVAL;
252
253 if (!S_ISBLK(nd.dentry->d_inode->i_mode))
254 goto out;
255
256 if (nd.mnt->mnt_flags & MNT_NODEV) {
257 err = -EACCES;
258 goto out;
259 }
260
261 if (imajor(nd.dentry->d_inode) != MTD_BLOCK_MAJOR) {
262 if (!(flags & MS_SILENT))
263 printk(KERN_NOTICE "Attempt to mount non-MTD device \"%s\" as JFFS2\n",
264 dev_name);
265 goto out;
266 }
267
268 mtdnr = iminor(nd.dentry->d_inode);
269 path_release(&nd);
270
271 return jffs2_get_sb_mtdnr(fs_type, flags, dev_name, data, mtdnr, mnt);
272
273out:
274 path_release(&nd);
275 return err;
276} 121}
277 122
278static void jffs2_put_super (struct super_block *sb) 123static void jffs2_put_super (struct super_block *sb)
@@ -307,8 +152,7 @@ static void jffs2_kill_sb(struct super_block *sb)
307 struct jffs2_sb_info *c = JFFS2_SB_INFO(sb); 152 struct jffs2_sb_info *c = JFFS2_SB_INFO(sb);
308 if (!(sb->s_flags & MS_RDONLY)) 153 if (!(sb->s_flags & MS_RDONLY))
309 jffs2_stop_garbage_collect_thread(c); 154 jffs2_stop_garbage_collect_thread(c);
310 generic_shutdown_super(sb); 155 kill_mtd_super(sb);
311 put_mtd_device(c->mtd);
312 kfree(c); 156 kfree(c);
313} 157}
314 158
diff --git a/fs/jffs2/xattr.c b/fs/jffs2/xattr.c
index 78fc08893a6c..e48665984cb3 100644
--- a/fs/jffs2/xattr.c
+++ b/fs/jffs2/xattr.c
@@ -754,6 +754,10 @@ void jffs2_clear_xattr_subsystem(struct jffs2_sb_info *c)
754 list_del(&xd->xindex); 754 list_del(&xd->xindex);
755 jffs2_free_xattr_datum(xd); 755 jffs2_free_xattr_datum(xd);
756 } 756 }
757 list_for_each_entry_safe(xd, _xd, &c->xattr_unchecked, xindex) {
758 list_del(&xd->xindex);
759 jffs2_free_xattr_datum(xd);
760 }
757} 761}
758 762
759#define XREF_TMPHASH_SIZE (128) 763#define XREF_TMPHASH_SIZE (128)
@@ -825,7 +829,7 @@ void jffs2_build_xattr_subsystem(struct jffs2_sb_info *c)
825 ref->xd and ref->ic are not valid yet. */ 829 ref->xd and ref->ic are not valid yet. */
826 xd = jffs2_find_xattr_datum(c, ref->xid); 830 xd = jffs2_find_xattr_datum(c, ref->xid);
827 ic = jffs2_get_ino_cache(c, ref->ino); 831 ic = jffs2_get_ino_cache(c, ref->ino);
828 if (!xd || !ic) { 832 if (!xd || !ic || !ic->nlink) {
829 dbg_xattr("xref(ino=%u, xid=%u, xseqno=%u) is orphan.\n", 833 dbg_xattr("xref(ino=%u, xid=%u, xseqno=%u) is orphan.\n",
830 ref->ino, ref->xid, ref->xseqno); 834 ref->ino, ref->xid, ref->xseqno);
831 ref->xseqno |= XREF_DELETE_MARKER; 835 ref->xseqno |= XREF_DELETE_MARKER;
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 7cf0c54a46a7..b3ae77cccbb6 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -938,6 +938,7 @@ struct super_block {
938 struct list_head s_files; 938 struct list_head s_files;
939 939
940 struct block_device *s_bdev; 940 struct block_device *s_bdev;
941 struct mtd_info *s_mtd;
941 struct list_head s_instances; 942 struct list_head s_instances;
942 struct quota_info s_dquot; /* Diskquota specific options */ 943 struct quota_info s_dquot; /* Diskquota specific options */
943 944
diff --git a/include/linux/mtd/super.h b/include/linux/mtd/super.h
new file mode 100644
index 000000000000..4016dd6fe336
--- /dev/null
+++ b/include/linux/mtd/super.h
@@ -0,0 +1,30 @@
1/* MTD-based superblock handling
2 *
3 * Copyright © 2006 Red Hat, Inc. All Rights Reserved.
4 * Written by David Howells (dhowells@redhat.com)
5 *
6 * This program is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU General Public License
8 * as published by the Free Software Foundation; either version
9 * 2 of the License, or (at your option) any later version.
10 */
11
12#ifndef __MTD_SUPER_H__
13#define __MTD_SUPER_H__
14
15#ifdef __KERNEL__
16
17#include <linux/mtd/mtd.h>
18#include <linux/fs.h>
19#include <linux/mount.h>
20
21extern int get_sb_mtd(struct file_system_type *fs_type, int flags,
22 const char *dev_name, void *data,
23 int (*fill_super)(struct super_block *, void *, int),
24 struct vfsmount *mnt);
25extern void kill_mtd_super(struct super_block *sb);
26
27
28#endif /* __KERNEL__ */
29
30#endif /* __MTD_SUPER_H__ */