diff options
author | Eric Sesterhenn <snakebyte@gmx.de> | 2006-03-31 18:27:08 -0500 |
---|---|---|
committer | Adrian Bunk <bunk@stusta.de> | 2006-03-31 18:27:08 -0500 |
commit | e048a8a688f07b17dbde9a96cab3759b900eae14 (patch) | |
tree | 91d3d65d18e70a6831de44b1b65296ba34df9508 | |
parent | 5aae277ed67b0271235d3a50908bb48b0e59be26 (diff) |
BUG_ON() Conversion in drivers/s390/block/dasd_erp.c
this changes if() BUG(); constructs to BUG_ON() which is
cleaner, contains unlikely() and can better optimized away.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
-rw-r--r-- | drivers/s390/block/dasd_erp.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/s390/block/dasd_erp.c b/drivers/s390/block/dasd_erp.c index 8fd71ab02ef0..b842377cb0c6 100644 --- a/drivers/s390/block/dasd_erp.c +++ b/drivers/s390/block/dasd_erp.c | |||
@@ -32,9 +32,8 @@ dasd_alloc_erp_request(char *magic, int cplength, int datasize, | |||
32 | int size; | 32 | int size; |
33 | 33 | ||
34 | /* Sanity checks */ | 34 | /* Sanity checks */ |
35 | if ( magic == NULL || datasize > PAGE_SIZE || | 35 | BUG_ON( magic == NULL || datasize > PAGE_SIZE || |
36 | (cplength*sizeof(struct ccw1)) > PAGE_SIZE) | 36 | (cplength*sizeof(struct ccw1)) > PAGE_SIZE); |
37 | BUG(); | ||
38 | 37 | ||
39 | size = (sizeof(struct dasd_ccw_req) + 7L) & -8L; | 38 | size = (sizeof(struct dasd_ccw_req) + 7L) & -8L; |
40 | if (cplength > 0) | 39 | if (cplength > 0) |
@@ -125,8 +124,7 @@ dasd_default_erp_postaction(struct dasd_ccw_req * cqr) | |||
125 | struct dasd_device *device; | 124 | struct dasd_device *device; |
126 | int success; | 125 | int success; |
127 | 126 | ||
128 | if (cqr->refers == NULL || cqr->function == NULL) | 127 | BUG_ON(cqr->refers == NULL || cqr->function == NULL); |
129 | BUG(); | ||
130 | 128 | ||
131 | device = cqr->device; | 129 | device = cqr->device; |
132 | success = cqr->status == DASD_CQR_DONE; | 130 | success = cqr->status == DASD_CQR_DONE; |