aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2008-05-12 16:34:13 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2008-05-12 16:34:13 -0400
commitc714a534d85576af21b06be605ca55cb2fb887ee (patch)
tree2d0501e6426b9e069082fd6f09da02c2334832e0
parent542dafadd81eb5826280f7714592930144ae3e1f (diff)
Make 'cond_resched()' nullification depend on PREEMPT_BKL
Because it's not correct with a non-preemptable BKL and just causes PREEMPT kernels to have longer latencies than non-PREEMPT ones (which is obviously not the point of it at all). Of course, that config option actually got removed as an option earlier, so for now this basically disables it entirely, but if BKL preemption is ever resurrected it will be a meaningful optimization. And in the meantime, it at least documents the intent of the code, while not doing the wrong thing. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--include/linux/sched.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 5a63f2d72af6..5395a6176f4b 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -2038,7 +2038,7 @@ static inline int need_resched(void)
2038 * cond_resched_softirq() will enable bhs before scheduling. 2038 * cond_resched_softirq() will enable bhs before scheduling.
2039 */ 2039 */
2040extern int _cond_resched(void); 2040extern int _cond_resched(void);
2041#ifdef CONFIG_PREEMPT 2041#ifdef CONFIG_PREEMPT_BKL
2042static inline int cond_resched(void) 2042static inline int cond_resched(void)
2043{ 2043{
2044 return 0; 2044 return 0;