diff options
author | Jiri Olsa <jolsa@redhat.com> | 2012-06-11 09:20:03 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-06-19 12:06:21 -0400 |
commit | a9c34a9f9c677fcbe06bd3eda8d6caa3487b4a65 (patch) | |
tree | 6214ccb28df7e2ddce0cca32942447544a8b4b09 | |
parent | 6eef3d9c2bcf52b7a3c18e609f5838c007b989a4 (diff) |
perf tools: Remove unused evsel parameter from machine__resolve_callchain
Removing unused evsel parameter from machine__resolve_callchain
function. Plus related header file and callers changes.
The evsel parameter is unused since following commit:
perf callchain: Make callchain cursors TLS
commit 472606458f3e1ced5fe3cc5f04e90a6b5a4732cf
Author: Namhyung Kim <namhyung.kim@lge.com>
Date: Thu May 31 14:43:26 2012 +0900
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Arun Sharma <asharma@fb.com>
Cc: Benjamin Redelings <benjamin.redelings@nescent.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Frank Ch. Eigler <fche@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
Cc: Ulrich Drepper <drepper@gmail.com>
Link: http://lkml.kernel.org/r/1339420814-7379-9-git-send-email-jolsa@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/builtin-report.c | 4 | ||||
-rw-r--r-- | tools/perf/builtin-script.c | 4 | ||||
-rw-r--r-- | tools/perf/builtin-top.c | 2 | ||||
-rw-r--r-- | tools/perf/util/map.h | 2 | ||||
-rw-r--r-- | tools/perf/util/session.c | 7 | ||||
-rw-r--r-- | tools/perf/util/session.h | 4 |
6 files changed, 11 insertions, 12 deletions
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index ea8ce8e1c0d8..40b0ffc3ad3b 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c | |||
@@ -69,7 +69,7 @@ static int perf_report__add_branch_hist_entry(struct perf_tool *tool, | |||
69 | 69 | ||
70 | if ((sort__has_parent || symbol_conf.use_callchain) | 70 | if ((sort__has_parent || symbol_conf.use_callchain) |
71 | && sample->callchain) { | 71 | && sample->callchain) { |
72 | err = machine__resolve_callchain(machine, evsel, al->thread, | 72 | err = machine__resolve_callchain(machine, al->thread, |
73 | sample->callchain, &parent); | 73 | sample->callchain, &parent); |
74 | if (err) | 74 | if (err) |
75 | return err; | 75 | return err; |
@@ -140,7 +140,7 @@ static int perf_evsel__add_hist_entry(struct perf_evsel *evsel, | |||
140 | struct hist_entry *he; | 140 | struct hist_entry *he; |
141 | 141 | ||
142 | if ((sort__has_parent || symbol_conf.use_callchain) && sample->callchain) { | 142 | if ((sort__has_parent || symbol_conf.use_callchain) && sample->callchain) { |
143 | err = machine__resolve_callchain(machine, evsel, al->thread, | 143 | err = machine__resolve_callchain(machine, al->thread, |
144 | sample->callchain, &parent); | 144 | sample->callchain, &parent); |
145 | if (err) | 145 | if (err) |
146 | return err; | 146 | return err; |
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c index 8f9f9b6140db..8fecd3b8130a 100644 --- a/tools/perf/builtin-script.c +++ b/tools/perf/builtin-script.c | |||
@@ -389,7 +389,7 @@ static void print_sample_bts(union perf_event *event, | |||
389 | printf(" "); | 389 | printf(" "); |
390 | else | 390 | else |
391 | printf("\n"); | 391 | printf("\n"); |
392 | perf_event__print_ip(event, sample, machine, evsel, | 392 | perf_event__print_ip(event, sample, machine, |
393 | PRINT_FIELD(SYM), PRINT_FIELD(DSO), | 393 | PRINT_FIELD(SYM), PRINT_FIELD(DSO), |
394 | PRINT_FIELD(SYMOFFSET)); | 394 | PRINT_FIELD(SYMOFFSET)); |
395 | } | 395 | } |
@@ -433,7 +433,7 @@ static void process_event(union perf_event *event __unused, | |||
433 | printf(" "); | 433 | printf(" "); |
434 | else | 434 | else |
435 | printf("\n"); | 435 | printf("\n"); |
436 | perf_event__print_ip(event, sample, machine, evsel, | 436 | perf_event__print_ip(event, sample, machine, |
437 | PRINT_FIELD(SYM), PRINT_FIELD(DSO), | 437 | PRINT_FIELD(SYM), PRINT_FIELD(DSO), |
438 | PRINT_FIELD(SYMOFFSET)); | 438 | PRINT_FIELD(SYMOFFSET)); |
439 | } | 439 | } |
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 8090a280578c..e3cab5f088f8 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c | |||
@@ -774,7 +774,7 @@ static void perf_event__process_sample(struct perf_tool *tool, | |||
774 | 774 | ||
775 | if ((sort__has_parent || symbol_conf.use_callchain) && | 775 | if ((sort__has_parent || symbol_conf.use_callchain) && |
776 | sample->callchain) { | 776 | sample->callchain) { |
777 | err = machine__resolve_callchain(machine, evsel, al.thread, | 777 | err = machine__resolve_callchain(machine, al.thread, |
778 | sample->callchain, &parent); | 778 | sample->callchain, &parent); |
779 | if (err) | 779 | if (err) |
780 | return; | 780 | return; |
diff --git a/tools/perf/util/map.h b/tools/perf/util/map.h index 81371bad4ef0..c14c665d9a25 100644 --- a/tools/perf/util/map.h +++ b/tools/perf/util/map.h | |||
@@ -157,7 +157,7 @@ void machine__exit(struct machine *self); | |||
157 | void machine__delete(struct machine *self); | 157 | void machine__delete(struct machine *self); |
158 | 158 | ||
159 | int machine__resolve_callchain(struct machine *machine, | 159 | int machine__resolve_callchain(struct machine *machine, |
160 | struct perf_evsel *evsel, struct thread *thread, | 160 | struct thread *thread, |
161 | struct ip_callchain *chain, | 161 | struct ip_callchain *chain, |
162 | struct symbol **parent); | 162 | struct symbol **parent); |
163 | int maps__set_kallsyms_ref_reloc_sym(struct map **maps, const char *symbol_name, | 163 | int maps__set_kallsyms_ref_reloc_sym(struct map **maps, const char *symbol_name, |
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 582ee38ed216..febc0aeb3c66 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c | |||
@@ -289,7 +289,6 @@ struct branch_info *machine__resolve_bstack(struct machine *self, | |||
289 | } | 289 | } |
290 | 290 | ||
291 | int machine__resolve_callchain(struct machine *self, | 291 | int machine__resolve_callchain(struct machine *self, |
292 | struct perf_evsel *evsel __used, | ||
293 | struct thread *thread, | 292 | struct thread *thread, |
294 | struct ip_callchain *chain, | 293 | struct ip_callchain *chain, |
295 | struct symbol **parent) | 294 | struct symbol **parent) |
@@ -1480,8 +1479,8 @@ struct perf_evsel *perf_session__find_first_evtype(struct perf_session *session, | |||
1480 | } | 1479 | } |
1481 | 1480 | ||
1482 | void perf_event__print_ip(union perf_event *event, struct perf_sample *sample, | 1481 | void perf_event__print_ip(union perf_event *event, struct perf_sample *sample, |
1483 | struct machine *machine, struct perf_evsel *evsel, | 1482 | struct machine *machine, int print_sym, |
1484 | int print_sym, int print_dso, int print_symoffset) | 1483 | int print_dso, int print_symoffset) |
1485 | { | 1484 | { |
1486 | struct addr_location al; | 1485 | struct addr_location al; |
1487 | struct callchain_cursor_node *node; | 1486 | struct callchain_cursor_node *node; |
@@ -1495,7 +1494,7 @@ void perf_event__print_ip(union perf_event *event, struct perf_sample *sample, | |||
1495 | 1494 | ||
1496 | if (symbol_conf.use_callchain && sample->callchain) { | 1495 | if (symbol_conf.use_callchain && sample->callchain) { |
1497 | 1496 | ||
1498 | if (machine__resolve_callchain(machine, evsel, al.thread, | 1497 | if (machine__resolve_callchain(machine, al.thread, |
1499 | sample->callchain, NULL) != 0) { | 1498 | sample->callchain, NULL) != 0) { |
1500 | if (verbose) | 1499 | if (verbose) |
1501 | error("Failed to resolve callchain. Skipping\n"); | 1500 | error("Failed to resolve callchain. Skipping\n"); |
diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h index 7a5434c00565..877d78186f2c 100644 --- a/tools/perf/util/session.h +++ b/tools/perf/util/session.h | |||
@@ -150,8 +150,8 @@ struct perf_evsel *perf_session__find_first_evtype(struct perf_session *session, | |||
150 | unsigned int type); | 150 | unsigned int type); |
151 | 151 | ||
152 | void perf_event__print_ip(union perf_event *event, struct perf_sample *sample, | 152 | void perf_event__print_ip(union perf_event *event, struct perf_sample *sample, |
153 | struct machine *machine, struct perf_evsel *evsel, | 153 | struct machine *machine, int print_sym, |
154 | int print_sym, int print_dso, int print_symoffset); | 154 | int print_dso, int print_symoffset); |
155 | 155 | ||
156 | int perf_session__cpu_bitmap(struct perf_session *session, | 156 | int perf_session__cpu_bitmap(struct perf_session *session, |
157 | const char *cpu_list, unsigned long *cpu_bitmap); | 157 | const char *cpu_list, unsigned long *cpu_bitmap); |