diff options
| author | Li Zefan <lizefan@huawei.com> | 2013-01-24 01:32:02 -0500 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2013-01-24 15:05:18 -0500 |
| commit | 9ed8a659703876a9fe96ab86d1b296c2f0084242 (patch) | |
| tree | 03db3def6303814681f19412c524b3951ccde242 | |
| parent | be44562613851235d801d41d5b3976dc4333f622 (diff) | |
cgroup: remove bogus comments in cgroup_diput()
Since commit 48ddbe194623ae089cc0576e60363f2d2e85662a
("cgroup: make css->refcnt clearing on cgroup removal optional"),
each css holds a ref on cgroup's dentry, so cgroup_diput() won't be
called until all css' refs go down to 0, which invalids the comments.
Signed-off-by: Li Zefan <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
| -rw-r--r-- | kernel/cgroup.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/kernel/cgroup.c b/kernel/cgroup.c index 02e4f201472e..800852282c21 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c | |||
| @@ -899,12 +899,6 @@ static void cgroup_diput(struct dentry *dentry, struct inode *inode) | |||
| 899 | struct cgroup *cgrp = dentry->d_fsdata; | 899 | struct cgroup *cgrp = dentry->d_fsdata; |
| 900 | 900 | ||
| 901 | BUG_ON(!(cgroup_is_removed(cgrp))); | 901 | BUG_ON(!(cgroup_is_removed(cgrp))); |
| 902 | /* It's possible for external users to be holding css | ||
| 903 | * reference counts on a cgroup; css_put() needs to | ||
| 904 | * be able to access the cgroup after decrementing | ||
| 905 | * the reference count in order to know if it needs to | ||
| 906 | * queue the cgroup to be handled by the release | ||
| 907 | * agent */ | ||
| 908 | call_rcu(&cgrp->rcu_head, cgroup_free_rcu); | 902 | call_rcu(&cgrp->rcu_head, cgroup_free_rcu); |
| 909 | } else { | 903 | } else { |
| 910 | struct cfent *cfe = __d_cfe(dentry); | 904 | struct cfent *cfe = __d_cfe(dentry); |
