diff options
| author | David Milburn <dmilburn@redhat.com> | 2012-09-12 15:06:12 -0400 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2012-09-12 16:21:13 -0400 |
| commit | 97651ea687d3b6a214c32b49f79523db709fba18 (patch) | |
| tree | afa8a69225ba8fd88b4aabe245da6bcb84821868 | |
| parent | ac64e6572d3906c3874175cf5345a37dc7f983f5 (diff) | |
mtip32xx: fix user_buffer check in exec_drive_command
Current user_buffer check is incorrect and causes hdparm to fail
# hdparm -I /dev/rssda
HDIO_DRIVE_CMD(identify) failed: Input/output error
/dev/rssda:
Patching linux-3.6-rc5 hdparm works as expected
# hdparm -I /dev/rssda
/dev/rssda:
ATA device, with non-removable media
Model Number: DELL_P320h-MTFDGAL350SAH
Serial Number: 00000000121302025F01
Firmware Revision: B1442808
<snip>
Reported-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: David Milburn <dmilburn@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | drivers/block/mtip32xx/mtip32xx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c index e6519e2c9934..f946d31d6917 100644 --- a/drivers/block/mtip32xx/mtip32xx.c +++ b/drivers/block/mtip32xx/mtip32xx.c | |||
| @@ -1904,7 +1904,7 @@ static int exec_drive_command(struct mtip_port *port, u8 *command, | |||
| 1904 | int rv = 0, xfer_sz = command[3]; | 1904 | int rv = 0, xfer_sz = command[3]; |
| 1905 | 1905 | ||
| 1906 | if (xfer_sz) { | 1906 | if (xfer_sz) { |
| 1907 | if (user_buffer) | 1907 | if (!user_buffer) |
| 1908 | return -EFAULT; | 1908 | return -EFAULT; |
| 1909 | 1909 | ||
| 1910 | buf = dmam_alloc_coherent(&port->dd->pdev->dev, | 1910 | buf = dmam_alloc_coherent(&port->dd->pdev->dev, |