diff options
author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-20 19:53:19 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-23 19:49:16 -0400 |
commit | 923faa6a8cc80ceff89214efbccce1497118ceed (patch) | |
tree | 84b0601abcdee1e882d683077cfca8ac6b494933 | |
parent | 151373aaff439ab4b1ff7f43cff2cbdd9f4a94f5 (diff) |
staging: comedi: dt9812.c: remove err() usage
err() was a very old USB-specific macro that I thought had
gone away. This patch removes it from being used in the
driver and uses dev_err() instead.
CC: Ian Abbott <abbotti@mev.co.uk>
CC: Mori Hess <fmhess@users.sourceforge.net>
CC: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/staging/comedi/drivers/dt9812.c | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/drivers/staging/comedi/drivers/dt9812.c b/drivers/staging/comedi/drivers/dt9812.c index 53953c2fb715..89a49dda4482 100644 --- a/drivers/staging/comedi/drivers/dt9812.c +++ b/drivers/staging/comedi/drivers/dt9812.c | |||
@@ -547,7 +547,7 @@ static void dt9812_configure_gain(struct usb_dt9812 *dev, | |||
547 | rmw->or_value = F020_MASK_ADC0CF_AMP0GN2; | 547 | rmw->or_value = F020_MASK_ADC0CF_AMP0GN2; |
548 | break; | 548 | break; |
549 | default: | 549 | default: |
550 | err("Illegal gain %d\n", gain); | 550 | dev_err(&dev->interface->dev, "Illegal gain %d\n", gain); |
551 | 551 | ||
552 | } | 552 | } |
553 | } | 553 | } |
@@ -715,7 +715,7 @@ static int dt9812_probe(struct usb_interface *interface, | |||
715 | iface_desc = interface->cur_altsetting; | 715 | iface_desc = interface->cur_altsetting; |
716 | 716 | ||
717 | if (iface_desc->desc.bNumEndpoints != 5) { | 717 | if (iface_desc->desc.bNumEndpoints != 5) { |
718 | err("Wrong number of endpoints."); | 718 | dev_err(&interface->dev, "Wrong number of endpoints.\n"); |
719 | retval = -ENODEV; | 719 | retval = -ENODEV; |
720 | goto error; | 720 | goto error; |
721 | } | 721 | } |
@@ -781,22 +781,22 @@ static int dt9812_probe(struct usb_interface *interface, | |||
781 | } | 781 | } |
782 | 782 | ||
783 | if (dt9812_read_info(dev, 1, &dev->vendor, sizeof(dev->vendor)) != 0) { | 783 | if (dt9812_read_info(dev, 1, &dev->vendor, sizeof(dev->vendor)) != 0) { |
784 | err("Failed to read vendor."); | 784 | dev_err(&interface->dev, "Failed to read vendor.\n"); |
785 | retval = -ENODEV; | 785 | retval = -ENODEV; |
786 | goto error; | 786 | goto error; |
787 | } | 787 | } |
788 | if (dt9812_read_info(dev, 3, &dev->product, sizeof(dev->product)) != 0) { | 788 | if (dt9812_read_info(dev, 3, &dev->product, sizeof(dev->product)) != 0) { |
789 | err("Failed to read product."); | 789 | dev_err(&interface->dev, "Failed to read product.\n"); |
790 | retval = -ENODEV; | 790 | retval = -ENODEV; |
791 | goto error; | 791 | goto error; |
792 | } | 792 | } |
793 | if (dt9812_read_info(dev, 5, &dev->device, sizeof(dev->device)) != 0) { | 793 | if (dt9812_read_info(dev, 5, &dev->device, sizeof(dev->device)) != 0) { |
794 | err("Failed to read device."); | 794 | dev_err(&interface->dev, "Failed to read device.\n"); |
795 | retval = -ENODEV; | 795 | retval = -ENODEV; |
796 | goto error; | 796 | goto error; |
797 | } | 797 | } |
798 | if (dt9812_read_info(dev, 7, &dev->serial, sizeof(dev->serial)) != 0) { | 798 | if (dt9812_read_info(dev, 7, &dev->serial, sizeof(dev->serial)) != 0) { |
799 | err("Failed to read serial."); | 799 | dev_err(&interface->dev, "Failed to read serial.\n"); |
800 | retval = -ENODEV; | 800 | retval = -ENODEV; |
801 | goto error; | 801 | goto error; |
802 | } | 802 | } |
@@ -1146,7 +1146,9 @@ static int __init usb_dt9812_init(void) | |||
1146 | result = comedi_driver_register(&dt9812_comedi_driver); | 1146 | result = comedi_driver_register(&dt9812_comedi_driver); |
1147 | if (result) { | 1147 | if (result) { |
1148 | usb_deregister(&dt9812_usb_driver); | 1148 | usb_deregister(&dt9812_usb_driver); |
1149 | err("comedi_driver_register failed. Error number %d", result); | 1149 | printk(KERN_ERR KBUILD_MODNAME |
1150 | ": comedi_driver_register failed. Error number %d\n", | ||
1151 | result); | ||
1150 | } | 1152 | } |
1151 | 1153 | ||
1152 | return result; | 1154 | return result; |