diff options
author | Tejun Heo <htejun@gmail.com> | 2007-02-21 02:36:33 -0500 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2007-02-23 05:37:11 -0500 |
commit | 878d4fedab4e5eba59877b771622856495a92df4 (patch) | |
tree | 51d17e7d2e81b3a979823009f390c7bfcfcd3801 | |
parent | a2bbd0c923708a23c6fcc6bbc492f2eecadc676f (diff) |
libata: fix remaining ap->id
Merge order left libata-acpi and pata_scc with remainling usage of
ap->id. Kill superflous id printing and substitute the remaining ones
with ap->print_id.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
-rw-r--r-- | drivers/ata/libata-acpi.c | 20 | ||||
-rw-r--r-- | drivers/ata/pata_scc.c | 4 |
2 files changed, 10 insertions, 14 deletions
diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c index b4e8be5d292c..1bdf7a2c2743 100644 --- a/drivers/ata/libata-acpi.c +++ b/drivers/ata/libata-acpi.c | |||
@@ -294,9 +294,8 @@ static int do_drive_get_GTF(struct ata_port *ap, int ix, | |||
294 | return 0; | 294 | return 0; |
295 | 295 | ||
296 | if (ata_msg_probe(ap)) | 296 | if (ata_msg_probe(ap)) |
297 | ata_dev_printk(atadev, KERN_DEBUG, | 297 | ata_dev_printk(atadev, KERN_DEBUG, "%s: ENTER: port#: %d\n", |
298 | "%s: ENTER: ap->id: %d, port#: %d\n", | 298 | __FUNCTION__, ap->port_no); |
299 | __FUNCTION__, ap->id, ap->port_no); | ||
300 | 299 | ||
301 | if (!ata_dev_enabled(atadev) || (ap->flags & ATA_FLAG_DISABLED)) { | 300 | if (!ata_dev_enabled(atadev) || (ap->flags & ATA_FLAG_DISABLED)) { |
302 | if (ata_msg_probe(ap)) | 301 | if (ata_msg_probe(ap)) |
@@ -521,9 +520,8 @@ static int do_drive_set_taskfiles(struct ata_port *ap, | |||
521 | struct taskfile_array *gtf; | 520 | struct taskfile_array *gtf; |
522 | 521 | ||
523 | if (ata_msg_probe(ap)) | 522 | if (ata_msg_probe(ap)) |
524 | ata_dev_printk(atadev, KERN_DEBUG, | 523 | ata_dev_printk(atadev, KERN_DEBUG, "%s: ENTER: port#: %d\n", |
525 | "%s: ENTER: ap->id: %d, port#: %d\n", | 524 | __FUNCTION__, ap->port_no); |
526 | __FUNCTION__, ap->id, ap->port_no); | ||
527 | 525 | ||
528 | if (noacpi || !(ap->cbl == ATA_CBL_SATA)) | 526 | if (noacpi || !(ap->cbl == ATA_CBL_SATA)) |
529 | return 0; | 527 | return 0; |
@@ -627,9 +625,8 @@ int ata_acpi_push_id(struct ata_port *ap, unsigned int ix) | |||
627 | return 0; | 625 | return 0; |
628 | 626 | ||
629 | if (ata_msg_probe(ap)) | 627 | if (ata_msg_probe(ap)) |
630 | ata_dev_printk(atadev, KERN_DEBUG, | 628 | ata_dev_printk(atadev, KERN_DEBUG, "%s: ix = %d, port#: %d\n", |
631 | "%s: ap->id: %d, ix = %d, port#: %d\n", | 629 | __FUNCTION__, ix, ap->port_no); |
632 | __FUNCTION__, ap->id, ix, ap->port_no); | ||
633 | 630 | ||
634 | /* Don't continue if not a SATA device. */ | 631 | /* Don't continue if not a SATA device. */ |
635 | if (!(ap->cbl == ATA_CBL_SATA)) { | 632 | if (!(ap->cbl == ATA_CBL_SATA)) { |
@@ -685,9 +682,8 @@ int ata_acpi_push_id(struct ata_port *ap, unsigned int ix) | |||
685 | if (err < 0) { | 682 | if (err < 0) { |
686 | if (ata_msg_probe(ap)) | 683 | if (ata_msg_probe(ap)) |
687 | ata_dev_printk(atadev, KERN_DEBUG, | 684 | ata_dev_printk(atadev, KERN_DEBUG, |
688 | "ata%u(%u): %s _SDD error: status = 0x%x\n", | 685 | "%s _SDD error: status = 0x%x\n", |
689 | ap->id, ap->device->devno, | 686 | __FUNCTION__, status); |
690 | __FUNCTION__, status); | ||
691 | } | 687 | } |
692 | 688 | ||
693 | /* always return success */ | 689 | /* always return success */ |
diff --git a/drivers/ata/pata_scc.c b/drivers/ata/pata_scc.c index 049a3a284729..de04042f34d3 100644 --- a/drivers/ata/pata_scc.c +++ b/drivers/ata/pata_scc.c | |||
@@ -366,7 +366,7 @@ static void scc_tf_read (struct ata_port *ap, struct ata_taskfile *tf) | |||
366 | static void scc_exec_command (struct ata_port *ap, | 366 | static void scc_exec_command (struct ata_port *ap, |
367 | const struct ata_taskfile *tf) | 367 | const struct ata_taskfile *tf) |
368 | { | 368 | { |
369 | DPRINTK("ata%u: cmd 0x%X\n", ap->id, tf->command); | 369 | DPRINTK("ata%u: cmd 0x%X\n", ap->print_id, tf->command); |
370 | 370 | ||
371 | out_be32(ap->ioaddr.command_addr, tf->command); | 371 | out_be32(ap->ioaddr.command_addr, tf->command); |
372 | ata_pause(ap); | 372 | ata_pause(ap); |
@@ -542,7 +542,7 @@ static unsigned int scc_bus_softreset (struct ata_port *ap, | |||
542 | { | 542 | { |
543 | struct ata_ioports *ioaddr = &ap->ioaddr; | 543 | struct ata_ioports *ioaddr = &ap->ioaddr; |
544 | 544 | ||
545 | DPRINTK("ata%u: bus reset via SRST\n", ap->id); | 545 | DPRINTK("ata%u: bus reset via SRST\n", ap->print_id); |
546 | 546 | ||
547 | /* software reset. causes dev0 to be selected */ | 547 | /* software reset. causes dev0 to be selected */ |
548 | out_be32(ioaddr->ctl_addr, ap->ctl); | 548 | out_be32(ioaddr->ctl_addr, ap->ctl); |