aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike Travis <travis@sgi.com>2008-04-28 05:14:15 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2008-04-28 11:58:31 -0400
commit608dfddd845da5ab6accef70154c8910529699f7 (patch)
tree6480216e8248d79f2e69d3edd4658a99eaf0be13
parent7ae9392c0a3bc01562361bb21e23dfb2e5c81c5a (diff)
oprofile: change cpu_buffer from array to per_cpu variable
Change cpu_buffer from array to per_cpu variable in oprofile functions. [akpm@linux-foundation.org: coding-style fixes] Cc: Philippe Elie <phil.el@wanadoo.fr> Signed-off-by: Mike Travis <travis@sgi.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/oprofile/buffer_sync.c2
-rw-r--r--drivers/oprofile/cpu_buffer.c16
-rw-r--r--drivers/oprofile/cpu_buffer.h3
-rw-r--r--drivers/oprofile/oprofile_stats.c4
4 files changed, 13 insertions, 12 deletions
diff --git a/drivers/oprofile/buffer_sync.c b/drivers/oprofile/buffer_sync.c
index b07ba2a14119..9304c4555079 100644
--- a/drivers/oprofile/buffer_sync.c
+++ b/drivers/oprofile/buffer_sync.c
@@ -491,7 +491,7 @@ typedef enum {
491 */ 491 */
492void sync_buffer(int cpu) 492void sync_buffer(int cpu)
493{ 493{
494 struct oprofile_cpu_buffer * cpu_buf = &cpu_buffer[cpu]; 494 struct oprofile_cpu_buffer *cpu_buf = &per_cpu(cpu_buffer, cpu);
495 struct mm_struct *mm = NULL; 495 struct mm_struct *mm = NULL;
496 struct task_struct * new; 496 struct task_struct * new;
497 unsigned long cookie = 0; 497 unsigned long cookie = 0;
diff --git a/drivers/oprofile/cpu_buffer.c b/drivers/oprofile/cpu_buffer.c
index c93d3d2640ab..efcbf4b4579f 100644
--- a/drivers/oprofile/cpu_buffer.c
+++ b/drivers/oprofile/cpu_buffer.c
@@ -27,7 +27,7 @@
27#include "buffer_sync.h" 27#include "buffer_sync.h"
28#include "oprof.h" 28#include "oprof.h"
29 29
30struct oprofile_cpu_buffer cpu_buffer[NR_CPUS] __cacheline_aligned; 30DEFINE_PER_CPU_SHARED_ALIGNED(struct oprofile_cpu_buffer, cpu_buffer);
31 31
32static void wq_sync_buffer(struct work_struct *work); 32static void wq_sync_buffer(struct work_struct *work);
33 33
@@ -39,7 +39,7 @@ void free_cpu_buffers(void)
39 int i; 39 int i;
40 40
41 for_each_online_cpu(i) 41 for_each_online_cpu(i)
42 vfree(cpu_buffer[i].buffer); 42 vfree(per_cpu(cpu_buffer, i).buffer);
43} 43}
44 44
45int alloc_cpu_buffers(void) 45int alloc_cpu_buffers(void)
@@ -49,7 +49,7 @@ int alloc_cpu_buffers(void)
49 unsigned long buffer_size = fs_cpu_buffer_size; 49 unsigned long buffer_size = fs_cpu_buffer_size;
50 50
51 for_each_online_cpu(i) { 51 for_each_online_cpu(i) {
52 struct oprofile_cpu_buffer * b = &cpu_buffer[i]; 52 struct oprofile_cpu_buffer *b = &per_cpu(cpu_buffer, i);
53 53
54 b->buffer = vmalloc_node(sizeof(struct op_sample) * buffer_size, 54 b->buffer = vmalloc_node(sizeof(struct op_sample) * buffer_size,
55 cpu_to_node(i)); 55 cpu_to_node(i));
@@ -83,7 +83,7 @@ void start_cpu_work(void)
83 work_enabled = 1; 83 work_enabled = 1;
84 84
85 for_each_online_cpu(i) { 85 for_each_online_cpu(i) {
86 struct oprofile_cpu_buffer * b = &cpu_buffer[i]; 86 struct oprofile_cpu_buffer *b = &per_cpu(cpu_buffer, i);
87 87
88 /* 88 /*
89 * Spread the work by 1 jiffy per cpu so they dont all 89 * Spread the work by 1 jiffy per cpu so they dont all
@@ -100,7 +100,7 @@ void end_cpu_work(void)
100 work_enabled = 0; 100 work_enabled = 0;
101 101
102 for_each_online_cpu(i) { 102 for_each_online_cpu(i) {
103 struct oprofile_cpu_buffer * b = &cpu_buffer[i]; 103 struct oprofile_cpu_buffer *b = &per_cpu(cpu_buffer, i);
104 104
105 cancel_delayed_work(&b->work); 105 cancel_delayed_work(&b->work);
106 } 106 }
@@ -227,7 +227,7 @@ static void oprofile_end_trace(struct oprofile_cpu_buffer * cpu_buf)
227void oprofile_add_ext_sample(unsigned long pc, struct pt_regs * const regs, 227void oprofile_add_ext_sample(unsigned long pc, struct pt_regs * const regs,
228 unsigned long event, int is_kernel) 228 unsigned long event, int is_kernel)
229{ 229{
230 struct oprofile_cpu_buffer * cpu_buf = &cpu_buffer[smp_processor_id()]; 230 struct oprofile_cpu_buffer *cpu_buf = &__get_cpu_var(cpu_buffer);
231 231
232 if (!backtrace_depth) { 232 if (!backtrace_depth) {
233 log_sample(cpu_buf, pc, is_kernel, event); 233 log_sample(cpu_buf, pc, is_kernel, event);
@@ -254,13 +254,13 @@ void oprofile_add_sample(struct pt_regs * const regs, unsigned long event)
254 254
255void oprofile_add_pc(unsigned long pc, int is_kernel, unsigned long event) 255void oprofile_add_pc(unsigned long pc, int is_kernel, unsigned long event)
256{ 256{
257 struct oprofile_cpu_buffer * cpu_buf = &cpu_buffer[smp_processor_id()]; 257 struct oprofile_cpu_buffer *cpu_buf = &__get_cpu_var(cpu_buffer);
258 log_sample(cpu_buf, pc, is_kernel, event); 258 log_sample(cpu_buf, pc, is_kernel, event);
259} 259}
260 260
261void oprofile_add_trace(unsigned long pc) 261void oprofile_add_trace(unsigned long pc)
262{ 262{
263 struct oprofile_cpu_buffer * cpu_buf = &cpu_buffer[smp_processor_id()]; 263 struct oprofile_cpu_buffer *cpu_buf = &__get_cpu_var(cpu_buffer);
264 264
265 if (!cpu_buf->tracing) 265 if (!cpu_buf->tracing)
266 return; 266 return;
diff --git a/drivers/oprofile/cpu_buffer.h b/drivers/oprofile/cpu_buffer.h
index c66c025abe75..13588174311d 100644
--- a/drivers/oprofile/cpu_buffer.h
+++ b/drivers/oprofile/cpu_buffer.h
@@ -14,6 +14,7 @@
14#include <linux/spinlock.h> 14#include <linux/spinlock.h>
15#include <linux/workqueue.h> 15#include <linux/workqueue.h>
16#include <linux/cache.h> 16#include <linux/cache.h>
17#include <linux/sched.h>
17 18
18struct task_struct; 19struct task_struct;
19 20
@@ -47,7 +48,7 @@ struct oprofile_cpu_buffer {
47 struct delayed_work work; 48 struct delayed_work work;
48} ____cacheline_aligned; 49} ____cacheline_aligned;
49 50
50extern struct oprofile_cpu_buffer cpu_buffer[]; 51DECLARE_PER_CPU(struct oprofile_cpu_buffer, cpu_buffer);
51 52
52void cpu_buffer_reset(struct oprofile_cpu_buffer * cpu_buf); 53void cpu_buffer_reset(struct oprofile_cpu_buffer * cpu_buf);
53 54
diff --git a/drivers/oprofile/oprofile_stats.c b/drivers/oprofile/oprofile_stats.c
index d1f6d776e9e4..f99b28e7b79a 100644
--- a/drivers/oprofile/oprofile_stats.c
+++ b/drivers/oprofile/oprofile_stats.c
@@ -23,7 +23,7 @@ void oprofile_reset_stats(void)
23 int i; 23 int i;
24 24
25 for_each_possible_cpu(i) { 25 for_each_possible_cpu(i) {
26 cpu_buf = &cpu_buffer[i]; 26 cpu_buf = &per_cpu(cpu_buffer, i);
27 cpu_buf->sample_received = 0; 27 cpu_buf->sample_received = 0;
28 cpu_buf->sample_lost_overflow = 0; 28 cpu_buf->sample_lost_overflow = 0;
29 cpu_buf->backtrace_aborted = 0; 29 cpu_buf->backtrace_aborted = 0;
@@ -49,7 +49,7 @@ void oprofile_create_stats_files(struct super_block * sb, struct dentry * root)
49 return; 49 return;
50 50
51 for_each_possible_cpu(i) { 51 for_each_possible_cpu(i) {
52 cpu_buf = &cpu_buffer[i]; 52 cpu_buf = &per_cpu(cpu_buffer, i);
53 snprintf(buf, 10, "cpu%d", i); 53 snprintf(buf, 10, "cpu%d", i);
54 cpudir = oprofilefs_mkdir(sb, dir, buf); 54 cpudir = oprofilefs_mkdir(sb, dir, buf);
55 55