aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2010-11-09 19:35:20 -0500
committerSteven Whitehouse <swhiteho@redhat.com>2010-11-30 05:30:41 -0500
commit5e69069c1afb655b5f1a154856ccdb4bb7327b81 (patch)
treef6bddfefc266a534b3a2879aa83f2c82ff3b3d81
parent2ae51ed7b548c1d943d080da617515e801ea5c3e (diff)
GFS2: fs/gfs2/glock.c: Use printf extension %pV
Using %pV reduces the number of printk calls and eliminates any possible message interleaving from other printk calls. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
-rw-r--r--fs/gfs2/glock.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index 13155f60b59d..a9b53a48abeb 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -951,17 +951,22 @@ int gfs2_glock_wait(struct gfs2_holder *gh)
951 951
952void gfs2_print_dbg(struct seq_file *seq, const char *fmt, ...) 952void gfs2_print_dbg(struct seq_file *seq, const char *fmt, ...)
953{ 953{
954 struct va_format vaf;
954 va_list args; 955 va_list args;
955 956
956 va_start(args, fmt); 957 va_start(args, fmt);
958
957 if (seq) { 959 if (seq) {
958 struct gfs2_glock_iter *gi = seq->private; 960 struct gfs2_glock_iter *gi = seq->private;
959 vsprintf(gi->string, fmt, args); 961 vsprintf(gi->string, fmt, args);
960 seq_printf(seq, gi->string); 962 seq_printf(seq, gi->string);
961 } else { 963 } else {
962 printk(KERN_ERR " "); 964 vaf.fmt = fmt;
963 vprintk(fmt, args); 965 vaf.va = &args;
966
967 printk(KERN_ERR " %pV", &vaf);
964 } 968 }
969
965 va_end(args); 970 va_end(args);
966} 971}
967 972