aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Paris <eparis@redhat.com>2010-04-07 15:14:27 -0400
committerJames Morris <jmorris@namei.org>2010-04-11 22:18:30 -0400
commit4b61d12c84293ac061909f27f567c1905e4d90e3 (patch)
treedfab10311d1b6be7667600307c72379c6779d32d
parent231923bd0e06cba69f7c2028f4a68602b8d22160 (diff)
security: remove dead hook sb_umount_busy
Unused hook. Remove. Signed-off-by: Eric Paris <eparis@redhat.com> Signed-off-by: James Morris <jmorris@namei.org>
-rw-r--r--fs/namespace.c2
-rw-r--r--include/linux/security.h11
-rw-r--r--security/capability.c5
-rw-r--r--security/security.c5
4 files changed, 0 insertions, 23 deletions
diff --git a/fs/namespace.c b/fs/namespace.c
index 8aea78c8e760..6c9ca7358aad 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1116,8 +1116,6 @@ static int do_umount(struct vfsmount *mnt, int flags)
1116 retval = 0; 1116 retval = 0;
1117 } 1117 }
1118 spin_unlock(&vfsmount_lock); 1118 spin_unlock(&vfsmount_lock);
1119 if (retval)
1120 security_sb_umount_busy(mnt);
1121 up_write(&namespace_sem); 1119 up_write(&namespace_sem);
1122 release_mounts(&umount_list); 1120 release_mounts(&umount_list);
1123 return retval; 1121 return retval;
diff --git a/include/linux/security.h b/include/linux/security.h
index 354b0ceefc87..b206795c09f7 100644
--- a/include/linux/security.h
+++ b/include/linux/security.h
@@ -272,12 +272,6 @@ static inline void security_free_mnt_opts(struct security_mnt_opts *opts)
272 * @mnt contains the mounted file system. 272 * @mnt contains the mounted file system.
273 * @flags contains the unmount flags, e.g. MNT_FORCE. 273 * @flags contains the unmount flags, e.g. MNT_FORCE.
274 * Return 0 if permission is granted. 274 * Return 0 if permission is granted.
275 * @sb_umount_busy:
276 * Handle a failed umount of the @mnt mounted filesystem, e.g. re-opening
277 * any files that were closed by umount_close. This hook is called during
278 * an umount operation if the umount fails after a call to the
279 * umount_close hook.
280 * @mnt contains the mounted filesystem.
281 * @sb_post_remount: 275 * @sb_post_remount:
282 * Update the security module's state when a filesystem is remounted. 276 * Update the security module's state when a filesystem is remounted.
283 * This hook is only called if the remount was successful. 277 * This hook is only called if the remount was successful.
@@ -1474,7 +1468,6 @@ struct security_operations {
1474 int (*sb_mount) (char *dev_name, struct path *path, 1468 int (*sb_mount) (char *dev_name, struct path *path,
1475 char *type, unsigned long flags, void *data); 1469 char *type, unsigned long flags, void *data);
1476 int (*sb_umount) (struct vfsmount *mnt, int flags); 1470 int (*sb_umount) (struct vfsmount *mnt, int flags);
1477 void (*sb_umount_busy) (struct vfsmount *mnt);
1478 void (*sb_post_remount) (struct vfsmount *mnt, 1471 void (*sb_post_remount) (struct vfsmount *mnt,
1479 unsigned long flags, void *data); 1472 unsigned long flags, void *data);
1480 void (*sb_post_addmount) (struct vfsmount *mnt, 1473 void (*sb_post_addmount) (struct vfsmount *mnt,
@@ -1771,7 +1764,6 @@ int security_sb_statfs(struct dentry *dentry);
1771int security_sb_mount(char *dev_name, struct path *path, 1764int security_sb_mount(char *dev_name, struct path *path,
1772 char *type, unsigned long flags, void *data); 1765 char *type, unsigned long flags, void *data);
1773int security_sb_umount(struct vfsmount *mnt, int flags); 1766int security_sb_umount(struct vfsmount *mnt, int flags);
1774void security_sb_umount_busy(struct vfsmount *mnt);
1775void security_sb_post_remount(struct vfsmount *mnt, unsigned long flags, void *data); 1767void security_sb_post_remount(struct vfsmount *mnt, unsigned long flags, void *data);
1776void security_sb_post_addmount(struct vfsmount *mnt, struct path *mountpoint); 1768void security_sb_post_addmount(struct vfsmount *mnt, struct path *mountpoint);
1777int security_sb_pivotroot(struct path *old_path, struct path *new_path); 1769int security_sb_pivotroot(struct path *old_path, struct path *new_path);
@@ -2089,9 +2081,6 @@ static inline int security_sb_umount(struct vfsmount *mnt, int flags)
2089 return 0; 2081 return 0;
2090} 2082}
2091 2083
2092static inline void security_sb_umount_busy(struct vfsmount *mnt)
2093{ }
2094
2095static inline void security_sb_post_remount(struct vfsmount *mnt, 2084static inline void security_sb_post_remount(struct vfsmount *mnt,
2096 unsigned long flags, void *data) 2085 unsigned long flags, void *data)
2097{ } 2086{ }
diff --git a/security/capability.c b/security/capability.c
index db72f4f5a9e1..476d43030906 100644
--- a/security/capability.c
+++ b/security/capability.c
@@ -85,10 +85,6 @@ static int cap_sb_umount(struct vfsmount *mnt, int flags)
85 return 0; 85 return 0;
86} 86}
87 87
88static void cap_sb_umount_busy(struct vfsmount *mnt)
89{
90}
91
92static void cap_sb_post_remount(struct vfsmount *mnt, unsigned long flags, 88static void cap_sb_post_remount(struct vfsmount *mnt, unsigned long flags,
93 void *data) 89 void *data)
94{ 90{
@@ -933,7 +929,6 @@ void security_fixup_ops(struct security_operations *ops)
933 set_to_cap_if_null(ops, sb_statfs); 929 set_to_cap_if_null(ops, sb_statfs);
934 set_to_cap_if_null(ops, sb_mount); 930 set_to_cap_if_null(ops, sb_mount);
935 set_to_cap_if_null(ops, sb_umount); 931 set_to_cap_if_null(ops, sb_umount);
936 set_to_cap_if_null(ops, sb_umount_busy);
937 set_to_cap_if_null(ops, sb_post_remount); 932 set_to_cap_if_null(ops, sb_post_remount);
938 set_to_cap_if_null(ops, sb_post_addmount); 933 set_to_cap_if_null(ops, sb_post_addmount);
939 set_to_cap_if_null(ops, sb_pivotroot); 934 set_to_cap_if_null(ops, sb_pivotroot);
diff --git a/security/security.c b/security/security.c
index 591c25fd430f..c1341fbe98ca 100644
--- a/security/security.c
+++ b/security/security.c
@@ -311,11 +311,6 @@ int security_sb_umount(struct vfsmount *mnt, int flags)
311 return security_ops->sb_umount(mnt, flags); 311 return security_ops->sb_umount(mnt, flags);
312} 312}
313 313
314void security_sb_umount_busy(struct vfsmount *mnt)
315{
316 security_ops->sb_umount_busy(mnt);
317}
318
319void security_sb_post_remount(struct vfsmount *mnt, unsigned long flags, void *data) 314void security_sb_post_remount(struct vfsmount *mnt, unsigned long flags, void *data)
320{ 315{
321 security_ops->sb_post_remount(mnt, flags, data); 316 security_ops->sb_post_remount(mnt, flags, data);