diff options
author | Christian König <deathsimple@vodafone.de> | 2012-06-25 09:13:50 -0400 |
---|---|---|
committer | Christian König <deathsimple@vodafone.de> | 2012-07-17 04:31:47 -0400 |
commit | 35e56bd0a42f06b215741fb94bc8d1e42e946449 (patch) | |
tree | 0eef52828236053f56ebbc83e34a014a06414c83 | |
parent | 7ecc45e3ef8468abb062be2a8bb427029342f42d (diff) |
drm/radeon: add error handling to radeon_vm_unbind_locked
Waiting for a fence can fail for different reasons,
the most common is a deadlock.
Signed-off-by: Christian König <deathsimple@vodafone.de>
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
Reviewed-by: Jerome Glisse <jglisse@redhat.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r-- | drivers/gpu/drm/radeon/radeon_gart.c | 17 |
1 files changed, 14 insertions, 3 deletions
diff --git a/drivers/gpu/drm/radeon/radeon_gart.c b/drivers/gpu/drm/radeon/radeon_gart.c index 2b34c1a91421..ee11c5073726 100644 --- a/drivers/gpu/drm/radeon/radeon_gart.c +++ b/drivers/gpu/drm/radeon/radeon_gart.c | |||
@@ -316,10 +316,21 @@ static void radeon_vm_unbind_locked(struct radeon_device *rdev, | |||
316 | } | 316 | } |
317 | 317 | ||
318 | /* wait for vm use to end */ | 318 | /* wait for vm use to end */ |
319 | if (vm->fence) { | 319 | while (vm->fence) { |
320 | radeon_fence_wait(vm->fence, false); | 320 | int r; |
321 | radeon_fence_unref(&vm->fence); | 321 | r = radeon_fence_wait(vm->fence, false); |
322 | if (r) | ||
323 | DRM_ERROR("error while waiting for fence: %d\n", r); | ||
324 | if (r == -EDEADLK) { | ||
325 | mutex_unlock(&rdev->vm_manager.lock); | ||
326 | r = radeon_gpu_reset(rdev); | ||
327 | mutex_lock(&rdev->vm_manager.lock); | ||
328 | if (!r) | ||
329 | continue; | ||
330 | } | ||
331 | break; | ||
322 | } | 332 | } |
333 | radeon_fence_unref(&vm->fence); | ||
323 | 334 | ||
324 | /* hw unbind */ | 335 | /* hw unbind */ |
325 | rdev->vm_manager.funcs->unbind(rdev, vm); | 336 | rdev->vm_manager.funcs->unbind(rdev, vm); |