aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBorislav Petkov <petkovbb@googlemail.com>2009-01-02 10:12:56 -0500
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2009-01-02 10:12:56 -0500
commit28ad91db77755f1c49d79652de11b28ee2cfbf03 (patch)
tree927c7bc473463c331824cef80bd285e43c4debc7
parent65a3309e552585c4908e50e3c9736afb764c97c0 (diff)
ide-atapi: remove timeout arg to ide_issue_pc
There should be no functionality change resulting from this patch. Signed-off-by: Borislav Petkov <petkovbb@gmail.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
-rw-r--r--drivers/ide/ide-atapi.c7
-rw-r--r--drivers/ide/ide-floppy.c2
-rw-r--r--drivers/ide/ide-tape.c2
-rw-r--r--include/linux/ide.h2
4 files changed, 9 insertions, 4 deletions
diff --git a/drivers/ide/ide-atapi.c b/drivers/ide/ide-atapi.c
index fa7a70a3f24c..c470dbb155ca 100644
--- a/drivers/ide/ide-atapi.c
+++ b/drivers/ide/ide-atapi.c
@@ -562,11 +562,12 @@ static ide_startstop_t ide_transfer_pc(ide_drive_t *drive)
562 return ide_started; 562 return ide_started;
563} 563}
564 564
565ide_startstop_t ide_issue_pc(ide_drive_t *drive, unsigned int timeout) 565ide_startstop_t ide_issue_pc(ide_drive_t *drive)
566{ 566{
567 struct ide_atapi_pc *pc; 567 struct ide_atapi_pc *pc;
568 ide_hwif_t *hwif = drive->hwif; 568 ide_hwif_t *hwif = drive->hwif;
569 ide_expiry_t *expiry = NULL; 569 ide_expiry_t *expiry = NULL;
570 unsigned int timeout;
570 u32 tf_flags; 571 u32 tf_flags;
571 u16 bcount; 572 u16 bcount;
572 573
@@ -574,6 +575,7 @@ ide_startstop_t ide_issue_pc(ide_drive_t *drive, unsigned int timeout)
574 tf_flags = IDE_TFLAG_OUT_NSECT | IDE_TFLAG_OUT_LBAL; 575 tf_flags = IDE_TFLAG_OUT_NSECT | IDE_TFLAG_OUT_LBAL;
575 bcount = ide_cd_get_xferlen(hwif->hwgroup->rq); 576 bcount = ide_cd_get_xferlen(hwif->hwgroup->rq);
576 expiry = ide_cd_expiry; 577 expiry = ide_cd_expiry;
578 timeout = ATAPI_WAIT_PC;
577 579
578 if (drive->dma) 580 if (drive->dma)
579 drive->dma = !hwif->dma_ops->dma_setup(drive); 581 drive->dma = !hwif->dma_ops->dma_setup(drive);
@@ -600,6 +602,9 @@ ide_startstop_t ide_issue_pc(ide_drive_t *drive, unsigned int timeout)
600 602
601 if (!drive->dma) 603 if (!drive->dma)
602 pc->flags &= ~PC_FLAG_DMA_OK; 604 pc->flags &= ~PC_FLAG_DMA_OK;
605
606 timeout = (drive->media == ide_floppy) ? WAIT_FLOPPY_CMD
607 : WAIT_TAPE_CMD;
603 } 608 }
604 609
605 ide_pktcmd_tf_load(drive, tf_flags, bcount, drive->dma); 610 ide_pktcmd_tf_load(drive, tf_flags, bcount, drive->dma);
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index fdec729d0e49..0a48e2dc53a2 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
@@ -197,7 +197,7 @@ static ide_startstop_t idefloppy_issue_pc(ide_drive_t *drive,
197 197
198 pc->retries++; 198 pc->retries++;
199 199
200 return ide_issue_pc(drive, WAIT_FLOPPY_CMD); 200 return ide_issue_pc(drive);
201} 201}
202 202
203void ide_floppy_create_read_capacity_cmd(struct ide_atapi_pc *pc) 203void ide_floppy_create_read_capacity_cmd(struct ide_atapi_pc *pc)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index ac9e29a4991f..5d2aa22cd6e4 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -694,7 +694,7 @@ static ide_startstop_t idetape_issue_pc(ide_drive_t *drive,
694 694
695 pc->retries++; 695 pc->retries++;
696 696
697 return ide_issue_pc(drive, WAIT_TAPE_CMD); 697 return ide_issue_pc(drive);
698} 698}
699 699
700/* A mode sense command is used to "sense" tape parameters. */ 700/* A mode sense command is used to "sense" tape parameters. */
diff --git a/include/linux/ide.h b/include/linux/ide.h
index ad57a4492941..db5ef8ae1ab9 100644
--- a/include/linux/ide.h
+++ b/include/linux/ide.h
@@ -1250,7 +1250,7 @@ int ide_cd_expiry(ide_drive_t *);
1250 1250
1251int ide_cd_get_xferlen(struct request *); 1251int ide_cd_get_xferlen(struct request *);
1252 1252
1253ide_startstop_t ide_issue_pc(ide_drive_t *, unsigned int); 1253ide_startstop_t ide_issue_pc(ide_drive_t *);
1254 1254
1255ide_startstop_t do_rw_taskfile(ide_drive_t *, ide_task_t *); 1255ide_startstop_t do_rw_taskfile(ide_drive_t *, ide_task_t *);
1256 1256