diff options
author | Sjur Braendeland <sjur.brandeland@stericsson.com> | 2010-06-26 07:31:28 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-06-29 03:06:38 -0400 |
commit | 01eebb53a65996dfbfb892bf5eb21ae831fbe3a6 (patch) | |
tree | 958201b54f52778159010d55006c52d00955d654 | |
parent | cfc9b16b75f2cef1e0b283fd2b52ddde568401ab (diff) |
caif: Kconfig and Makefile fixes
Use "depends on" instead of "if" in Kconfig files.
Fixed CAIF debug flag, and removed unnecessary clean-* options.
Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/caif/Kconfig | 5 | ||||
-rw-r--r-- | drivers/net/caif/Makefile | 10 | ||||
-rw-r--r-- | net/caif/Kconfig | 7 | ||||
-rw-r--r-- | net/caif/Makefile | 14 |
4 files changed, 7 insertions, 29 deletions
diff --git a/drivers/net/caif/Kconfig b/drivers/net/caif/Kconfig index 0b28e0107697..6f33ee453f41 100644 --- a/drivers/net/caif/Kconfig +++ b/drivers/net/caif/Kconfig | |||
@@ -2,16 +2,13 @@ | |||
2 | # CAIF physical drivers | 2 | # CAIF physical drivers |
3 | # | 3 | # |
4 | 4 | ||
5 | if CAIF | ||
6 | |||
7 | comment "CAIF transport drivers" | 5 | comment "CAIF transport drivers" |
8 | 6 | ||
9 | config CAIF_TTY | 7 | config CAIF_TTY |
10 | tristate "CAIF TTY transport driver" | 8 | tristate "CAIF TTY transport driver" |
9 | depends on CAIF | ||
11 | default n | 10 | default n |
12 | ---help--- | 11 | ---help--- |
13 | The CAIF TTY transport driver is a Line Discipline (ldisc) | 12 | The CAIF TTY transport driver is a Line Discipline (ldisc) |
14 | identified as N_CAIF. When this ldisc is opened from user space | 13 | identified as N_CAIF. When this ldisc is opened from user space |
15 | it will redirect the TTY's traffic into the CAIF stack. | 14 | it will redirect the TTY's traffic into the CAIF stack. |
16 | |||
17 | endif # CAIF | ||
diff --git a/drivers/net/caif/Makefile b/drivers/net/caif/Makefile index 52b6d1f826f8..e6d3ca06ecfe 100644 --- a/drivers/net/caif/Makefile +++ b/drivers/net/caif/Makefile | |||
@@ -1,12 +1,6 @@ | |||
1 | ifeq ($(CONFIG_CAIF_DEBUG),1) | 1 | ifeq ($(CONFIG_CAIF_DEBUG),y) |
2 | CAIF_DBG_FLAGS := -DDEBUG | 2 | EXTRA_CFLAGS += -DDEBUG |
3 | endif | 3 | endif |
4 | 4 | ||
5 | KBUILD_EXTRA_SYMBOLS=net/caif/Module.symvers | ||
6 | |||
7 | ccflags-y := $(CAIF_FLAGS) $(CAIF_DBG_FLAGS) | ||
8 | clean-dirs:= .tmp_versions | ||
9 | clean-files:= Module.symvers modules.order *.cmd *~ \ | ||
10 | |||
11 | # Serial interface | 5 | # Serial interface |
12 | obj-$(CONFIG_CAIF_TTY) += caif_serial.o | 6 | obj-$(CONFIG_CAIF_TTY) += caif_serial.o |
diff --git a/net/caif/Kconfig b/net/caif/Kconfig index ed651786f16b..529750da9624 100644 --- a/net/caif/Kconfig +++ b/net/caif/Kconfig | |||
@@ -21,19 +21,18 @@ menuconfig CAIF | |||
21 | See Documentation/networking/caif for a further explanation on how to | 21 | See Documentation/networking/caif for a further explanation on how to |
22 | use and configure CAIF. | 22 | use and configure CAIF. |
23 | 23 | ||
24 | if CAIF | ||
25 | |||
26 | config CAIF_DEBUG | 24 | config CAIF_DEBUG |
27 | bool "Enable Debug" | 25 | bool "Enable Debug" |
26 | depends on CAIF | ||
28 | default n | 27 | default n |
29 | --- help --- | 28 | --- help --- |
30 | Enable the inclusion of debug code in the CAIF stack. | 29 | Enable the inclusion of debug code in the CAIF stack. |
31 | Be aware that doing this will impact performance. | 30 | Be aware that doing this will impact performance. |
32 | If unsure say N. | 31 | If unsure say N. |
33 | 32 | ||
34 | |||
35 | config CAIF_NETDEV | 33 | config CAIF_NETDEV |
36 | tristate "CAIF GPRS Network device" | 34 | tristate "CAIF GPRS Network device" |
35 | depends on CAIF | ||
37 | default CAIF | 36 | default CAIF |
38 | ---help--- | 37 | ---help--- |
39 | Say Y if you will be using a CAIF based GPRS network device. | 38 | Say Y if you will be using a CAIF based GPRS network device. |
@@ -41,5 +40,3 @@ config CAIF_NETDEV | |||
41 | If you select to build it as a built-in then the main CAIF device must | 40 | If you select to build it as a built-in then the main CAIF device must |
42 | also be a built-in. | 41 | also be a built-in. |
43 | If unsure say Y. | 42 | If unsure say Y. |
44 | |||
45 | endif | ||
diff --git a/net/caif/Makefile b/net/caif/Makefile index 34852af2595e..f87481fb0e65 100644 --- a/net/caif/Makefile +++ b/net/caif/Makefile | |||
@@ -1,23 +1,13 @@ | |||
1 | ifeq ($(CONFIG_CAIF_DEBUG),1) | 1 | ifeq ($(CONFIG_CAIF_DEBUG),y) |
2 | CAIF_DBG_FLAGS := -DDEBUG | 2 | EXTRA_CFLAGS += -DDEBUG |
3 | endif | 3 | endif |
4 | 4 | ||
5 | ccflags-y := $(CAIF_FLAGS) $(CAIF_DBG_FLAGS) | ||
6 | |||
7 | caif-objs := caif_dev.o \ | 5 | caif-objs := caif_dev.o \ |
8 | cfcnfg.o cfmuxl.o cfctrl.o \ | 6 | cfcnfg.o cfmuxl.o cfctrl.o \ |
9 | cffrml.o cfveil.o cfdbgl.o\ | 7 | cffrml.o cfveil.o cfdbgl.o\ |
10 | cfserl.o cfdgml.o \ | 8 | cfserl.o cfdgml.o \ |
11 | cfrfml.o cfvidl.o cfutill.o \ | 9 | cfrfml.o cfvidl.o cfutill.o \ |
12 | cfsrvl.o cfpkt_skbuff.o caif_config_util.o | 10 | cfsrvl.o cfpkt_skbuff.o caif_config_util.o |
13 | clean-dirs:= .tmp_versions | ||
14 | |||
15 | clean-files:= \ | ||
16 | Module.symvers \ | ||
17 | modules.order \ | ||
18 | *.cmd \ | ||
19 | *.o \ | ||
20 | *~ | ||
21 | 11 | ||
22 | obj-$(CONFIG_CAIF) += caif.o | 12 | obj-$(CONFIG_CAIF) += caif.o |
23 | obj-$(CONFIG_CAIF_NETDEV) += chnl_net.o | 13 | obj-$(CONFIG_CAIF_NETDEV) += chnl_net.o |