diff options
author | Robert P. J. Day <rpjday@crashcourse.ca> | 2008-03-27 10:48:37 -0400 |
---|---|---|
committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2008-04-18 11:55:31 -0400 |
commit | ee2d91e2b3e422f3f61cd7c6a58bd98a5ec72bd1 (patch) | |
tree | f5611d40c458ecdc8812d4b797b4395cc5c83e37 | |
parent | 9508c208aa6e0a7501d8250d4a9d35344056d573 (diff) |
ieee1394: Remove superfluous calls to kobject_set_name().
Unless you're adding a kobject to the sysfs hierarchy, there is no
point setting its kobject name.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
-rw-r--r-- | drivers/ieee1394/dv1394.c | 1 | ||||
-rw-r--r-- | drivers/ieee1394/raw1394.c | 1 | ||||
-rw-r--r-- | drivers/ieee1394/video1394.c | 1 |
3 files changed, 0 insertions, 3 deletions
diff --git a/drivers/ieee1394/dv1394.c b/drivers/ieee1394/dv1394.c index 8c72f360f2d5..6228fadacd38 100644 --- a/drivers/ieee1394/dv1394.c +++ b/drivers/ieee1394/dv1394.c | |||
@@ -2567,7 +2567,6 @@ static int __init dv1394_init_module(void) | |||
2567 | 2567 | ||
2568 | cdev_init(&dv1394_cdev, &dv1394_fops); | 2568 | cdev_init(&dv1394_cdev, &dv1394_fops); |
2569 | dv1394_cdev.owner = THIS_MODULE; | 2569 | dv1394_cdev.owner = THIS_MODULE; |
2570 | kobject_set_name(&dv1394_cdev.kobj, "dv1394"); | ||
2571 | ret = cdev_add(&dv1394_cdev, IEEE1394_DV1394_DEV, 16); | 2570 | ret = cdev_add(&dv1394_cdev, IEEE1394_DV1394_DEV, 16); |
2572 | if (ret) { | 2571 | if (ret) { |
2573 | printk(KERN_ERR "dv1394: unable to register character device\n"); | 2572 | printk(KERN_ERR "dv1394: unable to register character device\n"); |
diff --git a/drivers/ieee1394/raw1394.c b/drivers/ieee1394/raw1394.c index 3634785d3b4b..04e96ba56e09 100644 --- a/drivers/ieee1394/raw1394.c +++ b/drivers/ieee1394/raw1394.c | |||
@@ -3003,7 +3003,6 @@ static int __init init_raw1394(void) | |||
3003 | 3003 | ||
3004 | cdev_init(&raw1394_cdev, &raw1394_fops); | 3004 | cdev_init(&raw1394_cdev, &raw1394_fops); |
3005 | raw1394_cdev.owner = THIS_MODULE; | 3005 | raw1394_cdev.owner = THIS_MODULE; |
3006 | kobject_set_name(&raw1394_cdev.kobj, RAW1394_DEVICE_NAME); | ||
3007 | ret = cdev_add(&raw1394_cdev, IEEE1394_RAW1394_DEV, 1); | 3006 | ret = cdev_add(&raw1394_cdev, IEEE1394_RAW1394_DEV, 1); |
3008 | if (ret) { | 3007 | if (ret) { |
3009 | HPSB_ERR("raw1394 failed to register minor device block"); | 3008 | HPSB_ERR("raw1394 failed to register minor device block"); |
diff --git a/drivers/ieee1394/video1394.c b/drivers/ieee1394/video1394.c index cc240b2e72d9..e03024eeeac1 100644 --- a/drivers/ieee1394/video1394.c +++ b/drivers/ieee1394/video1394.c | |||
@@ -1503,7 +1503,6 @@ static int __init video1394_init_module (void) | |||
1503 | 1503 | ||
1504 | cdev_init(&video1394_cdev, &video1394_fops); | 1504 | cdev_init(&video1394_cdev, &video1394_fops); |
1505 | video1394_cdev.owner = THIS_MODULE; | 1505 | video1394_cdev.owner = THIS_MODULE; |
1506 | kobject_set_name(&video1394_cdev.kobj, VIDEO1394_DRIVER_NAME); | ||
1507 | ret = cdev_add(&video1394_cdev, IEEE1394_VIDEO1394_DEV, 16); | 1506 | ret = cdev_add(&video1394_cdev, IEEE1394_VIDEO1394_DEV, 16); |
1508 | if (ret) { | 1507 | if (ret) { |
1509 | PRINT_G(KERN_ERR, "video1394: unable to get minor device block"); | 1508 | PRINT_G(KERN_ERR, "video1394: unable to get minor device block"); |