aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDave Hansen <haveblue@us.ibm.com>2007-07-18 08:33:51 -0400
committerTheodore Ts'o <tytso@mit.edu>2007-07-18 08:33:51 -0400
commitd699594dc151c664a2b307e680a3cd9b7145fd83 (patch)
tree9b3e50339d09ea5a7786369fda4da6ecf597d4dd
parent1330593eb2d055bdd6ed935886cf2c13c896b288 (diff)
ext4: remove extra IS_RDONLY() check
ext4_change_inode_journal_flag() is only called from one location: ext4_ioctl(EXT3_IOC_SETFLAGS). That ioctl case already has a IS_RDONLY() call in it so this one is superfluous. Signed-off-by: Dave Hansen <haveblue@us.ibm.com> Cc: <linux-ext4@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
-rw-r--r--fs/ext4/inode.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 125aca714685..de26c25d6a18 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -3275,7 +3275,7 @@ int ext4_change_inode_journal_flag(struct inode *inode, int val)
3275 */ 3275 */
3276 3276
3277 journal = EXT4_JOURNAL(inode); 3277 journal = EXT4_JOURNAL(inode);
3278 if (is_journal_aborted(journal) || IS_RDONLY(inode)) 3278 if (is_journal_aborted(journal))
3279 return -EROFS; 3279 return -EROFS;
3280 3280
3281 jbd2_journal_lock_updates(journal); 3281 jbd2_journal_lock_updates(journal);