diff options
author | Márton Németh <nm127@freemail.hu> | 2010-01-10 11:59:22 -0500 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.cz> | 2010-01-12 08:34:43 -0500 |
commit | d67dec5b2cc208215de21dc7806945bf6a6e85d0 (patch) | |
tree | 951b30ef1692664fe05fc75f6ad44f8e9d41e138 | |
parent | 54a6593d65e638ad7e1e8cc986159d76054dab4b (diff) |
HID: make USB device id constant
The id_table field of the struct usb_device_id is constant in <linux/usb.h>
so it is worth to make the initialization data also constant.
The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
struct I1 {
...
const struct I2 *x;
...
};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
struct I1 y = {
.x = E,
};
@c@
identifier r.I2;
identifier s.E;
@@
const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+ const
struct I2 E[] = ...;
// </smpl>
Signed-off-by: Márton Németh <nm127@freemail.hu>
Cc: Julia Lawall <julia@diku.dk>
Cc: cocci@diku.dk
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r-- | drivers/hid/usbhid/hid-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c index 0258289f3b3e..e72751d6e3e7 100644 --- a/drivers/hid/usbhid/hid-core.c +++ b/drivers/hid/usbhid/hid-core.c | |||
@@ -1342,7 +1342,7 @@ static int hid_reset_resume(struct usb_interface *intf) | |||
1342 | 1342 | ||
1343 | #endif /* CONFIG_PM */ | 1343 | #endif /* CONFIG_PM */ |
1344 | 1344 | ||
1345 | static struct usb_device_id hid_usb_ids [] = { | 1345 | static const struct usb_device_id hid_usb_ids[] = { |
1346 | { .match_flags = USB_DEVICE_ID_MATCH_INT_CLASS, | 1346 | { .match_flags = USB_DEVICE_ID_MATCH_INT_CLASS, |
1347 | .bInterfaceClass = USB_INTERFACE_CLASS_HID }, | 1347 | .bInterfaceClass = USB_INTERFACE_CLASS_HID }, |
1348 | { } /* Terminating entry */ | 1348 | { } /* Terminating entry */ |