aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2006-03-13 05:51:19 -0500
committerJeff Garzik <jeff@garzik.org>2006-03-16 19:22:57 -0500
commitc39f5ebe0a542caab30c88e60623709c7bc6fe30 (patch)
tree12e0d5500a6d400a077f3f437cc71a93353dea4a
parent1148c3a78aa9f1e84229cd17f94fd38a15ca65bd (diff)
[PATCH] libata: move IDENTIFY info printing from ata_dev_read_id() to ata_dev_configure()
Move IDENTIFY info printing from ata_dev_read_id() to ata_dev_configure() and print only if @print_info is non-zero. This kills duplicate IDENTIFY info printing during probing. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
-rw-r--r--drivers/scsi/libata-core.c13
1 files changed, 7 insertions, 6 deletions
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index 6fe41fb03929..714b42bad935 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -1120,12 +1120,6 @@ static int ata_dev_read_id(struct ata_port *ap, struct ata_device *dev,
1120 1120
1121 swap_buf_le16(id, ATA_ID_WORDS); 1121 swap_buf_le16(id, ATA_ID_WORDS);
1122 1122
1123 /* print device capabilities */
1124 printk(KERN_DEBUG "ata%u: dev %u cfg "
1125 "49:%04x 82:%04x 83:%04x 84:%04x 85:%04x 86:%04x 87:%04x 88:%04x\n",
1126 ap->id, dev->devno,
1127 id[49], id[82], id[83], id[84], id[85], id[86], id[87], id[88]);
1128
1129 /* sanity check */ 1123 /* sanity check */
1130 if ((class == ATA_DEV_ATA) != ata_id_is_ata(id)) { 1124 if ((class == ATA_DEV_ATA) != ata_id_is_ata(id)) {
1131 rc = -EINVAL; 1125 rc = -EINVAL;
@@ -1205,6 +1199,13 @@ static int ata_dev_configure(struct ata_port *ap, struct ata_device *dev,
1205 1199
1206 DPRINTK("ENTER, host %u, dev %u\n", ap->id, dev->devno); 1200 DPRINTK("ENTER, host %u, dev %u\n", ap->id, dev->devno);
1207 1201
1202 /* print device capabilities */
1203 if (print_info)
1204 printk(KERN_DEBUG "ata%u: dev %u cfg 49:%04x 82:%04x 83:%04x "
1205 "84:%04x 85:%04x 86:%04x 87:%04x 88:%04x\n",
1206 ap->id, dev->devno, id[49], id[82], id[83],
1207 id[84], id[85], id[86], id[87], id[88]);
1208
1208 /* initialize to-be-configured parameters */ 1209 /* initialize to-be-configured parameters */
1209 dev->flags = 0; 1210 dev->flags = 0;
1210 dev->max_sectors = 0; 1211 dev->max_sectors = 0;