aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChuck Lever <chuck.lever@oracle.com>2006-10-20 02:28:42 -0400
committerLinus Torvalds <torvalds@g5.osdl.org>2006-10-20 13:26:39 -0400
commit85233a7a436a48a0b98e7976a66797e5da79c9d6 (patch)
tree3d55b9767194943dd4676e2d84a9e56563f4fed7
parent39cf8a1374dc51fea169190674d5e4996a7d7ea2 (diff)
[PATCH] NFS: __nfs_revalidate_inode() can use "inode" before checking it is non-NULL
The "!inode" check in __nfs_revalidate_inode() occurs well after the first time it is dereferenced, so get rid of it. Coverity: #cid 1372, 1373 Test plan: Code review; recheck with Coverity. Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--fs/nfs/inode.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index 9979ad1cf8eb..08cc4c5919ab 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -583,7 +583,7 @@ __nfs_revalidate_inode(struct nfs_server *server, struct inode *inode)
583 583
584 nfs_inc_stats(inode, NFSIOS_INODEREVALIDATE); 584 nfs_inc_stats(inode, NFSIOS_INODEREVALIDATE);
585 lock_kernel(); 585 lock_kernel();
586 if (!inode || is_bad_inode(inode)) 586 if (is_bad_inode(inode))
587 goto out_nowait; 587 goto out_nowait;
588 if (NFS_STALE(inode)) 588 if (NFS_STALE(inode))
589 goto out_nowait; 589 goto out_nowait;