diff options
| author | Al Viro <viro@www.linux.org.uk> | 2005-08-23 17:47:32 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-08-23 21:43:44 -0400 |
| commit | 0cbdff4f7fc642deb1f36bc035cf60b7bdc497d5 (patch) | |
| tree | 4b7ccdab07948b5a80f28d73cc9ecb04f67c754c | |
| parent | a828b8e4e699b5e3ce0dcbb708ecb099b86f3126 (diff) | |
[PATCH] broken inline asm on s390 (misuse of labels)
use of explicit labels in inline asm is a Bad Idea(tm), since gcc can
decide to inline the function in several places. Fixed by use of 1f/f:
instead of .Lfitsin/.Lfitsin:
Signed-off-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | arch/s390/kernel/cpcmd.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/arch/s390/kernel/cpcmd.c b/arch/s390/kernel/cpcmd.c index 20062145e84e..d47fecb42cc5 100644 --- a/arch/s390/kernel/cpcmd.c +++ b/arch/s390/kernel/cpcmd.c | |||
| @@ -46,9 +46,9 @@ int __cpcmd(const char *cmd, char *response, int rlen, int *response_code) | |||
| 46 | "lra 3,0(%4)\n" | 46 | "lra 3,0(%4)\n" |
| 47 | "lr 5,%5\n" | 47 | "lr 5,%5\n" |
| 48 | "diag 2,4,0x8\n" | 48 | "diag 2,4,0x8\n" |
| 49 | "brc 8, .Litfits\n" | 49 | "brc 8, 1f\n" |
| 50 | "ar 5, %5\n" | 50 | "ar 5, %5\n" |
| 51 | ".Litfits: \n" | 51 | "1: \n" |
| 52 | "lr %0,4\n" | 52 | "lr %0,4\n" |
| 53 | "lr %1,5\n" | 53 | "lr %1,5\n" |
| 54 | : "=d" (return_code), "=d" (return_len) | 54 | : "=d" (return_code), "=d" (return_len) |
| @@ -64,9 +64,9 @@ int __cpcmd(const char *cmd, char *response, int rlen, int *response_code) | |||
| 64 | "sam31\n" | 64 | "sam31\n" |
| 65 | "diag 2,4,0x8\n" | 65 | "diag 2,4,0x8\n" |
| 66 | "sam64\n" | 66 | "sam64\n" |
| 67 | "brc 8, .Litfits\n" | 67 | "brc 8, 1f\n" |
| 68 | "agr 5, %5\n" | 68 | "agr 5, %5\n" |
| 69 | ".Litfits: \n" | 69 | "1: \n" |
| 70 | "lgr %0,4\n" | 70 | "lgr %0,4\n" |
| 71 | "lgr %1,5\n" | 71 | "lgr %1,5\n" |
| 72 | : "=d" (return_code), "=d" (return_len) | 72 | : "=d" (return_code), "=d" (return_len) |