aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Richter <stefanr@s5r6.in-berlin.de>2008-05-31 13:01:26 -0400
committerStefan Richter <stefanr@s5r6.in-berlin.de>2008-06-18 18:12:34 -0400
commit0bf607c5b4edd13362e4add6ca1e81f8a9fbd47c (patch)
treecfd10d0025df679ee525aacfbc7479e8fffe90aa
parent952f4a0a9b27e6dbd5d32e330b3f609ebfa0b061 (diff)
firewire: don't panic on invalid AR request buffer
BUG() at this place is wrong. (Unless if the low level driver would already do higher-level input validation of incoming request headers.) Invalid incoming requests or bugs in the controller which corrupt the AR-req buffer needlessly crashed the box because this is run in tasklet context. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
-rw-r--r--drivers/firewire/fw-transaction.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/firewire/fw-transaction.c b/drivers/firewire/fw-transaction.c
index ccf0e4cf108f..7f92c45349e2 100644
--- a/drivers/firewire/fw-transaction.c
+++ b/drivers/firewire/fw-transaction.c
@@ -572,7 +572,8 @@ allocate_request(struct fw_packet *p)
572 break; 572 break;
573 573
574 default: 574 default:
575 BUG(); 575 fw_error("ERROR - corrupt request received - %08x %08x %08x\n",
576 p->header[0], p->header[1], p->header[2]);
576 return NULL; 577 return NULL;
577 } 578 }
578 579