diff options
author | Eric Dumazet <eric.dumazet@gmail.com> | 2010-03-09 00:55:56 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-03-10 10:32:27 -0500 |
commit | bb134d5d9580fc7b945e3bca3c4b263947022966 (patch) | |
tree | 65f68dd2c96566c507854e4145af1b533e30833d | |
parent | fe234f0e5cbb880792d2d1ac0743cf8c07e9dde3 (diff) |
tcp: Fix tcp_v4_rcv()
Commit d218d111 (tcp: Generalized TTL Security Mechanism) added a bug
for TIMEWAIT sockets. We should not test min_ttl for TW sockets.
Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/ipv4/tcp_ipv4.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index 8d51d39ad1bb..70df40980a87 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c | |||
@@ -1651,15 +1651,15 @@ int tcp_v4_rcv(struct sk_buff *skb) | |||
1651 | if (!sk) | 1651 | if (!sk) |
1652 | goto no_tcp_socket; | 1652 | goto no_tcp_socket; |
1653 | 1653 | ||
1654 | process: | ||
1655 | if (sk->sk_state == TCP_TIME_WAIT) | ||
1656 | goto do_time_wait; | ||
1657 | |||
1654 | if (unlikely(iph->ttl < inet_sk(sk)->min_ttl)) { | 1658 | if (unlikely(iph->ttl < inet_sk(sk)->min_ttl)) { |
1655 | NET_INC_STATS_BH(net, LINUX_MIB_TCPMINTTLDROP); | 1659 | NET_INC_STATS_BH(net, LINUX_MIB_TCPMINTTLDROP); |
1656 | goto discard_and_relse; | 1660 | goto discard_and_relse; |
1657 | } | 1661 | } |
1658 | 1662 | ||
1659 | process: | ||
1660 | if (sk->sk_state == TCP_TIME_WAIT) | ||
1661 | goto do_time_wait; | ||
1662 | |||
1663 | if (!xfrm4_policy_check(sk, XFRM_POLICY_IN, skb)) | 1663 | if (!xfrm4_policy_check(sk, XFRM_POLICY_IN, skb)) |
1664 | goto discard_and_relse; | 1664 | goto discard_and_relse; |
1665 | nf_reset(skb); | 1665 | nf_reset(skb); |