diff options
author | KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> | 2006-03-28 17:50:52 -0500 |
---|---|---|
committer | Paul Mackerras <paulus@samba.org> | 2006-03-28 21:44:16 -0500 |
commit | b848e0a07dd5a874821bb587bb724fac4aa45bad (patch) | |
tree | 43c81d75963421146adb340c6ebb617c426718a1 | |
parent | 0e5519548fdc8eadc3eacb49b1908d44d347fb2b (diff) |
[PATCH] for_each_possible_cpu: ppc
for_each_cpu() actually iterates across all possible CPUs. We've had mistakes
in the past where people were using for_each_cpu() where they should have been
iterating across only online or present CPUs. This is inefficient and
possibly buggy.
We're renaming for_each_cpu() to for_each_possible_cpu() to avoid this in the
future.
This patch replaces for_each_cpu with for_each_possible_cpu.
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
-rw-r--r-- | arch/ppc/kernel/setup.c | 2 | ||||
-rw-r--r-- | arch/ppc/kernel/smp.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/arch/ppc/kernel/setup.c b/arch/ppc/kernel/setup.c index 7eb91a2e818a..1f79e84ab464 100644 --- a/arch/ppc/kernel/setup.c +++ b/arch/ppc/kernel/setup.c | |||
@@ -474,7 +474,7 @@ int __init ppc_init(void) | |||
474 | if ( ppc_md.progress ) ppc_md.progress(" ", 0xffff); | 474 | if ( ppc_md.progress ) ppc_md.progress(" ", 0xffff); |
475 | 475 | ||
476 | /* register CPU devices */ | 476 | /* register CPU devices */ |
477 | for_each_cpu(i) | 477 | for_each_possible_cpu(i) |
478 | register_cpu(&cpu_devices[i], i, NULL); | 478 | register_cpu(&cpu_devices[i], i, NULL); |
479 | 479 | ||
480 | /* call platform init */ | 480 | /* call platform init */ |
diff --git a/arch/ppc/kernel/smp.c b/arch/ppc/kernel/smp.c index e55cdda6149a..f77795a64dae 100644 --- a/arch/ppc/kernel/smp.c +++ b/arch/ppc/kernel/smp.c | |||
@@ -311,7 +311,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus) | |||
311 | /* Backup CPU 0 state */ | 311 | /* Backup CPU 0 state */ |
312 | __save_cpu_setup(); | 312 | __save_cpu_setup(); |
313 | 313 | ||
314 | for_each_cpu(cpu) { | 314 | for_each_possible_cpu(cpu) { |
315 | if (cpu == smp_processor_id()) | 315 | if (cpu == smp_processor_id()) |
316 | continue; | 316 | continue; |
317 | /* create a process for the processor */ | 317 | /* create a process for the processor */ |