diff options
author | Ben Dooks <ben-linux@fluff.org> | 2007-04-20 06:39:46 -0400 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2007-04-21 15:53:23 -0400 |
commit | a7717435656c874843b1742383cc37540f5ff91e (patch) | |
tree | bc66c0e1cbaa5620786fa0e07e1abbbf16ce19c1 | |
parent | 57e5171c9ff817d56344d8473e484d6870ae2bf3 (diff) |
[ARM] 4326/1: S3C24XX: fix sparse errors in DMA code
Fix the following sparse errors in arch/arm/plat-s3c24xx/dma.c:
dma.c:47:30: warning: symbol 'dma_sel' was not declared. Should it be static?
dma.c:883:6: warning: symbol 's3c2410_dma_waitforstop' was not declared. Should it be static?
dma.c:961:1: warning: symbol 's3c2410_dma_started' was not declared. Should it be static?
dma.c:1283:12: warning: symbol 's3c24xx_dma_sysclass_init' was not declared. Should it be static?
dma.c:1295:12: warning: symbol 's3c24xx_dma_sysdev_register' was not declared. Should it be static?
dma.c:1399:25: warning: symbol 's3c2410_dma_map_channel' was not declared. Should it be static?
The patch makes all the relevant functions static.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
-rw-r--r-- | arch/arm/plat-s3c24xx/dma.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index 4540a806f522..6f03c9370979 100644 --- a/arch/arm/plat-s3c24xx/dma.c +++ b/arch/arm/plat-s3c24xx/dma.c | |||
@@ -44,7 +44,7 @@ static struct kmem_cache *dma_kmem; | |||
44 | 44 | ||
45 | static int dma_channels; | 45 | static int dma_channels; |
46 | 46 | ||
47 | struct s3c24xx_dma_selection dma_sel; | 47 | static struct s3c24xx_dma_selection dma_sel; |
48 | 48 | ||
49 | /* dma channel state information */ | 49 | /* dma channel state information */ |
50 | struct s3c2410_dma_chan s3c2410_chans[S3C2410_DMA_CHANNELS]; | 50 | struct s3c2410_dma_chan s3c2410_chans[S3C2410_DMA_CHANNELS]; |
@@ -880,7 +880,7 @@ static int s3c2410_dma_dostop(struct s3c2410_dma_chan *chan) | |||
880 | return 0; | 880 | return 0; |
881 | } | 881 | } |
882 | 882 | ||
883 | void s3c2410_dma_waitforstop(struct s3c2410_dma_chan *chan) | 883 | static void s3c2410_dma_waitforstop(struct s3c2410_dma_chan *chan) |
884 | { | 884 | { |
885 | unsigned long tmp; | 885 | unsigned long tmp; |
886 | unsigned int timeout = 0x10000; | 886 | unsigned int timeout = 0x10000; |
@@ -957,8 +957,7 @@ static int s3c2410_dma_flush(struct s3c2410_dma_chan *chan) | |||
957 | return 0; | 957 | return 0; |
958 | } | 958 | } |
959 | 959 | ||
960 | int | 960 | static int s3c2410_dma_started(struct s3c2410_dma_chan *chan) |
961 | s3c2410_dma_started(struct s3c2410_dma_chan *chan) | ||
962 | { | 961 | { |
963 | unsigned long flags; | 962 | unsigned long flags; |
964 | 963 | ||
@@ -1280,7 +1279,7 @@ static void s3c2410_dma_cache_ctor(void *p, struct kmem_cache *c, unsigned long | |||
1280 | 1279 | ||
1281 | /* initialisation code */ | 1280 | /* initialisation code */ |
1282 | 1281 | ||
1283 | int __init s3c24xx_dma_sysclass_init(void) | 1282 | static int __init s3c24xx_dma_sysclass_init(void) |
1284 | { | 1283 | { |
1285 | int ret = sysdev_class_register(&dma_sysclass); | 1284 | int ret = sysdev_class_register(&dma_sysclass); |
1286 | 1285 | ||
@@ -1292,7 +1291,7 @@ int __init s3c24xx_dma_sysclass_init(void) | |||
1292 | 1291 | ||
1293 | core_initcall(s3c24xx_dma_sysclass_init); | 1292 | core_initcall(s3c24xx_dma_sysclass_init); |
1294 | 1293 | ||
1295 | int __init s3c24xx_dma_sysdev_register(void) | 1294 | static int __init s3c24xx_dma_sysdev_register(void) |
1296 | { | 1295 | { |
1297 | struct s3c2410_dma_chan *cp = s3c2410_chans; | 1296 | struct s3c2410_dma_chan *cp = s3c2410_chans; |
1298 | int channel, ret; | 1297 | int channel, ret; |
@@ -1396,7 +1395,7 @@ static struct s3c24xx_dma_order *dma_order; | |||
1396 | * channel | 1395 | * channel |
1397 | */ | 1396 | */ |
1398 | 1397 | ||
1399 | struct s3c2410_dma_chan *s3c2410_dma_map_channel(int channel) | 1398 | static struct s3c2410_dma_chan *s3c2410_dma_map_channel(int channel) |
1400 | { | 1399 | { |
1401 | struct s3c24xx_dma_order_ch *ord = NULL; | 1400 | struct s3c24xx_dma_order_ch *ord = NULL; |
1402 | struct s3c24xx_dma_map *ch_map; | 1401 | struct s3c24xx_dma_map *ch_map; |