aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRami Rosen <ramirose@gmail.com>2008-12-01 06:56:55 -0500
committerJohn W. Linville <linville@tuxdriver.com>2008-12-05 09:35:46 -0500
commit8e7be8da8ec7cc2828f4434d8d3c2ab4d1d4e7a4 (patch)
treeca1432bd3b4e80c45430a21b77295e6f03c5e327
parent4a4f4d805db5c930ee4185162dcdc8db9a0379d5 (diff)
mac80211: tx module cleanup.
This patch removes unnecessary parameter in ieee80211_beacon_add_tim() and removes unneeded definition and assignment for bdev (instance of net_device) in ieee80211_beacon_get() and in ieee80211_get_buffered_bc() (all in tx.c). Signed-off-by: Rami Rosen <ramirose@gmail.com> Acked-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--net/mac80211/tx.c11
1 files changed, 3 insertions, 8 deletions
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 0d81b2cfd1a6..d7761e95e4cf 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1779,8 +1779,7 @@ void ieee80211_tx_pending(unsigned long data)
1779 1779
1780/* functions for drivers to get certain frames */ 1780/* functions for drivers to get certain frames */
1781 1781
1782static void ieee80211_beacon_add_tim(struct ieee80211_local *local, 1782static void ieee80211_beacon_add_tim(struct ieee80211_if_ap *bss,
1783 struct ieee80211_if_ap *bss,
1784 struct sk_buff *skb, 1783 struct sk_buff *skb,
1785 struct beacon_data *beacon) 1784 struct beacon_data *beacon)
1786{ 1785{
@@ -1848,7 +1847,6 @@ struct sk_buff *ieee80211_beacon_get(struct ieee80211_hw *hw,
1848 struct ieee80211_local *local = hw_to_local(hw); 1847 struct ieee80211_local *local = hw_to_local(hw);
1849 struct sk_buff *skb = NULL; 1848 struct sk_buff *skb = NULL;
1850 struct ieee80211_tx_info *info; 1849 struct ieee80211_tx_info *info;
1851 struct net_device *bdev;
1852 struct ieee80211_sub_if_data *sdata = NULL; 1850 struct ieee80211_sub_if_data *sdata = NULL;
1853 struct ieee80211_if_ap *ap = NULL; 1851 struct ieee80211_if_ap *ap = NULL;
1854 struct ieee80211_if_sta *ifsta = NULL; 1852 struct ieee80211_if_sta *ifsta = NULL;
@@ -1861,7 +1859,6 @@ struct sk_buff *ieee80211_beacon_get(struct ieee80211_hw *hw,
1861 rcu_read_lock(); 1859 rcu_read_lock();
1862 1860
1863 sdata = vif_to_sdata(vif); 1861 sdata = vif_to_sdata(vif);
1864 bdev = sdata->dev;
1865 1862
1866 if (sdata->vif.type == NL80211_IFTYPE_AP) { 1863 if (sdata->vif.type == NL80211_IFTYPE_AP) {
1867 ap = &sdata->u.ap; 1864 ap = &sdata->u.ap;
@@ -1889,12 +1886,12 @@ struct sk_buff *ieee80211_beacon_get(struct ieee80211_hw *hw,
1889 * of the tim bitmap in mac80211 and the driver. 1886 * of the tim bitmap in mac80211 and the driver.
1890 */ 1887 */
1891 if (local->tim_in_locked_section) { 1888 if (local->tim_in_locked_section) {
1892 ieee80211_beacon_add_tim(local, ap, skb, beacon); 1889 ieee80211_beacon_add_tim(ap, skb, beacon);
1893 } else { 1890 } else {
1894 unsigned long flags; 1891 unsigned long flags;
1895 1892
1896 spin_lock_irqsave(&local->sta_lock, flags); 1893 spin_lock_irqsave(&local->sta_lock, flags);
1897 ieee80211_beacon_add_tim(local, ap, skb, beacon); 1894 ieee80211_beacon_add_tim(ap, skb, beacon);
1898 spin_unlock_irqrestore(&local->sta_lock, flags); 1895 spin_unlock_irqrestore(&local->sta_lock, flags);
1899 } 1896 }
1900 1897
@@ -2016,14 +2013,12 @@ ieee80211_get_buffered_bc(struct ieee80211_hw *hw,
2016 struct sk_buff *skb = NULL; 2013 struct sk_buff *skb = NULL;
2017 struct sta_info *sta; 2014 struct sta_info *sta;
2018 struct ieee80211_tx_data tx; 2015 struct ieee80211_tx_data tx;
2019 struct net_device *bdev;
2020 struct ieee80211_sub_if_data *sdata; 2016 struct ieee80211_sub_if_data *sdata;
2021 struct ieee80211_if_ap *bss = NULL; 2017 struct ieee80211_if_ap *bss = NULL;
2022 struct beacon_data *beacon; 2018 struct beacon_data *beacon;
2023 struct ieee80211_tx_info *info; 2019 struct ieee80211_tx_info *info;
2024 2020
2025 sdata = vif_to_sdata(vif); 2021 sdata = vif_to_sdata(vif);
2026 bdev = sdata->dev;
2027 bss = &sdata->u.ap; 2022 bss = &sdata->u.ap;
2028 2023
2029 if (!bss) 2024 if (!bss)