diff options
author | Andi Kleen <ak@linux.intel.com> | 2010-06-01 17:04:40 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-08-10 17:35:35 -0400 |
commit | 6e12ea4658487ba9c746e95b31014cb89f63703b (patch) | |
tree | 03c2e4fed6b1077a02b371ab686c6fb20b9ea0ed | |
parent | 16f76a7654cf603ca13543e4f914ec8b6cd9ffb2 (diff) |
USB-BKL: Remove lock_kernel in usbfs update_sb()
The code this is attempting to lock against does not use the BKL,
so it's not needed.
Most likely this code is still broken/racy (Al Viro also thinks so),
but removing the BKL should not make it worse than before.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | drivers/usb/core/inode.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/usb/core/inode.c b/drivers/usb/core/inode.c index 1a27618b67d6..095fa5366690 100644 --- a/drivers/usb/core/inode.c +++ b/drivers/usb/core/inode.c | |||
@@ -265,13 +265,9 @@ static int remount(struct super_block *sb, int *flags, char *data) | |||
265 | return -EINVAL; | 265 | return -EINVAL; |
266 | } | 266 | } |
267 | 267 | ||
268 | lock_kernel(); | ||
269 | |||
270 | if (usbfs_mount && usbfs_mount->mnt_sb) | 268 | if (usbfs_mount && usbfs_mount->mnt_sb) |
271 | update_sb(usbfs_mount->mnt_sb); | 269 | update_sb(usbfs_mount->mnt_sb); |
272 | 270 | ||
273 | unlock_kernel(); | ||
274 | |||
275 | return 0; | 271 | return 0; |
276 | } | 272 | } |
277 | 273 | ||