diff options
author | Ajit Khaparde <ajitkhaparde@gmail.com> | 2010-02-08 20:32:43 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-02-12 15:27:58 -0500 |
commit | 34a89b8c75abe2873a95524552cc266fdd3b6a85 (patch) | |
tree | fc1af457d8100289e6a5798dcd3902c8a20d89e3 | |
parent | 3f0d4560aedaa67546eaeb3dc75fcdf68ec21036 (diff) |
be2net: bug fix in be_change_mtu
Current code allows the new mtu to cross the supported value.
This patch fixes the boundary checks.
From: Suresh R <sureshr@serverengines.com>
Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/benet/be_main.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c index 99061488eeb3..c65c63427d41 100644 --- a/drivers/net/benet/be_main.c +++ b/drivers/net/benet/be_main.c | |||
@@ -473,10 +473,12 @@ static int be_change_mtu(struct net_device *netdev, int new_mtu) | |||
473 | { | 473 | { |
474 | struct be_adapter *adapter = netdev_priv(netdev); | 474 | struct be_adapter *adapter = netdev_priv(netdev); |
475 | if (new_mtu < BE_MIN_MTU || | 475 | if (new_mtu < BE_MIN_MTU || |
476 | new_mtu > BE_MAX_JUMBO_FRAME_SIZE) { | 476 | new_mtu > (BE_MAX_JUMBO_FRAME_SIZE - |
477 | (ETH_HLEN + ETH_FCS_LEN))) { | ||
477 | dev_info(&adapter->pdev->dev, | 478 | dev_info(&adapter->pdev->dev, |
478 | "MTU must be between %d and %d bytes\n", | 479 | "MTU must be between %d and %d bytes\n", |
479 | BE_MIN_MTU, BE_MAX_JUMBO_FRAME_SIZE); | 480 | BE_MIN_MTU, |
481 | (BE_MAX_JUMBO_FRAME_SIZE - (ETH_HLEN + ETH_FCS_LEN))); | ||
480 | return -EINVAL; | 482 | return -EINVAL; |
481 | } | 483 | } |
482 | dev_info(&adapter->pdev->dev, "MTU changed from %d to %d bytes\n", | 484 | dev_info(&adapter->pdev->dev, "MTU changed from %d to %d bytes\n", |