diff options
author | Holger Schurig <hs4233@mail.mn-solutions.de> | 2007-08-02 11:49:45 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-10-10 19:49:50 -0400 |
commit | c95c7f930ec6fee029c8e7957ab95b3967578070 (patch) | |
tree | 7ab029048d7a62ca0a472fa6e0761d1f3012ba08 | |
parent | ac558ca2ae878bd7a77831cda684702a2fa23d95 (diff) |
[PATCH] libertas: uppercase some #defines
Usually constants defined by #define are in ALL_UPPERCASE. This patch
fixes this.
I also shuffled the bits around so that they match the bit positions in the
host-interrupt-state register of the CF/SDIO card :-)
Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r-- | drivers/net/wireless/libertas/defs.h | 8 | ||||
-rw-r--r-- | drivers/net/wireless/libertas/if_usb.c | 6 | ||||
-rw-r--r-- | drivers/net/wireless/libertas/main.c | 8 |
3 files changed, 12 insertions, 10 deletions
diff --git a/drivers/net/wireless/libertas/defs.h b/drivers/net/wireless/libertas/defs.h index a1c6dae1ba46..eee8a49e358f 100644 --- a/drivers/net/wireless/libertas/defs.h +++ b/drivers/net/wireless/libertas/defs.h | |||
@@ -159,9 +159,11 @@ static inline void lbs_dbg_hex(char *prompt, u8 * buf, int len) | |||
159 | #define MARVELL_MESH_IE_LENGTH 9 | 159 | #define MARVELL_MESH_IE_LENGTH 9 |
160 | 160 | ||
161 | /** INT status Bit Definition*/ | 161 | /** INT status Bit Definition*/ |
162 | #define his_cmddnldrdy 0x01 | 162 | #define MRVDRV_TX_DNLD_RDY 0x0001 |
163 | #define his_cardevent 0x02 | 163 | #define MRVDRV_RX_UPLD_RDY 0x0002 |
164 | #define his_cmdupldrdy 0x04 | 164 | #define MRVDRV_CMD_DNLD_RDY 0x0004 |
165 | #define MRVDRV_CMD_UPLD_RDY 0x0008 | ||
166 | #define MRVDRV_CARDEVENT 0x0010 | ||
165 | 167 | ||
166 | #define SBI_EVENT_CAUSE_SHIFT 3 | 168 | #define SBI_EVENT_CAUSE_SHIFT 3 |
167 | 169 | ||
diff --git a/drivers/net/wireless/libertas/if_usb.c b/drivers/net/wireless/libertas/if_usb.c index c28d9747b865..5efdeac6e208 100644 --- a/drivers/net/wireless/libertas/if_usb.c +++ b/drivers/net/wireless/libertas/if_usb.c | |||
@@ -601,11 +601,11 @@ static inline void process_cmdrequest(int recvlength, u8 *recvbuff, | |||
601 | * data to clear the interrupt */ | 601 | * data to clear the interrupt */ |
602 | if (!priv->adapter->cur_cmd) { | 602 | if (!priv->adapter->cur_cmd) { |
603 | cmdbuf = priv->upld_buf; | 603 | cmdbuf = priv->upld_buf; |
604 | priv->adapter->hisregcpy &= ~his_cmdupldrdy; | 604 | priv->adapter->hisregcpy &= ~MRVDRV_CMD_UPLD_RDY; |
605 | } else | 605 | } else |
606 | cmdbuf = priv->adapter->cur_cmd->bufvirtualaddr; | 606 | cmdbuf = priv->adapter->cur_cmd->bufvirtualaddr; |
607 | 607 | ||
608 | cardp->usb_int_cause |= his_cmdupldrdy; | 608 | cardp->usb_int_cause |= MRVDRV_CMD_UPLD_RDY; |
609 | priv->upld_len = (recvlength - MESSAGE_HEADER_LEN); | 609 | priv->upld_len = (recvlength - MESSAGE_HEADER_LEN); |
610 | memcpy(cmdbuf, recvbuff + MESSAGE_HEADER_LEN, | 610 | memcpy(cmdbuf, recvbuff + MESSAGE_HEADER_LEN, |
611 | priv->upld_len); | 611 | priv->upld_len); |
@@ -682,7 +682,7 @@ static void if_usb_receive(struct urb *urb) | |||
682 | break; | 682 | break; |
683 | } | 683 | } |
684 | cardp->usb_event_cause <<= 3; | 684 | cardp->usb_event_cause <<= 3; |
685 | cardp->usb_int_cause |= his_cardevent; | 685 | cardp->usb_int_cause |= MRVDRV_CARDEVENT; |
686 | kfree_skb(skb); | 686 | kfree_skb(skb); |
687 | libertas_interrupt(priv->dev); | 687 | libertas_interrupt(priv->dev); |
688 | spin_unlock(&priv->adapter->driver_lock); | 688 | spin_unlock(&priv->adapter->driver_lock); |
diff --git a/drivers/net/wireless/libertas/main.c b/drivers/net/wireless/libertas/main.c index e8555de65762..170dc2394d25 100644 --- a/drivers/net/wireless/libertas/main.c +++ b/drivers/net/wireless/libertas/main.c | |||
@@ -711,20 +711,20 @@ static int libertas_thread(void *data) | |||
711 | adapter->currenttxskb, priv->dnld_sent); | 711 | adapter->currenttxskb, priv->dnld_sent); |
712 | 712 | ||
713 | /* command response? */ | 713 | /* command response? */ |
714 | if (adapter->hisregcpy & his_cmdupldrdy) { | 714 | if (adapter->hisregcpy & MRVDRV_CMD_UPLD_RDY) { |
715 | lbs_deb_thread("main-thread: cmd response ready\n"); | 715 | lbs_deb_thread("main-thread: cmd response ready\n"); |
716 | 716 | ||
717 | adapter->hisregcpy &= ~his_cmdupldrdy; | 717 | adapter->hisregcpy &= ~MRVDRV_CMD_UPLD_RDY; |
718 | spin_unlock_irq(&adapter->driver_lock); | 718 | spin_unlock_irq(&adapter->driver_lock); |
719 | libertas_process_rx_command(priv); | 719 | libertas_process_rx_command(priv); |
720 | spin_lock_irq(&adapter->driver_lock); | 720 | spin_lock_irq(&adapter->driver_lock); |
721 | } | 721 | } |
722 | 722 | ||
723 | /* Any Card Event */ | 723 | /* Any Card Event */ |
724 | if (adapter->hisregcpy & his_cardevent) { | 724 | if (adapter->hisregcpy & MRVDRV_CARDEVENT) { |
725 | lbs_deb_thread("main-thread: Card Event Activity\n"); | 725 | lbs_deb_thread("main-thread: Card Event Activity\n"); |
726 | 726 | ||
727 | adapter->hisregcpy &= ~his_cardevent; | 727 | adapter->hisregcpy &= ~MRVDRV_CARDEVENT; |
728 | 728 | ||
729 | if (priv->hw_read_event_cause(priv)) { | 729 | if (priv->hw_read_event_cause(priv)) { |
730 | lbs_pr_alert( | 730 | lbs_pr_alert( |