litmus-rt.git/virt, branch wip-edf-hsb

KVM: Fix reboot on Intel hosts

2010-09-23T14:31:56+00:00

When we reboot, we disable vmx extensions or otherwise INIT gets blocked.
If a task on another cpu hits a vmx instruction, it will fault if vmx is
disabled.  We trap that to avoid a nasty oops and spin until the reboot
completes.

Problem is, we sleep with interrupts disabled.  This blocks smp_send_stop()
from running, and the reboot process halts.

Fix by enabling interrupts before spinning.

KVM-Stable-Tag.
Signed-off-by: Avi Kivity 
Signed-off-by: Marcelo Tosatti

KVM: fix irqfd assign/deassign race

2010-09-23T14:31:51+00:00

I think I see the following (theoretical) race:

During irqfd assign, we drop irqfds lock before we
schedule inject work. Therefore, deassign running
on another CPU could cause shutdown and flush to run
before inject, causing user after free in inject.

A simple fix it to schedule inject under the lock.

Signed-off-by: Michael S. Tsirkin 
Acked-by: Gregory Haskins 
Signed-off-by: Marcelo Tosatti

KVM: x86: Perform hardware_enable in CPU_STARTING callback

2010-09-09T16:48:16+00:00

The CPU_STARTING callback was added upstream with the intention
of being used for KVM, specifically for the hardware enablement
that must be done before we can run in hardware virt.  It had
bugs on the x86_64 architecture at the time, where it was called
after CPU_ONLINE.  The arches have since merged and the bug is
gone.

It might be noted other features should probably start making
use of this callback; microcode updates in particular which
might be fixing important erratums would be best applied before
beginning to run user tasks.

Signed-off-by: Zachary Amsden 
Signed-off-by: Marcelo Tosatti

KVM: Convert mask notifiers to use irqchip/pin instead of gsi

2010-08-02T03:40:39+00:00

Devices register mask notifier using gsi, but irqchip knows about
irqchip/pin, so conversion from irqchip/pin to gsi should be done before
looking for mask notifier to call.

Signed-off-by: Gleb Natapov 
Signed-off-by: Marcelo Tosatti

KVM: Return EFAULT from kvm ioctl when guest accesses bad area

2010-08-02T03:40:33+00:00

Currently if guest access address that belongs to memory slot but is not
backed up by page or page is read only KVM treats it like MMIO access.
Remove that capability. It was never part of the interface and should
not be relied upon.

Signed-off-by: Gleb Natapov 
Signed-off-by: Avi Kivity

KVM: define hwpoison variables static

2010-08-02T03:40:32+00:00

They are not used outside of the file.

Signed-off-by: Gleb Natapov 
Signed-off-by: Avi Kivity

KVM: Use u64 for frame data types

2010-08-02T03:39:44+00:00

For 32bit machines where the physical address width is
larger than the virtual address width the frame number types
in KVM may overflow. Fix this by changing them to u64.

[sfr: fix build on 32-bit ppc]

Signed-off-by: Joerg Roedel 
Signed-off-by: Stephen Rothwell 
Signed-off-by: Marcelo Tosatti

KVM: Remove unnecessary divide operations

2010-08-01T07:47:30+00:00

This patch converts unnecessary divide and modulo operations
in the KVM large page related code into logical operations.
This allows to convert gfn_t to u64 while not breaking 32
bit builds.

Signed-off-by: Joerg Roedel 
Signed-off-by: Marcelo Tosatti

KVM: Fix IOMMU memslot reference warning

2010-08-01T07:47:29+00:00

This patch fixes the following warning.

===================================================
[ INFO: suspicious rcu_dereference_check() usage. ]
---------------------------------------------------
include/linux/kvm_host.h:259 invoked rcu_dereference_check() without
protection!

other info that might help us debug this:

rcu_scheduler_active = 1, debug_locks = 0
no locks held by qemu-system-x86/29679.

stack backtrace:
Pid: 29679, comm: qemu-system-x86 Not tainted 2.6.35-rc3+ #200
Call Trace:
 [] lockdep_rcu_dereference+0xa8/0xb1
 [] kvm_iommu_unmap_memslots+0xc9/0xde [kvm]
 [] kvm_iommu_unmap_guest+0x40/0x4e [kvm]
 [] kvm_arch_destroy_vm+0x1a/0x186 [kvm]
 [] kvm_put_kvm+0x110/0x167 [kvm]
 [] kvm_vcpu_release+0x18/0x1c [kvm]
 [] fput+0x22a/0x3a0
 [] filp_close+0xb4/0xcd
 [] put_files_struct+0x1b7/0x36b
 [] ? put_files_struct+0x48/0x36b
 [] ? do_raw_spin_unlock+0x118/0x160
 [] exit_files+0x6d/0x75
 [] do_exit+0x47d/0xc60
 [] ? _raw_spin_unlock_irq+0x30/0x36
 [] do_group_exit+0xcf/0x134
 [] get_signal_to_deliver+0x732/0x81d
 [] ? cpu_clock+0x4e/0x60
 [] do_notify_resume+0x117/0xc43
 [] ? trace_hardirqs_on+0xd/0xf
 [] ? sys_rt_sigtimedwait+0x2b5/0x3bf
 [] ? trace_hardirqs_off_thunk+0x3a/0x3c
 [] ? sysret_signal+0x5/0x3d
 [] int_signal+0x12/0x17

Signed-off-by: Sheng Yang 
Signed-off-by: Marcelo Tosatti

KVM: Fix a race condition for usage of is_hwpoison_address()

2010-08-01T07:47:11+00:00

is_hwpoison_address accesses the page table, so the caller must hold
current->mm->mmap_sem in read mode. So fix its usage in hva_to_pfn of
kvm accordingly.

Comment is_hwpoison_address to remind other users.

Reported-by: Avi Kivity 
Signed-off-by: Huang Ying 
Signed-off-by: Avi Kivity