litmus-rt.git/tools/perf/util, branch wip-default-clustering

perf trace scripting: Fix extern struct definitions

2010-10-04T15:24:51+00:00

Both python_scripting_ops and perl_scripting_ops have two global definitions.
One in trace-event-scripting.c and one in their respective scripting-engine
modules.

The issue is that depending on the linker order one definition or the other
is chosen. One is uninitialized (bss), while the other is initialized. If
the uninitialized version is chosen, then perf does not function properly.

This patch fixes this by adding the extern prefix to the definitions in
trace-event-scripting.c.

Cc: David S. Miller 
Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
Cc: Robert Richter 
LKML-Reference: <4c97e41a.078fd80a.7a8b.3cc9@mx.google.com>
Signed-off-by: Stephane Eranian 
Signed-off-by: Arnaldo Carvalho de Melo

perf ui hist browser: Fix segfault on 'a' for annotate

2010-10-04T15:08:37+00:00

There a typo in util/ui/browsers/hists.c that leads to a segfault when you
press the 'a' key on a non-resolved symbol (plain hex address).

LKML-Reference: <20100923201901.GE31726@gambetta>
Signed-off-by: Frederik Deweerdt 
Signed-off-by: Arnaldo Carvalho de Melo

perf symbols: Fix multiple initialization of symbol system

2010-09-09T20:43:35+00:00

By returning immediately if it was already initialized, do it as well at
symbol__exit, refusing multiple deinitializations.

This fixes problems in the kmem, sched and timechart commands.

Reported-by: Davidlohr Bueso 
Cc: Davidlohr Bueso 
Signed-off-by: Jovi Zhang 
LKML-Reference: AANLkTi=9Cn=R8SPMCRp5z+gEjXbaBHeb-AaOtRbuwwcn@mail.gmail.com
Signed-off-by: Arnaldo Carvalho de Melo

perf probe: Fix handling of arguments names

2010-09-08T14:47:19+00:00

Don't make argument names from raw parameters (means the parameters are written
in kprobe-tracer syntax), because the argument syntax may include special
characters.  Just leave it, then kprobe-tracer gives a new name.

Reported-by: Srikar Dronamraju 
Cc: Peter Zijlstra 
Cc: Paul Mackerras 
Cc: Ingo Molnar 
Cc: Arnaldo Carvalho de Melo 
Cc: Frederic Weisbecker 
LKML-Reference: <20100827113859.22882.75598.stgit@ltc236.sdl.hitachi.co.jp>
Signed-off-by: Masami Hiramatsu 
Signed-off-by: Arnaldo Carvalho de Melo

perf probe: Fix return probe support

2010-09-08T14:47:18+00:00

Fix a bug to support %return probe syntax again. Previous commit 4235b04 has a
bug which disables the %return syntax on perf probe.

Cc: Peter Zijlstra 
Cc: Paul Mackerras 
Cc: Ingo Molnar 
Cc: Arnaldo Carvalho de Melo 
Cc: Frederic Weisbecker 
LKML-Reference: <20100827113852.22882.87447.stgit@ltc236.sdl.hitachi.co.jp>
Signed-off-by: Masami Hiramatsu 
Signed-off-by: Arnaldo Carvalho de Melo

perf: Initialize callchains roots's childen hits

2010-08-26T23:51:36+00:00

Each histogram entry has a callchain root that stores the
callchain samples. However we forgot to initialize the
tracking of children hits of these roots, which then got
random values on their creation.

The root children hits is multiplied by the minimum percentage
of hits provided by the user, and the result becomes the minimum
hits expected from children branches. If the random value due
to the uninitialization is big enough, then this minimum number
of hits can be huge and eventually filter every children branches.

The end result was invisible callchains. All we need to
fix this is to initialize the children hits of the root.

Reported-by: Christoph Hellwig 
Signed-off-by: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Peter Zijlstra 
Cc: Arnaldo Carvalho de Melo 
Cc: Paul Mackerras 
Cc: 2.6.32.x-2.6.35.y

perf annotate tui: Fix exit and RIGHT keys handling

2010-08-16T13:43:54+00:00

As part of ongoing effort to reduce the coupling with libnewt, browsers
are being changed to return the exit key.

The annotate browser is not returning it as expected by builtin-annotate
when annotating multiple symbols (when 'perf annotate' is called without
specifying a symbol name).

Fix it by returning the exit key and also adding the RIGHT key as a exit
key so that going to the next symbol in the TUI can work again.

Cc: Frederic Weisbecker 
Cc: Peter Zijlstra 
LKML-Reference: 
Signed-off-by: Arnaldo Carvalho de Melo

perf: Add back list_head data types

2010-08-12T19:50:00+00:00

This commit:

 de5d9bf: Move list types from  to .

Moved the list head data types out of list.h, breaking the build.
Add them to the perf types.h as well.

Cc: Arnaldo Carvalho de Melo 
Cc: Peter Zijlstra 
Cc: Frederic Weisbecker 
Cc: Paul Mackerras 
Cc: Steven Rostedt 
LKML-Reference: 
Signed-off-by: Ingo Molnar

perf ui hist browser: Fixup key bindings

2010-08-10T18:50:07+00:00

To match what is shown when '?' or 'H' is pressed, i.e. the keybind help
window.

Cc: Frederic Weisbecker 
Cc: Mike Galbraith 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
LKML-Reference: 
Signed-off-by: Arnaldo Carvalho de Melo

perf ui browser: Add ui_browsershow counterpart: hide

2010-08-10T18:44:20+00:00

So that the common tasks of providing a helpline at __run entry and
destroying the window and releasing resourses at exit can be abstracted
away, reducing a bit more the coupling with libnewt.

Cc: Frederic Weisbecker 
Cc: Mike Galbraith 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
LKML-Reference: 
Signed-off-by: Arnaldo Carvalho de Melo