litmus-rt.git/tools/perf/util, branch linux-tip

perf symbols: Remove incorrect open-coded container_of()

2010-11-23T18:30:32+00:00

At least on ARM, padding is inserted between rb_node and sym in struct
symbol_name_rb_node, causing "((void *)sym) - sizeof(struct rb_node)" to
point inside rb_node rather than to the symbol_name_rb_node.  Fix this
by converting the code to use container_of().

Cc: Ian Munsie 
Cc: Ingo Molnar 
Cc: Ming Lei 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Cc: Tom Zanussi 
LKML-Reference: <20101123163106.GA25677@debian>
Signed-off-by: Rabin Vincent 
Signed-off-by: Arnaldo Carvalho de Melo

perf, ui: Eliminate stack-smashing protection compiler complaint

2010-11-10T08:04:32+00:00

The gcc complains about small auto-var strings being allocated from stack space.
Make them const to avoid this:

 | CC util/ui/util.o
 | cc1: warnings being treated as errors
 | util/ui/util.c: In function ‘ui__dialog_yesno’:
 | util/ui/util.c:108: error: not protecting function: no buffer at least 8 bytes long
 | make: *** [util/ui/util.o] Error 1

The real bug is in the newtWinChoice() ABI - but that's an
externality we cannot fix here, so we use this workaround.

Signed-off-by: Cyrill Gorcunov 
Acked-by: Frédéric Weisbecker 
Cc: Arnaldo Carvalho de Melo 
LKML-Reference: <20101106084724.GA5956@lenovo>
Signed-off-by: Ingo Molnar

perf scripting: Shut up 'perf record' final status

2010-10-26T17:20:09+00:00

We want just the script output, not internal details about the record phase.

Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Mike Galbraith 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Cc: Tom Zanussi 
LKML-Reference: 
Signed-off-by: Arnaldo Carvalho de Melo

perf probe: Fix format specified for Dwarf_Off parameter

2010-10-23T17:31:20+00:00

Fixing the following error on 32-bit arches:

util/probe-finder.c: In function ‘line_range_search_cb’:
util/probe-finder.c:1734: error: format ‘%lx’ expects type ‘long
unsigned int’, but argument 3 has type ‘Dwarf_Off’

Reported-by: Ingo Molnar 
Cc: Frederic Weisbecker 
Cc: Masami Hiramatsu 
LKML-Reference: 
Signed-off-by: Arnaldo Carvalho de Melo

perf tools: Remove direct slang.h include

2010-10-22T19:48:16+00:00

We wrap it in libslang.h because we need to deal with older slang release
where HAVE_LONG_LONG is referenced as:

So we need to define it.

Noticed when rebuilding the perf tools on a RHEL5 machine.

Cc: Frédéric Weisbecker 
Cc: Mike Galbraith 
Cc: Peter Zijlstra 
Cc: Paul Mackerras 
Cc: Stephane Eranian 
LKML-Reference: 
Signed-off-by: Arnaldo Carvalho de Melo

perf probe: Add basic module support

2010-10-21T18:11:44+00:00

Add basic module probe support on perf probe. This introduces "--module
" option to perf probe for putting probes and showing lines and
variables in the given module.

Currently, this supports only probing on running modules.  Supporting off-line
module probing is the next step.

e.g.)
[show lines]
 # ./perf probe --module drm -L drm_vblank_info

      0  int drm_vblank_info(struct seq_file *m, void *data)
      1  {
                struct drm_info_node *node = (struct drm_info_node *) m->private
      3         struct drm_device *dev = node->minor->dev;
 ...
[show vars]
 # ./perf probe --module drm -V drm_vblank_info:3
Available variables at drm_vblank_info:3
        @
                (unknown_type)  data
                struct drm_info_node*   node
                struct seq_file*        m
[put a probe]
 # ./perf probe --module drm drm_vblank_info:3 node m
Add new event:
  probe:drm_vblank_info (on drm_vblank_info:3 with node m)

You can now use it on all perf tools, such as:

        perf record -e probe:drm_vblank_info -aR sleep 1
[list probes]
 # ./perf probe -l
probe:drm_vblank_info (on drm_vblank_info:3@drivers/gpu/drm/drm_info.c with ...

Cc: Peter Zijlstra 
Cc: Paul Mackerras 
Cc: Ingo Molnar 
Cc: Frederic Weisbecker 
LKML-Reference: <20101021101341.3542.71638.stgit@ltc236.sdl.hitachi.co.jp>
Signed-off-by: Masami Hiramatsu 
Signed-off-by: Arnaldo Carvalho de Melo

perf probe: Show accessible global variables

2010-10-21T18:06:42+00:00

Add --externs for allowing --vars to show accessible global (externally
defined) variables from a given probe point too.

This will give you a hint which globals can be accessible from the probe point.

Cc: Peter Zijlstra 
Cc: Paul Mackerras 
Cc: Ingo Molnar 
Cc: Frederic Weisbecker 
LKML-Reference: <20101021101335.3542.31003.stgit@ltc236.sdl.hitachi.co.jp>
Signed-off-by: Masami Hiramatsu 
Signed-off-by: Arnaldo Carvalho de Melo

perf probe: Function style fix

2010-10-21T18:00:42+00:00

Just change the order of function arguments for ease of read; moving optional
bool flag to the last.

Cc: Peter Zijlstra 
Cc: Paul Mackerras 
Cc: Ingo Molnar 
Cc: Frederic Weisbecker 
LKML-Reference: <20101021101329.3542.51200.stgit@ltc236.sdl.hitachi.co.jp>
Signed-off-by: Masami Hiramatsu 
Signed-off-by: Arnaldo Carvalho de Melo

perf probe: Show accessible local variables

2010-10-21T17:59:06+00:00

Add -V (--vars) option for listing accessible local variables at given probe
point. This will help finding which local variables are available for event
arguments.

e.g.)
 # perf probe -V call_timer_fn:23
 Available variables at call_timer_fn:23
         @
                 function_type*  fn
                 int     preempt_count
                 long unsigned int       data
                 struct list_head        work_list
                 struct list_head*       head
                 struct timer_list*      timer
                 struct tvec_base*       base

Cc: Peter Zijlstra 
Cc: Paul Mackerras 
Cc: Ingo Molnar 
Cc: Frederic Weisbecker 
LKML-Reference: <20101021101323.3542.40282.stgit@ltc236.sdl.hitachi.co.jp>
Signed-off-by: Masami Hiramatsu 
Signed-off-by: Arnaldo Carvalho de Melo

perf probe: Support global variables

2010-10-21T17:58:27+00:00

Allow users to set external defined global variables as event arguments (e.g.
jiffies).

Cc: Peter Zijlstra 
Cc: Paul Mackerras 
Cc: Ingo Molnar 
LKML-Reference: <20101021101316.3542.1999.stgit@ltc236.sdl.hitachi.co.jp>
Signed-off-by: Masami Hiramatsu 
Signed-off-by: Arnaldo Carvalho de Melo