litmus-rt.git/scripts/coccinelle, branch test

scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning

2015-04-15T12:21:31+00:00

if()/BUG conversion to BUG_ON must be avoided when there's side effect
in condition. The reason being BUG_ON won't execute the condition when
CONFIG_BUG is not defined.

Inspired-by: J. Bruce Fields 
Suggested-by: Julia Lawall 
Acked-by: Julia Lawall 
Signed-off-by: Fabian Frederick 
Signed-off-by: Michal Marek

irqf_oneshot.cocci: add check of devm_request_threaded_irq()

2015-03-25T10:58:10+00:00

Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.

Until now, this coccinelle script only checked request_threaded_irq().
However, the counterpart devm function (see kernel/irq/devres.c) is also
affected by the missing flag which can be detected with this patch.

Signed-off-by: Valentin Rothberg 
Signed-off-by: Peter Senna Tschudin 
Acked-by: Julia Lawall 
Signed-off-by: Michal Marek

Merge branch 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild

2014-12-20T21:33:03+00:00

Pull misc kbuild changes from Michal Marek:
 "There are only a few things in the misc branch:

   - Fix for bugon.cocci semantic patch
   - Kdevelop4 files are .gitignored
   - Put make binrpm-pkg on diet"

* 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild:
  scripts/package: binrpm-pkg do not create source and devel package
  .gitignore: Add Kdevelop4 project files
  bugon.cocci: fix Options at the macro

bugon.cocci: fix Options at the macro

2014-11-24T21:04:27+00:00

The comma after --no-includes makes coccinelle to not run the script:

/usr/bin/spatch -D report --very-quiet --no-show-diff --cocci-file ./scripts/coccinelle/misc/bugon.cocci --no-includes, --include-headers --patch . --dir drivers/media/platform/coda/ -I ./arch/x86/include -I arch/x86/include/generated -I include -I ./arch/x86/include/uapi -I arch/x86/include/generated/uapi -I ./include/uapi -I include/generated/uapi -I ./include/linux/kconfig.h
Usage: spatch.opt --sp-file   [-o ] [--iso-file ] [options]
Options are:
  --sp-file                     the semantic patch file
  -o                            the output file
  --in-place                   do the modification on the file directly
  --backup-suffix              suffix to use when making a backup for inplace
...

At least with Fedora 20 coccinelle package:
	coccinelle-1.0.0-0.rc20.1.fc21.x86_64

Signed-off-by: Mauro Carvalho Chehab 
Acked-by: Julia Lawall 
Tested-by: Wolfram Sang 
Fixes: 5be1df66 (Coccinelle: Script to replace if and BUG with BUG_ON)
Cc: stable@vger.kernel.org
Signed-off-by: Michal Marek

coccinelle: api: add spatch to prevent unnecessary .owner

2014-11-06T23:16:02+00:00

There are calls which silently set the owner of a module. This is the
preferred way [1], so avoid setting it manually. Currently, we only care
about platform drivers, but there might be more calls to be added later.

[1] https://lkml.org/lkml/2014/10/12/87

Signed-off-by: Wolfram Sang 
Signed-off-by: Greg Kroah-Hartman

coccinelle: misc: semantic patch to delete overly complex return code processing

2014-09-26T11:42:31+00:00

This semantic patch simplifies cases where the effect of the processing of
a function call's return code is just to return the result of the function
directly.  It may also delete a local return flag variable, if this is no
longer used.

This was proposed by Uwe Kleine-König.

Signed-off-by: Julia Lawall 
Signed-off-by: Michal Marek

Merge branch 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild

2014-08-14T17:14:29+00:00

Pull misc kbuild updates from Michal Marek:
 "This is the non-critical part of kbuild for 3.17-rc1:

   - make help hint to use make -s with make kernelrelease et al.
   - moved a kbuild document to Documentation/kbuild where it belongs
   - four new Coccinelle scripts, one dropped and one fixed
   - new make kselftest target to run various tests on the kernel"

* 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild:
  kbuild: kselftest - new make target to build and run kernel selftests
  Coccinelle: Script to replace if and BUG with BUG_ON
  Coccinelle: Script to detect incorrect argument to sizeof
  Coccinelle: Script to use ARRAY_SIZE instead of division of two sizeofs
  Coccinelle: Script to detect cast after memory allocation
  coccinelle/null: solve parse error
  Documentation: headers_install.txt is part of kbuild
  kbuild: make -s should be used with kernelrelease/kernelversion/image_name

scripts/coccinelle/free/ifnullfree.cocci: add copyright information

2014-08-08T22:57:27+00:00

All coccinelle scripts have a copyright in the header.

Signed-off-by: Fabian Frederick 
Suggested-by: Julia Lawall 
Acked-by: Julia Lawall 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

scripts/coccinelle/free: add NULL test before freeing functions

2014-08-08T22:57:26+00:00

Warns or generates patch for NULL check before the following functions:

kfree
usb_free_urb
debugfs_remove
debugfs_remove_recursive

Signed-off-by: Fabian Frederick 
Acked-by: Julia Lawall 
Cc: Gilles Muller 
Cc: Joe Perches 
Cc: Markus Elfring 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Coccinelle: Script to replace if and BUG with BUG_ON

2014-08-06T10:10:17+00:00

This script detects cases where BUG() follows an if condition on an
expression and replaces the if condition and BUG() with a BUG_ON having
the conditional expression of the if statement as argument.

Signed-off-by: Himangi Saraogi 
Acked-by: Julia Lawall 
Signed-off-by: Michal Marek