litmus-rt.git/scripts/coccinelle/misc, branch test

scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning

2015-04-15T12:21:31+00:00

if()/BUG conversion to BUG_ON must be avoided when there's side effect
in condition. The reason being BUG_ON won't execute the condition when
CONFIG_BUG is not defined.

Inspired-by: J. Bruce Fields 
Suggested-by: Julia Lawall 
Acked-by: Julia Lawall 
Signed-off-by: Fabian Frederick 
Signed-off-by: Michal Marek

irqf_oneshot.cocci: add check of devm_request_threaded_irq()

2015-03-25T10:58:10+00:00

Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.

Until now, this coccinelle script only checked request_threaded_irq().
However, the counterpart devm function (see kernel/irq/devres.c) is also
affected by the missing flag which can be detected with this patch.

Signed-off-by: Valentin Rothberg 
Signed-off-by: Peter Senna Tschudin 
Acked-by: Julia Lawall 
Signed-off-by: Michal Marek

bugon.cocci: fix Options at the macro

2014-11-24T21:04:27+00:00

The comma after --no-includes makes coccinelle to not run the script:

/usr/bin/spatch -D report --very-quiet --no-show-diff --cocci-file ./scripts/coccinelle/misc/bugon.cocci --no-includes, --include-headers --patch . --dir drivers/media/platform/coda/ -I ./arch/x86/include -I arch/x86/include/generated -I include -I ./arch/x86/include/uapi -I arch/x86/include/generated/uapi -I ./include/uapi -I include/generated/uapi -I ./include/linux/kconfig.h
Usage: spatch.opt --sp-file   [-o ] [--iso-file ] [options]
Options are:
  --sp-file                     the semantic patch file
  -o                            the output file
  --in-place                   do the modification on the file directly
  --backup-suffix              suffix to use when making a backup for inplace
...

At least with Fedora 20 coccinelle package:
	coccinelle-1.0.0-0.rc20.1.fc21.x86_64

Signed-off-by: Mauro Carvalho Chehab 
Acked-by: Julia Lawall 
Tested-by: Wolfram Sang 
Fixes: 5be1df66 (Coccinelle: Script to replace if and BUG with BUG_ON)
Cc: stable@vger.kernel.org
Signed-off-by: Michal Marek

coccinelle: misc: semantic patch to delete overly complex return code processing

2014-09-26T11:42:31+00:00

This semantic patch simplifies cases where the effect of the processing of
a function call's return code is just to return the result of the function
directly.  It may also delete a local return flag variable, if this is no
longer used.

This was proposed by Uwe Kleine-König.

Signed-off-by: Julia Lawall 
Signed-off-by: Michal Marek

Coccinelle: Script to replace if and BUG with BUG_ON

2014-08-06T10:10:17+00:00

This script detects cases where BUG() follows an if condition on an
expression and replaces the if condition and BUG() with a BUG_ON having
the conditional expression of the if statement as argument.

Signed-off-by: Himangi Saraogi 
Acked-by: Julia Lawall 
Signed-off-by: Michal Marek

Coccinelle: Script to detect incorrect argument to sizeof

2014-08-06T10:10:17+00:00

This makes an effort to find cases where the argument to sizeof is wrong
in memory allocation functions by checking the type of the allocated
memory when it is a double pointer and ensuring the sizeof argument takes
a pointer to the the memory being allocated. There are false positives
in cases the sizeof argument is not used in constructing the return value.

Signed-off-by: Himangi Saraogi 
Acked-by: Julia Lawall 
Signed-off-by: Michal Marek

Coccinelle: Script to use ARRAY_SIZE instead of division of two sizeofs

2014-08-06T10:10:17+00:00

This script detects cases where ARRAY_SIZE can be used such as
where there is a division of sizeof the array by the sizeof its first
element or by any indexed element or the element type. It replaces the
division of the two sizeofs by ARRAY_SIZE.

Signed-off-by: Himangi Saraogi 
Acked-by: Julia Lawall 
Signed-off-by: Michal Marek

coccicheck: Add unneeded return variable test

2014-06-10T12:36:30+00:00

This semantic patch looks for variables that are initialized with a
constant, are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Signed-off-by: Peter Senna Tschudin 
Signed-off-by: Michal Marek

coccinelle: Check for missing NULL terminators in of_device_id tables

2014-06-09T21:39:16+00:00

Failure to terminate an of_device_id table can lead to confusing
failures depending on where the compiler places the array. Add a
check to make sure these tables are terminated. Thanks to Mitchel
Humpherys for coming up with the pattern initially.

Cc: Mitchel Humpherys 
Cc: Gilles Muller 
Cc: Nicolas Palix 
Cc: Rob Herring 
Cc: devicetree@vger.kernel.org
Signed-off-by: Stephen Boyd 
Acked-by: Grant Likely 
Signed-off-by: Julia Lawall 
Signed-off-by: Michal Marek

Coccicheck: Remove memcpy to struct assignment test

2014-03-29T20:35:09+00:00

The Coccinelle script scripts/coccinelle/misc/memcpy-assign.cocci look
for opportunities to replace a call to memcpy by a struct assignment.
This patch removes memcpy-assign.cocci as it is not clear that this
convention has an impact on the generated code.

Signed-off-by: Peter Senna Tschudin 
Signed-off-by: Michal Marek