litmus-rt.git/net/tipc, branch linux-tip

net: tipc: fix information leak to userland

2010-11-09T17:25:46+00:00

Structure sockaddr_tipc is copied to userland with padding bytes after
"id" field in union field "name" unitialized.  It leads to leaking of
contents of kernel stack memory.  We have to initialize them to zero.

Signed-off-by: Vasiliy Kulikov 
Signed-off-by: David S. Miller

Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6

2010-10-21T15:43:05+00:00

Conflicts:
	net/core/dev.c

tipc: delete needless memset from bearer enabling.

2010-10-21T11:25:51+00:00

Eliminates zeroing out of the new bearer structure at the start of
activation, since it is already in that state.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker 
Acked-by: Neil Horman 
Signed-off-by: David S. Miller

Revert d88dca79d3852a3623f606f781e013d61486828a

2010-10-21T11:11:08+00:00

TIPC needs to have its endianess issues fixed.  Unfortunately, the format of a
subscriber message is passed in directly from user space, so requiring this
message to be in network byte order breaks user space ABI.  Revert this change
until such time as we can determine how to do this in a backwards compatible
manner.

Signed-off-by: Neil Horman 
Signed-off-by: David S. Miller

Revert c6537d6742985da1fbf12ae26cde6a096fd35b5c

2010-10-21T11:11:07+00:00

Backout the tipc changes to the flags int he subscription message.  These
changees, while reasonable on the surface, interefere with user space ABI
compatibility which is a no-no.  This was part of the changes to fix the
endianess issues in the TIPC protocol, which would be really nice to do but we
need to do so in a way that is backwards compatible with user space.

Signed-off-by: Neil Horman 
Signed-off-by: David S. Miller

tipc: Simplify bearer shutdown logic

2010-10-18T08:50:49+00:00

Optimize processing in TIPC's bearer shutdown code, including:

1. Remove an unnecessary check to see if TIPC bearer's can exist.
2. Don't release spinlocks before calling a media-specific disabling
routine, since the routine can't sleep.
3. Make bearer_disable() operate directly on a struct bearer, instead
of needlessly taking a name and then mapping that to the struct.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker 
Reviewed-by: Neil Horman 
Signed-off-by: David S. Miller

tipc: Kill tipc_get_mode() completely.

2010-10-18T08:06:20+00:00

It's completely unused and exporting a static symbol
makes no sense and breaks the build.

Reported-by: Stephen Rothwell 
Signed-off-by: David S. Miller

tipc: cleanup function namespace

2010-10-16T18:13:24+00:00

Do some cleanups of TIPC based on make namespacecheck
  1. Don't export unused symbols
  2. Eliminate dead code
  3. Make functions and variables local
  4. Rename buf_acquire to tipc_buf_acquire since it is used in several files

Compile tested only.
This make break out of tree kernel modules that depend on TIPC routines.

Signed-off-by: Stephen Hemminger 
Acked-by: Jon Maloy 
Acked-by: Paul Gortmaker 
Signed-off-by: David S. Miller

tipc: clean out all instances of #if 0'd unused code

2010-10-13T21:27:34+00:00

Remove all instances of legacy, or as yet to be implemented code
that is currently living within an #if 0 ... #endif block.
In the rare instance that some of it be needed in the future,
it can still be dragged out of history, but there is no need
for it to sit in mainline.

Signed-off-by: Paul Gortmaker 
Acked-by: Neil Horman 
Signed-off-by: David S. Miller

net: return operator cleanup

2010-09-23T21:33:39+00:00

Change "return (EXPR);" to "return EXPR;"

return is not a function, parentheses are not required.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller