litmus-rt.git/net/ipv4, branch linux-tip

inet: Fix __inet_inherit_port() to correctly increment bsockets and num_owners

2010-11-29T02:18:44+00:00

inet sockets corresponding to passive connections are added to the bind hash
using ___inet_inherit_port(). These sockets are later removed from the bind
hash using __inet_put_port(). These two functions are not exactly symmetrical.
__inet_put_port() decrements hashinfo->bsockets and tb->num_owners, whereas
___inet_inherit_port() does not increment them. This results in both of these
going to -ve values.

This patch fixes this by calling inet_bind_hash() from ___inet_inherit_port(),
which does the right thing.

'bsockets' and 'num_owners' were introduced by commit a9d8f9110d7e953c
(inet: Allowing more than 64k connections and heavily optimize bind(0))

Signed-off-by: Nagendra Singh Tomar 
Acked-by: Eric Dumazet 
Acked-by: Evgeniy Polyakov 
Signed-off-by: David S. Miller

tcp: restrict net.ipv4.tcp_adv_win_scale (#20312)

2010-11-28T18:39:45+00:00

tcp_win_from_space() does the following:

      if (sysctl_tcp_adv_win_scale <= 0)
              return space >> (-sysctl_tcp_adv_win_scale);
      else
              return space - (space >> sysctl_tcp_adv_win_scale);

"space" is int.

As per C99 6.5.7 (3) shifting int for 32 or more bits is
undefined behaviour.

Indeed, if sysctl_tcp_adv_win_scale is exactly 32,
space >> 32 equals space and function returns 0.

Which means we busyloop in tcp_fixup_rcvbuf().

Restrict net.ipv4.tcp_adv_win_scale to [-31, 31].

Fix https://bugzilla.kernel.org/show_bug.cgi?id=20312

Steps to reproduce:

      echo 32 >/proc/sys/net/ipv4/tcp_adv_win_scale
      wget www.kernel.org
      [softlockup]

Signed-off-by: Alexey Dobriyan 
Signed-off-by: David S. Miller

netns: Don't leak others' openreq-s in proc

2010-11-28T06:57:48+00:00

The /proc/net/tcp leaks openreq sockets from other namespaces.

Signed-off-by: Pavel Emelyanov 
Signed-off-by: David S. Miller

tcp: Make TCP_MAXSEG minimum more correct.

2010-11-24T19:47:22+00:00

Use TCP_MIN_MSS instead of constant 64.

Reported-by: Min Zhang 
Signed-off-by: David S. Miller

net: allow GFP_HIGHMEM in __vmalloc()

2010-11-21T18:04:04+00:00

We forgot to use __GFP_HIGHMEM in several __vmalloc() calls.

In ceph, add the missing flag.

In fib_trie.c, xfrm_hash.c and request_sock.c, using vzalloc() is
cleaner and allows using HIGHMEM pages as well.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

xfrm: update flowi saddr in icmp_send if unset

2010-11-16T19:43:39+00:00

otherwise xfrm_lookup will fail to find correct policy

Signed-off-by: Ulrich Weber 
Signed-off-by: David S. Miller

tcp: Don't change unlocked socket state in tcp_v4_err().

2010-11-12T21:35:00+00:00

Alexey Kuznetsov noticed a regression introduced by
commit f1ecd5d9e7366609d640ff4040304ea197fbc618
("Revert Backoff [v3]: Revert RTO on ICMP destination unreachable")

The RTO and timer modification code added to tcp_v4_err()
doesn't check sock_owned_by_user(), which if true means we
don't have exclusive access to the socket and therefore cannot
modify it's critical state.

Just skip this new code block if sock_owned_by_user() is true
and eliminate the now superfluous sock_owned_by_user() code
block contained within.

Reported-by: Alexey Kuznetsov 
Signed-off-by: David S. Miller 
CC: Damian Lukowski 
Acked-by: Eric Dumazet

tcp: Increase TCP_MAXSEG socket option minimum.

2010-11-11T05:35:37+00:00

As noted by Steve Chen, since commit
f5fff5dc8a7a3f395b0525c02ba92c95d42b7390 ("tcp: advertise MSS
requested by user") we can end up with a situation where
tcp_select_initial_window() does a divide by a zero (or
even negative) mss value.

The problem is that sometimes we effectively subtract
TCPOLEN_TSTAMP_ALIGNED and/or TCPOLEN_MD5SIG_ALIGNED from the mss.

Fix this by increasing the minimum from 8 to 64.

Reported-by: Steve Chen 
Signed-off-by: David S. Miller

net: avoid limits overflow

2010-11-10T20:12:00+00:00

Robin Holt tried to boot a 16TB machine and found some limits were
reached : sysctl_tcp_mem[2], sysctl_udp_mem[2]

We can switch infrastructure to use long "instead" of "int", now
atomic_long_t primitives are available for free.

Signed-off-by: Eric Dumazet 
Reported-by: Robin Holt 
Reviewed-by: Robin Holt 
Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller

inet: fix ip_mc_drop_socket()

2010-11-09T16:26:42+00:00

commit 8723e1b4ad9be4444 (inet: RCU changes in inetdev_by_index())
forgot one call site in ip_mc_drop_socket()

We should not decrease idev refcount after inetdev_by_index() call,
since refcount is not increased anymore.

Reported-by: Markus Trippelsdorf 
Reported-by: Miles Lane 
Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller