litmus-rt.git/net/core, branch linux-tip

net: allow GFP_HIGHMEM in __vmalloc()

2010-11-21T18:04:04+00:00

We forgot to use __GFP_HIGHMEM in several __vmalloc() calls.

In ceph, add the missing flag.

In fib_trie.c, xfrm_hash.c and request_sock.c, using vzalloc() is
cleaner and allows using HIGHMEM pages as well.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net: fix kernel-doc for sk_filter_rcu_release

2010-11-19T17:27:15+00:00

Fix kernel-doc warning for sk_filter_rcu_release():

Warning(net/core/filter.c:586): missing initial short description on line:
 * 	sk_filter_rcu_release: Release a socket filter by rcu_head

Signed-off-by: Randy Dunlap 
Cc:	"David S. Miller" 
Cc:	netdev@vger.kernel.org
Signed-off-by: David S. Miller

net: zero kobject in rx_queue_release

2010-11-18T17:41:40+00:00

netif_set_real_num_rx_queues() can decrement and increment
the number of rx queues. For example ixgbe does this as
features and offloads are toggled. Presumably this could
also happen across down/up on most devices if the available
resources changed (cpu offlined).

The kobject needs to be zero'd in this case so that the
state is not preserved across kobject_put()/kobject_init_and_add().

This resolves the following error report.

ixgbe 0000:03:00.0: eth2: NIC Link is Up 10 Gbps, Flow Control: RX/TX
kobject (ffff880324b83210): tried to init an initialized object, something is seriously wrong.
Pid: 1972, comm: lldpad Not tainted 2.6.37-rc18021qaz+ #169
Call Trace:
 [] kobject_init+0x3a/0x83
 [] kobject_init_and_add+0x23/0x57
 [] ? mark_lock+0x21/0x267
 [] net_rx_queue_update_kobjects+0x63/0xc6
 [] netif_set_real_num_rx_queues+0x5f/0x78
 [] ixgbe_set_num_queues+0x1c6/0x1ca [ixgbe]
 [] ixgbe_init_interrupt_scheme+0x1e/0x79c [ixgbe]
 [] ixgbe_dcbnl_set_state+0x167/0x189 [ixgbe]

Signed-off-by: John Fastabend 
Acked-by: Eric Dumazet 
Signed-off-by: David S. Miller

rtnetlink: Fix message size calculation for link messages

2010-11-12T18:53:09+00:00

nlmsg_total_size() calculates the length of a netlink message
including header and alignment. nla_total_size() calculates the
space an individual attribute consumes which was meant to be used
in this context.

Also, ensure to account for the attribute header for the
IFLA_INFO_XSTATS attribute as implementations of get_xstats_size()
seem to assume that we do so.

The addition of two message headers minus the missing attribute
header resulted in a calculated message size that was larger than
required. Therefore we never risked running out of skb tailroom.

Signed-off-by: Thomas Graf 
Acked-by: Patrick McHardy 
Signed-off-by: David S. Miller

net: avoid limits overflow

2010-11-10T20:12:00+00:00

Robin Holt tried to boot a 16TB machine and found some limits were
reached : sysctl_tcp_mem[2], sysctl_udp_mem[2]

We can switch infrastructure to use long "instead" of "int", now
atomic_long_t primitives are available for free.

Signed-off-by: Eric Dumazet 
Reported-by: Robin Holt 
Reviewed-by: Robin Holt 
Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller

filter: make sure filters dont read uninitialized memory

2010-11-10T18:38:24+00:00

There is a possibility malicious users can get limited information about
uninitialized stack mem array. Even if sk_run_filter() result is bound
to packet length (0 .. 65535), we could imagine this can be used by
hostile user.

Initializing mem[] array, like Dan Rosenberg suggested in his patch is
expensive since most filters dont even use this array.

Its hard to make the filter validation in sk_chk_filter(), because of
the jumps. This might be done later.

In this patch, I use a bitmap (a single long var) so that only filters
using mem[] loads/stores pay the price of added security checks.

For other filters, additional cost is a single instruction.

[ Since we access fentry->k a lot now, cache it in a local variable
  and mark filter entry pointer as const. -DaveM ]

Reported-by: Dan Rosenberg 
Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net/dst: dst_dev_event() called after other notifiers

2010-11-09T20:17:16+00:00

Followup of commit ef885afbf8a37689 (net: use rcu_barrier() in
rollback_registered_many)

dst_dev_event() scans a garbage dst list that might be feeded by various
network notifiers at device dismantle time.

Its important to call dst_dev_event() after other notifiers, or we might
enter the infamous msleep(250) in netdev_wait_allrefs(), and wait one
second before calling again call_netdevice_notifiers(NETDEV_UNREGISTER,
dev) to properly remove last device references.

Use priority -10 to let dst_dev_notifier be called after other network
notifiers (they have the default 0 priority)

Reported-by: Ben Greear 
Reported-by: Nicolas Dichtel 
Reported-by: Octavian Purdila 
Reported-by: Benjamin LaHaise 
Tested-by: Ben Greear 
Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

pktgen: correct uninitialized queue_map

2010-11-08T20:17:07+00:00

This fix a bug reported by backyes.
Right the first time pktgen's using queue_map that's not been initialized
by set_cur_queue_map(pkt_dev);

Signed-off-by: Junchang Wang 
Signed-off-by: Backyes 
Signed-off-by: David S. Miller

NET: pktgen - fix compile warning

2010-11-07T13:28:01+00:00

This should fix the following warning:

net/core/pktgen.c: In function ‘pktgen_if_write’:
net/core/pktgen.c:890: warning: comparison of distinct pointer types lacks a cast

Signed-off-by: Dmitry Torokhov 
Reviewed-by: Nelson Elhage 
Signed-off-by: David S. Miller

net: check queue_index from sock is valid for device

2010-11-01T19:55:52+00:00

In dev_pick_tx recompute the queue index if the value stored in the
socket is greater than or equal to the number of real queues for the
device.  The saved index in the sock structure is not guaranteed to
be appropriate for the egress device (this could happen on a route
change or in presence of tunnelling).  The result of the queue index
being bad would be to return a bogus queue (crash could prersumably
follow).

Signed-off-by: Tom Herbert 
Signed-off-by: David S. Miller