litmus-rt.git/net/8021q, branch test

vlan: Correctly propagate promisc|allmulti flags in notifier.

2015-05-14T04:54:32+00:00

Currently vlan notifier handler will try to update all vlans
for a device when that device comes up.  A problem occurs,
however, when the vlan device was set to promiscuous, but not
by the user (ex: a bridge).  In that case, dev->gflags are
not updated.  What results is that the lower device ends
up with an extra promiscuity count.  Here are the
backtraces that prove this:
[62852.052179]  [] __dev_set_promiscuity+0x38/0x1e0
[62852.052186]  [] ? _raw_spin_unlock_bh+0x1b/0x40
[62852.052188]  [] ? dev_set_rx_mode+0x2e/0x40
[62852.052190]  [] dev_set_promiscuity+0x24/0x50
[62852.052194]  [] vlan_dev_open+0xd5/0x1f0 [8021q]
[62852.052196]  [] __dev_open+0xbf/0x140
[62852.052198]  [] __dev_change_flags+0x9d/0x170
[62852.052200]  [] dev_change_flags+0x29/0x60

The above comes from the setting the vlan device to IFF_UP state.

[62852.053569]  [] __dev_set_promiscuity+0x38/0x1e0
[62852.053571]  [] ? vlan_dev_set_rx_mode+0x2b/0x30
[8021q]
[62852.053573]  [] __dev_change_flags+0xe5/0x170
[62852.053645]  [] dev_change_flags+0x29/0x60
[62852.053647]  [] vlan_device_event+0x18a/0x690
[8021q]
[62852.053649]  [] notifier_call_chain+0x4c/0x70
[62852.053651]  [] raw_notifier_call_chain+0x16/0x20
[62852.053653]  [] call_netdevice_notifiers+0x2d/0x60
[62852.053654]  [] __dev_notify_flags+0x33/0xa0
[62852.053656]  [] dev_change_flags+0x52/0x60
[62852.053657]  [] do_setlink+0x397/0xa40

And this one comes from the notification code.  What we end
up with is a vlan with promiscuity count of 1 and and a physical
device with a promiscuity count of 2.  They should both have
a count 1.

To resolve this issue, vlan code can use dev_get_flags() api
which correctly masks promiscuity and allmulti flags.

Signed-off-by: Vlad Yasevich 
Signed-off-by: David S. Miller

vlan: implement ndo_get_iflink

2015-04-02T18:05:00+00:00

Don't use dev->iflink anymore.

CC: Patrick McHardy 
Signed-off-by: Nicolas Dichtel 
Signed-off-by: David S. Miller

vlan: Add features for stacked vlan device

2015-03-29T20:33:21+00:00

Stacked vlan devices curretly have few features (GRO, HIGHDMA, LLTX).
Since we have software fallbacks in case the NIC can not handle some
features for multiple vlans, we can add the same features as the lower
vlan devices for stacked vlan devices.

This allows stacked vlan devices to create large (GSO) packets and not to
segment packets. Those packets will be segmented by software on the real
device, or even can be segmented by the NIC once TSO for multiple vlans
becomes enabled by the following patches.

The exception is those related to FCoE, which does not have a software
fallback.

Signed-off-by: Toshiaki Makita 
Signed-off-by: David S. Miller

net: Fix high overhead of vlan sub-device teardown.

2015-03-19T02:52:56+00:00

When a networking device is taken down that has a non-trivial number
of VLAN devices configured under it, we eat a full synchronize_net()
for every such VLAN device.

This is because of the call chain:

	NETDEV_DOWN notifier
	--> vlan_device_event()
		--> dev_change_flags()
		--> __dev_change_flags()
		--> __dev_close()
		--> __dev_close_many()
		--> dev_deactivate_many()
			--> synchronize_net()

This is kind of rediculous because we already have infrastructure for
batching doing operation X to a list of net devices so that we only
incur one sync.

So make use of that by exporting dev_close_many() and adjusting it's
interfaace so that the caller can fully manage the batch list.  Use
this in vlan_device_event() and all the overhead goes away.

Reported-by: Salam Noureddine 
Signed-off-by: David S. Miller

8021q: Use eth__addr instead of memset

2015-03-03T22:01:37+00:00

Use the built-in function instead of memset.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

net: Kill dev_rebuild_header

2015-03-02T21:43:41+00:00

Now that there are no more users kill dev_rebuild_header and all of it's
implementations.

This is long overdue.

Signed-off-by: "Eric W. Biederman" 
Signed-off-by: David S. Miller

vlan: advertise link netns via netlink

2015-01-24T01:51:15+00:00

Assign rtnl_link_ops->get_link_net() callback so that IFLA_LINK_NETNSID is
added to rtnetlink messages.

Signed-off-by: Nicolas Dichtel 
Signed-off-by: David S. Miller

net: rename vlan_tx_* helpers since "tx" is misleading there

2015-01-13T22:51:08+00:00

The same macros are used for rx as well. So rename it.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

vlan: Add ability to always enable TSO/UFO

2014-12-12T15:58:53+00:00

Since the real device can segment packets by software, a vlan device
can set TSO/UFO even when the real device doesn't have those features.
Unlike GSO, this allows packets to be segmented after Qdisc.

Signed-off-by: Toshiaki Makita 
Signed-off-by: David S. Miller

vlan: Pass ethtool get_ts_info queries to real device.

2014-11-21T20:35:53+00:00

Commit a6111d3c "vlan: Pass SIOC[SG]HWTSTAMP ioctls to real device"
intended to enable hardware time stamping on VLAN interfaces, but
passing SIOCSHWTSTAMP is only half of the story. This patch adds
the second half, by letting user space find out the time stamping
capabilities of the device backing a VLAN interface.

Signed-off-by: Richard Cochran 
Signed-off-by: David S. Miller