litmus-rt.git/drivers/target, branch v2015.1

target: Use a PASSTHROUGH flag instead of transport_types

2015-05-31T02:58:11+00:00

It seems like we only care if a transport is passthrough or not. Convert
transport_type to a flags field and replace TRANSPORT_PLUGIN_* with a
flag, TRANSPORT_FLAG_PASSTHROUGH.

Signed-off-by: Andy Grover 
Reviewed-by: Ilias Tsitsimpis 
Signed-off-by: Nicholas Bellinger

target: Move passthrough CDB parsing into a common function

2015-05-31T02:57:59+00:00

Aside from whether they handle BIDI ops or not, parsing of the CDB by
kernel and user SCSI passthrough modules should be identical. Move this
into a new passthrough_parse_cdb() and call it from tcm-pscsi and tcm-user.

Reported-by: Christoph Hellwig 
Reviewed-by: Ilias Tsitsimpis 
Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target/user: Only support full command pass-through

2015-05-31T02:57:48+00:00

After much discussion, give up on only passing a subset of SCSI commands
to userspace and pass them all. Based on what pscsi is doing, make sure
to set SCF_SCSI_DATA_CDB for I/O ops, and define attributes identical to
pscsi.

Make hw_block_size configurable via dev param.

Remove mention of command filtering from tcmu-design.txt.

Signed-off-by: Andy Grover 
Reviewed-by: Ilias Tsitsimpis 
Signed-off-by: Nicholas Bellinger

target/pscsi: Don't leak scsi_host if hba is VIRTUAL_HOST

2015-05-31T02:11:02+00:00

See https://bugzilla.redhat.com/show_bug.cgi?id=1025672

We need to put() the reference to the scsi host that we got in
pscsi_configure_device(). In VIRTUAL_HOST mode it is associated with
the dev_virt, not the hba_virt.

Signed-off-by: Andy Grover 
Cc: stable@vger.kernel.org # 2.6.38+
Signed-off-by: Nicholas Bellinger

target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem

2015-05-31T01:04:20+00:00

There is just one configfs subsystem in the target code, so we might as
well add two helpers to reference / unreference it from the core code
instead of passing pointers to it around.

This fixes a regression introduced for v4.1-rc1 with commit 9ac8928e6,
where configfs_depend_item() callers using se_tpg_tfo->tf_subsys would
fail, because the assignment from the original target_core_subsystem[]
is no longer happening at target_register_template() time.

(Fix target_core_exit_configfs pointer dereference - Sagi)

Signed-off-by: Christoph Hellwig 
Reported-by: Himanshu Madhani 
Signed-off-by: Nicholas Bellinger

target: Drop signal_pending checks after interruptible lock acquire

2015-05-19T22:18:20+00:00

Once upon a time, iscsit_get_tpg() was using an un-interruptible
lock.  The signal_pending() usage was a check to allow userspace
to break out of the operation with SIGINT.

AFAICT, there's no reason why this is necessary anymore, and as
reported by Alexey can be potentially dangerous.  Also, go ahead
and drop the other two problematic cases within iscsit_access_np()
and sbc_compare_and_write() as well.

Found by Linux Driver Verification project (linuxtesting.org).

Reported-by: Alexey Khoroshilov 
Signed-off-by: Nicholas Bellinger

target: Add missing parentheses

2015-05-15T04:13:37+00:00

Code like " &= ~CMD_T_BUSY | ..." only clears CMD_T_BUSY but not
the other flag. Modify these statements such that both flags are
cleared.

(Fix fuzz for target_write_prot_action code in mainline - nab)

Signed-off-by: Bart Van Assche 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: Fix bidi command handling

2015-05-15T04:13:31+00:00

The function transport_complete_qf() must call either
queue_data_in() or queue_status() but not both.

Signed-off-by: Bart Van Assche 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target/user: Disallow full passthrough (pass_level=0)

2015-05-03T01:20:51+00:00

TCMU requires more work to correctly handle both user handlers that want
all SCSI commands (pass_level=0) for a se_device, and also handlers that
just want I/O commands and let the others be emulated by the kernel
(pass_level=1). Only support the latter for now.

For full passthrough, we will need to support a second se_subsystem_api
template, due to configfs attributes being different between the two modes.
Thus pass_level is extraneous, and we can remove it.

The ABI break for TCMU v2 is already applied for this release, so it's
best to do this now to avoid another ABI break in the future.

Signed-off-by: Andy Grover 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

ISCSI: fix minor memory leak

2015-05-02T23:31:33+00:00

This patch adds a missing kfree for sess->sess_ops memory upon
transport_init_session() failure.

Signed-off-by: Evgenii Lepikhin 
Signed-off-by: Nicholas Bellinger